Home » Mailing list archives » linux-netdev » 2008 » August » 5

iproute2/m_ipt fix, opts was not set properly

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Denys Fedoryshchenko <denys@...>
To: Stephen Hemminger <shemminger@...>
Cc: <netdev@...>
Subject: iproute2/m_ipt fix, opts was not set properly
Date: Tuesday, August 5, 2008 - 3:24 pm

Since opts global variable, if it is set to original_opts, it was done in 
local context of function, and global variable in result was pointing to 
freed memory. Sure result of that - segfault, it is possible to trigger it 
only while processing batch, cause only on next iteration opts was wrong.

There is two ways to fix that, both patches attached.
Please send me note, which way correct (at least i will learn something :-) )
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
iproute2/m_ipt fix, opts was not set properly, Denys Fedoryshchenko, (Tue Aug 5, 3:24 pm)
Re: iproute2/m_ipt fix, opts was not set properly, jamal, (Wed Aug 6, 5:52 am)
Re: iproute2/m_ipt fix, opts was not set properly, Denys Fedoryshchenko, (Wed Aug 6, 6:06 am)
Re: iproute2/m_ipt fix, opts was not set properly, jamal, (Wed Aug 6, 6:42 am)
Re: iproute2/m_ipt fix, opts was not set properly, jamal, (Wed Aug 6, 6:52 am)
Re: iproute2/m_ipt fix, opts was not set properly, Denys Fedoryshchenko, (Wed Aug 6, 7:02 am)
Re: iproute2/m_ipt fix, opts was not set properly, jamal, (Wed Aug 6, 7:18 am)