Re: [PATCH]&[Question] netdevice: Use netdev_priv()

view
thread

!MAILaRCHIVE_VOTE_RePLACE

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

[view in full thread]

From: Divy Le Ray <divy@...>

To: David Miller <davem@...>

Cc: <wangchen@...>, <netdev@...>

Subject: Re: [PATCH]&[Question] netdevice: Use netdev_priv()

Date: Tuesday, August 5, 2008 - 1:51 pm

On Tuesday 05 August 2008 03:04:33 am David Miller wrote:
quoted text> From: Wang Chen <wangchen@cn.fujitsu.com>
> Date: Tue, 05 Aug 2008 17:55:27 +0800
>
> > init_one() of cxgb2 makes several net_device to share one private data.
> > For this purpose, direct reference is necessary.
>
> It should use netdev->ml_priv which is created for this purpose.
>
> Every direct netdev->priv usage is a bug.

cxgb3 was fixed in this regard, cxgb2 needs the same treatment ...

cheers,
Divy
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

[PATCH]&[Question] netdevice: Use netdev_priv(), Wang Chen, (Fri Aug 1, 5:50 am)

Re: [PATCH]&[Question] netdevice: Use netdev_priv(), David Miller, (Fri Aug 1, 6:08 am)

Re: [PATCH]&[Question] netdevice: Use netdev_priv(), Wang Chen, (Fri Aug 1, 6:16 am)

Re: [PATCH]&[Question] netdevice: Use netdev_priv(), David Miller, (Fri Aug 1, 6:24 am)

Re: [PATCH]&[Question] netdevice: Use netdev_priv(), Wang Chen, (Fri Aug 1, 6:35 am)

Re: [PATCH]&[Question] netdevice: Use netdev_priv(), David Miller, (Fri Aug 1, 7:05 am)

Re: [PATCH]&[Question] netdevice: Use netdev_priv(), Wang Chen, (Tue Aug 5, 5:55 am)

Re: [PATCH]&[Question] netdevice: Use netdev_priv(), David Miller, (Tue Aug 5, 6:04 am)

Re: [PATCH]&[Question] netdevice: Use netdev_priv(), Divy Le Ray, (Tue Aug 5, 1:51 pm)

Re: [PATCH]&[Question] netdevice: Use netdev_priv(), Wang Chen, (Wed Aug 6, 12:21 am)

Navigation

Popular discussions


linux-kernel:
Greg KH	[GIT PATCH] driver core patches against 2.6.24
Tarkan Erimer	Re: Dual-Licensing Linux Kernel with GPL V2 and GPL V3
Bart Van Assche	Integration of SCST in the mainstream Linux kernel
Jeff Garzik	Re: fallocate-implementation-on-i86-x86_64-and-powerpc.patch
git:

linux-netdev:
David Miller	Re: [PATCH] pkt_sched: Destroy gen estimators under rtnl_lock().
Arjan van de Ven	Re: [GIT]: Networking
Gerrit Renker	[PATCH 15/37] dccp: Set per-connection CCIDs via socket options
Natalie Protasevich	[BUG] New Kernel Bugs
openbsd-misc:

Colocation donated by: