Home » Mailing list archives » linux-netdev » 2008 » August » 26

[PATCH resend 1/1] r8169: balance pci_map / pci_unmap pair

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Francois Romieu <romieu@...>
To: David Miller <davem@...>
Cc: Jeff Garzik <jeff@...>, <netdev@...>, Ilpo <ilpo.jarvinen@...>, Alistair John Strachan <alistair@...>, Timothy J Fontaine <tjfontaine@...>, Edward Hsu <edward_hsu@...>, Andrew Morton <akpm@...>, Ivan Vecera <ivecera@...>
Subject: [PATCH resend 1/1] r8169: balance pci_map / pci_unmap pair
Date: Tuesday, August 26, 2008 - 3:56 pm

The leak hurts with swiotlb and jumbo frames.

Fix http://bugzilla.kernel.org/show_bug.cgi?id=9468.

Heavily hinted by Ilpo Järvinen <ilpo.jarvinen@helsinki.fi>.

Signed-off-by: Francois Romieu <romieu@fr.zoreil.com>
Tested-by: Alistair John Strachan <alistair@devzero.co.uk>
Tested-by: Timothy J Fontaine <tjfontaine@atxconsulting.com>
Cc: Edward Hsu <edward_hsu@realtek.com.tw>
---
 drivers/net/r8169.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/r8169.c b/drivers/net/r8169.c
index a3e3895..0f6f974 100644
--- a/drivers/net/r8169.c
+++ b/drivers/net/r8169.c
@@ -2792,7 +2792,7 @@ static int rtl8169_rx_interrupt(struct net_device *dev,
 					pkt_size, PCI_DMA_FROMDEVICE);
 				rtl8169_mark_to_asic(desc, tp->rx_buf_sz);
 			} else {
-				pci_unmap_single(pdev, addr, pkt_size,
+				pci_unmap_single(pdev, addr, tp->rx_buf_sz,
 						 PCI_DMA_FROMDEVICE);
 				tp->Rx_skbuff[entry] = NULL;
 			}
-- 
1.5.3.3
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH resend 1/1] r8169: balance pci_map / pci_unmap pair, Francois Romieu, (Tue Aug 26, 3:56 pm)
Re: [PATCH resend 1/1] r8169: balance pci_map / pci_unmap pair, Jeff Garzik, (Wed Aug 27, 5:18 am)