RE: [BUG] NULL pointer dereference in skb_dequeue

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: David Miller <davem@...>, jarkao2@gmail.com <jarkao2@...>
Cc: Kirsher, Jeffrey T <jeffrey.t.kirsher@...>, netdev@vger.kernel.org <netdev@...>
Date: Saturday, August 2, 2008 - 3:45 pm

Still no luck.

I was able to reset the interfaces and change the MTU multiple times until eventually the system froze. No trace.

Emil

-----Original Message-----
From: David Miller [mailto:davem@davemloft.net]
Sent: Saturday, August 02, 2008 12:23 PM
To: jarkao2@gmail.com
Cc: Tantilov, Emil S; Kirsher, Jeffrey T; netdev@vger.kernel.org
Subject: Re: [BUG] NULL pointer dereference in skb_dequeue

From: David Miller <davem@davemloft.net>
Date: Sat, 02 Aug 2008 12:18:15 -0700 (PDT)


Sorry, because some idiot took part of the conversation private
my follow-on fixup patch didn't make it to the list, here it is.

It goes on top of the original patch I sent out:

diff --git a/net/core/dev.c b/net/core/dev.c
index 69320a5..da7acac 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -1796,7 +1796,7 @@ gso:
        skb->tc_verd = SET_TC_AT(skb->tc_verd,AT_EGRESS);
 #endif
        if (q->enqueue) {
-               spinlock_t *root_lock = qdisc_root_lock(q);
+               spinlock_t *root_lock = qdisc_lock(q);

                spin_lock(root_lock);

@@ -1995,7 +1995,7 @@ static void net_tx_action(struct softirq_action *h)
                        smp_mb__before_clear_bit();
                        clear_bit(__QDISC_STATE_SCHED, &q->state);

-                       root_lock = qdisc_root_lock(q);
+                       root_lock = qdisc_lock(q);
                        if (spin_trylock(root_lock)) {
                                qdisc_run(q);
                                spin_unlock(root_lock);
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[BUG] NULL pointer dereference in skb_dequeue, Jeff Kirsher, (Fri Aug 1, 7:40 pm)
Re: [BUG] NULL pointer dereference in skb_dequeue, David Miller, (Fri Aug 1, 9:03 pm)
Re: [BUG] NULL pointer dereference in skb_dequeue, David Miller, (Fri Aug 1, 9:20 pm)
RE: [BUG] NULL pointer dereference in skb_dequeue, Tantilov, Emil S, (Sat Aug 2, 5:36 am)
Re: [BUG] NULL pointer dereference in skb_dequeue, Jarek Poplawski, (Sat Aug 2, 9:37 am)
Re: [BUG] NULL pointer dereference in skb_dequeue, Jarek Poplawski, (Sat Aug 2, 12:27 pm)
Re: [BUG] NULL pointer dereference in skb_dequeue, David Miller, (Sat Aug 2, 3:18 pm)
Re: [BUG] NULL pointer dereference in skb_dequeue, Jarek Poplawski, (Sat Aug 2, 4:19 pm)
Re: [BUG] NULL pointer dereference in skb_dequeue, Jarek Poplawski, (Sun Aug 3, 5:29 am)
Re: [BUG] NULL pointer dereference in skb_dequeue, David Miller, (Sun Aug 3, 5:56 am)
Re: [BUG] NULL pointer dereference in skb_dequeue, Jarek Poplawski, (Sun Aug 3, 6:08 am)
Re: [BUG] NULL pointer dereference in skb_dequeue, Jarek Poplawski, (Sun Aug 3, 5:50 am)
Re: [BUG] NULL pointer dereference in skb_dequeue, David Miller, (Sat Aug 2, 3:22 pm)
RE: [BUG] NULL pointer dereference in skb_dequeue, Tantilov, Emil S, (Sat Aug 2, 3:45 pm)
RE: [BUG] NULL pointer dereference in skb_dequeue, Tantilov, Emil S, (Sat Aug 2, 5:46 pm)
Re: [BUG] NULL pointer dereference in skb_dequeue, David Miller, (Sat Aug 2, 10:26 pm)
RE: [BUG] NULL pointer dereference in skb_dequeue, Tantilov, Emil S, (Fri Aug 8, 3:38 pm)
Re: [BUG] NULL pointer dereference in skb_dequeue, David Miller, (Sat Aug 9, 3:29 am)
Re: [BUG] NULL pointer dereference in skb_dequeue, Jarek Poplawski, (Sat Aug 9, 6:32 pm)
Re: [BUG] NULL pointer dereference in skb_dequeue, Jarek Poplawski, (Sun Aug 10, 3:04 pm)
Re: [BUG] NULL pointer dereference in skb_dequeue, Jarek Poplawski, (Mon Aug 11, 6:01 am)
Re: [BUG] NULL pointer dereference in skb_dequeue, Paul E. McKenney, (Mon Aug 11, 7:26 pm)
Re: [BUG] NULL pointer dereference in skb_dequeue, Jarek Poplawski, (Tue Aug 12, 2:36 am)
Re: [BUG] NULL pointer dereference in skb_dequeue, Paul E. McKenney, (Tue Aug 12, 9:42 am)
Re: [BUG] NULL pointer dereference in skb_dequeue, Jarek Poplawski, (Tue Aug 12, 2:09 pm)
Re: [BUG] NULL pointer dereference in skb_dequeue, Paul E. McKenney, (Tue Aug 12, 4:18 pm)
Re: [BUG] NULL pointer dereference in skb_dequeue, Jarek Poplawski, (Tue Aug 12, 5:15 pm)
Re: [BUG] NULL pointer dereference in skb_dequeue, Paul E. McKenney, (Tue Aug 12, 6:33 pm)