Ingo Molnar wrote:
quoted text
> * Suresh Siddha <suresh.b.siddha@intel.com> wrote:
> 
>> Reported-and-bisected-by: Wolfgang Walter <wolfgang.walter@stwm.de>
>> Signed-off-by: Suresh Siddha <suresh.b.siddha@intel.com>
> 
> no fundamental objection to the x86 bits.
> 
> shouldnt this:
> 
> +       if (!in_interrupt())
> +               return 0;
> 
> just be eliminated and the cr0/TS save/restore be made unconditional?  
> irq-assymetric APIs are not nice in general.
> 
> Reading/setting cr0 isnt _that_ slow. (or if it is, by how much does it 
> slow things down, exactly?)
> 

Setting it is relatively slow.  I think that's part of the reason for 
special instructions to muck with the TS flag.

Reading it might be slow on obsolete processors.

	-hpa
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html