On Fri, Aug 01, 2008 at 02:18:25AM -0700, David Miller wrote:
quoted text
>
> SCTP calls ip_queue_xmit() and ip6_xmit() directly with it's ipfragok
> argument, so it is used for these functions.
> 
> As a result ->icsk_af_ops->queue_xmit() needs to have arguments
> at least matching those function's prototypes.

Hmm, so SCTP is the only reason why ipfragok exists and yet it
doesn't even use icsk_af_ops->queue_xmit.  So unless SCTP has
plans to use icsk_af_ops, perhaps we could provide it a copy of
ip_queue_xmit/ip6_xmit that has the ipfragok argument and then
put a wrapper around them without the argument for icsk_af_ops
and everybody else.

Who knows, it might even save more memory than the ethtool hack :)

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html