Re: [RFC][PATCH 1/1] cxgb3i: cxgb3 iSCSI initiator

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Karen Xie <kxie@...>
Cc: <netdev@...>, <open-iscsi@...>, <jgarzik@...>, <davem@...>, <michaelc@...>, <swise@...>, <daisyc@...>, <wenxiong@...>, <bhua@...>, <divy@...>, <dm@...>, <leedom@...>
Date: Wednesday, July 30, 2008 - 3:21 pm

> Cxgb3i iSCSI driver

I think a little more detail in the changelog would be
helpful... something like what you had in the 0/1 email (no reason to
put that nice info in an email that will be discarded rather than in the
patch that will be merged).  Maybe:

  The cxgb3i driver provides iscsi acceleration (PDU digest offload and
  payload direct-placement) to the open-iscsi initiator.  It accesses
  the hardware through the cxgb3 module.

I didn't read in detail yet but one quick comments:

 > --- /dev/null
 > +++ b/drivers/scsi/cxgb3i/Kconfig
 > @@ -0,0 +1,6 @@
 > +config SCSI_CXGB3_ISCSI
 > +	tristate "Chelsio S3xx iSCSI support"
 > +	select CHELSIO_T3
 > +	select SCSI_ISCSI_ATTRS
 > +	---help---
 > +	This driver supports iSCSI offload for the Chelsio S3 series devices.

I don't see any other Kconfig changes that hook this Kconfig file into
the build?  Also are there sufficient dependencies to avoid broken
configs here?

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[RFC][PATCH 1/1] cxgb3i: cxgb3 iSCSI initiator, Karen Xie, (Tue Jul 29, 8:19 pm)
Re: [RFC][PATCH 1/1] cxgb3i: cxgb3 iSCSI initiator, Boaz Harrosh, (Thu Jul 31, 8:33 am)
Re: [RFC][PATCH 1/1] cxgb3i: cxgb3 iSCSI initiator, Jeff Garzik, (Wed Jul 30, 3:35 pm)
Re: [RFC][PATCH 1/1] cxgb3i: cxgb3 iSCSI initiator, Roland Dreier, (Wed Jul 30, 5:35 pm)
Re: [RFC][PATCH 1/1] cxgb3i: cxgb3 iSCSI initiator, Divy Le Ray, (Thu Jul 31, 8:51 pm)
Re: [RFC][PATCH 1/1] cxgb3i: cxgb3 iSCSI initiator, Divy Le Ray, (Thu Aug 7, 2:45 pm)
Re: [RFC][PATCH 1/1] cxgb3i: cxgb3 iSCSI initiator, Steve Wise, (Fri Aug 8, 2:09 pm)
Re: [RFC][PATCH 1/1] cxgb3i: cxgb3 iSCSI initiator, Jeff Garzik, (Fri Aug 8, 6:15 pm)
Re: [RFC][PATCH 1/1] cxgb3i: cxgb3 iSCSI initiator, Roland Dreier, (Sun Aug 10, 1:12 am)
Re: [RFC][PATCH 1/1] cxgb3i: cxgb3 iSCSI initiator, Jeff Garzik, (Sun Aug 10, 8:49 am)
Re: [RFC][PATCH 1/1] cxgb3i: cxgb3 iSCSI initiator, James Bottomley, (Sun Aug 10, 10:54 am)
Re: [RFC][PATCH 1/1] cxgb3i: cxgb3 iSCSI initiator, Mike Christie, (Mon Aug 11, 12:50 pm)
Re: [RFC][PATCH 1/1] cxgb3i: cxgb3 iSCSI initiator, Herbert Xu, (Sun Aug 10, 2:24 am)
Re: [RFC][PATCH 1/1] cxgb3i: cxgb3 iSCSI initiator, David Miller, (Sun Aug 10, 1:46 am)
Re: [RFC][PATCH 1/1] cxgb3i: cxgb3 iSCSI initiator, Rick Jones, (Mon Aug 11, 2:13 pm)
Re: [RFC][PATCH 1/1] cxgb3i: cxgb3 iSCSI initiator, David Miller, (Mon Aug 11, 5:12 pm)
Re: [RFC][PATCH 1/1] cxgb3i: cxgb3 iSCSI initiator, Andrew Gallatin, (Thu Aug 14, 4:45 pm)
Re: [RFC][PATCH 1/1] cxgb3i: cxgb3 iSCSI initiator, David Miller, (Thu Aug 14, 6:23 pm)
Re: [RFC][PATCH 1/1] cxgb3i: cxgb3 iSCSI initiator, Andrew Gallatin, (Fri Aug 15, 8:19 am)
Re: [RFC][PATCH 1/1] cxgb3i: cxgb3 iSCSI initiator, Roland Dreier, (Mon Aug 11, 5:41 pm)
Re: [RFC][PATCH 1/1] cxgb3i: cxgb3 iSCSI initiator, David Miller, (Mon Aug 11, 5:53 pm)
Re: [RFC][PATCH 1/1] cxgb3i: cxgb3 iSCSI initiator, Roland Dreier, (Wed Aug 13, 5:27 pm)
Re: [RFC][PATCH 1/1] cxgb3i: cxgb3 iSCSI initiator, David Miller, (Wed Aug 13, 6:08 pm)
Re: [RFC][PATCH 1/1] cxgb3i: cxgb3 iSCSI initiator, Roland Dreier, (Wed Aug 13, 7:03 pm)
Re: [RFC][PATCH 1/1] cxgb3i: cxgb3 iSCSI initiator, David Miller, (Wed Aug 13, 7:12 pm)
Re: [RFC][PATCH 1/1] cxgb3i: cxgb3 iSCSI initiator, Tom Tucker, (Wed Aug 13, 9:26 pm)
Re: [RFC][PATCH 1/1] cxgb3i: cxgb3 iSCSI initiator, David Miller, (Wed Aug 13, 10:09 pm)
Re: [RFC][PATCH 1/1] cxgb3i: cxgb3 iSCSI initiator, David Miller, (Wed Aug 13, 9:37 pm)
Re: [RFC][PATCH 1/1] cxgb3i: cxgb3 iSCSI initiator, Tom Tucker, (Wed Aug 13, 9:57 pm)
Re: [RFC][PATCH 1/1] cxgb3i: cxgb3 iSCSI initiator, David Miller, (Wed Aug 13, 10:07 pm)
Re: [RFC][PATCH 1/1] cxgb3i: cxgb3 iSCSI initiator, Steve Wise, (Wed Aug 13, 9:52 pm)
Re: [RFC][PATCH 1/1] cxgb3i: cxgb3 iSCSI initiator, David Miller, (Wed Aug 13, 10:05 pm)
Re: [RFC][PATCH 1/1] cxgb3i: cxgb3 iSCSI initiator, Steve Wise, (Wed Aug 13, 10:44 pm)
Re: [RFC][PATCH 1/1] cxgb3i: cxgb3 iSCSI initiator, Divy Le Ray, (Tue Aug 12, 5:57 pm)
Re: [RFC][PATCH 1/1] cxgb3i: cxgb3 iSCSI initiator, David Miller, (Tue Aug 12, 6:02 pm)
Re: [RFC][PATCH 1/1] cxgb3i: cxgb3 iSCSI initiator, Divy Le Ray, (Tue Aug 12, 6:21 pm)
Re: [RFC][PATCH 1/1] cxgb3i: cxgb3 iSCSI initiator, Vladislav Bolkhovitin, (Wed Aug 13, 2:35 pm)
Re: [RFC][PATCH 1/1] cxgb3i: cxgb3 iSCSI initiator, David Miller, (Wed Aug 13, 4:23 pm)
Re: [RFC][PATCH 1/1] cxgb3i: cxgb3 iSCSI initiator, Vladislav Bolkhovitin, (Thu Aug 14, 2:27 pm)
Re: [RFC][PATCH 1/1] cxgb3i: cxgb3 iSCSI initiator, Vladislav Bolkhovitin, (Thu Aug 14, 2:30 pm)
Re: [RFC][PATCH 1/1] cxgb3i: cxgb3 iSCSI initiator, Jeff Garzik, (Wed Aug 13, 3:29 pm)
Re: [RFC][PATCH 1/1] cxgb3i: cxgb3 iSCSI initiator, Vladislav Bolkhovitin, (Thu Aug 14, 2:24 pm)
Re: [RFC][PATCH 1/1] cxgb3i: cxgb3 iSCSI initiator, Nicholas A. Bellinger, (Thu Aug 14, 5:59 pm)
Re: [RFC][PATCH 1/1] cxgb3i: cxgb3 iSCSI initiator, David Miller, (Wed Aug 13, 4:13 pm)
Re: [RFC][PATCH 1/1] cxgb3i: cxgb3 iSCSI initiator, Herbert Xu, (Tue Aug 12, 9:57 pm)
Re: [RFC][PATCH 1/1] cxgb3i: cxgb3 iSCSI initiator, David Miller, (Tue Aug 12, 6:01 pm)
Re: [RFC][PATCH 1/1] cxgb3i: cxgb3 iSCSI initiator, Roland Dreier, (Mon Aug 11, 12:07 pm)
Re: [RFC][PATCH 1/1] cxgb3i: cxgb3 iSCSI initiator, David Miller, (Mon Aug 11, 5:08 pm)
Re: [RFC][PATCH 1/1] cxgb3i: cxgb3 iSCSI initiator, Roland Dreier, (Mon Aug 11, 5:39 pm)
Re: [RFC][PATCH 1/1] cxgb3i: cxgb3 iSCSI initiator, David Miller, (Mon Aug 11, 5:52 pm)
Re: [RFC][PATCH 1/1] cxgb3i: cxgb3 iSCSI initiator, David Miller, (Sat Aug 9, 3:28 am)
Re: [RFC][PATCH 1/1] cxgb3i: cxgb3 iSCSI initiator, Roland Dreier, (Sun Aug 10, 1:14 am)
Re: [RFC][PATCH 1/1] cxgb3i: cxgb3 iSCSI initiator, David Miller, (Sun Aug 10, 1:47 am)
Re: [RFC][PATCH 1/1] cxgb3i: cxgb3 iSCSI initiator, Roland Dreier, (Mon Aug 11, 12:09 pm)
Re: [RFC][PATCH 1/1] cxgb3i: cxgb3 iSCSI initiator, David Miller, (Mon Aug 11, 5:09 pm)
Re: [RFC][PATCH 1/1] cxgb3i: cxgb3 iSCSI initiator, Steve Wise, (Mon Aug 11, 7:20 pm)
Re: [RFC][PATCH 1/1] cxgb3i: cxgb3 iSCSI initiator, David Miller, (Mon Aug 11, 8:22 pm)
Re: [RFC][PATCH 1/1] cxgb3i: cxgb3 iSCSI initiator, Divy Le Ray, (Mon Aug 11, 7:45 pm)
Re: [RFC][PATCH 1/1] cxgb3i: cxgb3 iSCSI initiator, Roland Dreier, (Mon Aug 11, 5:37 pm)
Re: [RFC][PATCH 1/1] cxgb3i: cxgb3 iSCSI initiator, David Miller, (Mon Aug 11, 5:51 pm)
Re: [RFC][PATCH 1/1] cxgb3i: cxgb3 iSCSI initiator, Steve Wise, (Sun Aug 10, 1:57 pm)
Re: [RFC][PATCH 1/1] cxgb3i: cxgb3 iSCSI initiator, Herbert Xu, (Sun Aug 10, 2:34 am)
Re: [RFC][PATCH 1/1] cxgb3i: cxgb3 iSCSI initiator, Steve Wise, (Sat Aug 9, 10:04 am)
Re: [RFC][PATCH 1/1] cxgb3i: cxgb3 iSCSI initiator, Jeff Garzik, (Fri Aug 8, 6:20 pm)
Re: [RFC][PATCH 1/1] cxgb3i: cxgb3 iSCSI initiator, Mike Christie, (Thu Aug 7, 4:07 pm)
Re: [RFC][PATCH 1/1] cxgb3i: cxgb3 iSCSI initiator, Roland Dreier, (Wed Jul 30, 3:21 pm)