Re: [bug, netconsole, SLUB] BUG skbuff_head_cache: Poison overwritten

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Ingo Molnar <mingo@...>
Cc: Pekka Enberg <penberg@...>, <linux-kernel@...>, <netdev@...>, Vegard Nossum <vegard.nossum@...>, Rafael J. Wysocki <rjw@...>, <cl@...>, <davem@...>, Auke Kok <auke-jan.h.kok@...>
Date: Monday, July 21, 2008 - 5:24 pm

On Mon, Jul 21, 2008 at 09:21:38PM +0200, Ingo Molnar (mingo@elte.hu) wrote:

e1000_clean_tx_irq() call looks particulary suspicious: it is called
without adapter->tx_queue_lock in poll controller (netconsole callback)
and with that lock in NAPI handler.

Can you check kind of this patch:

diff --git a/drivers/net/e1000e/netdev.c b/drivers/net/e1000e/netdev.c
index 869544b..5f180d8 100644
--- a/drivers/net/e1000e/netdev.c
+++ b/drivers/net/e1000e/netdev.c
@@ -4067,7 +4067,9 @@ static void e1000_netpoll(struct net_device *netdev)
 	disable_irq(adapter->pdev->irq);
 	e1000_intr(adapter->pdev->irq, netdev);
 
+	spin_lock(&adapter->tx_queue_lock);
 	e1000_clean_tx_irq(adapter);
+	spin_unlock(&adapter->tx_queue_lock);
 
 	enable_irq(adapter->pdev->irq);
 }


-- 
	Evgeniy Polyakov
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re: [bug, netconsole, SLUB] BUG skbuff_head_cache: Poison ov..., Christoph Lameter, (Fri Jul 18, 9:55 am)
Re: [bug, netconsole, SLUB] BUG skbuff_head_cache: Poison ov..., Christoph Lameter, (Mon Jul 21, 12:22 pm)
Re: [bug, netconsole, SLUB] BUG skbuff_head_cache: Poison ov..., Evgeniy Polyakov, (Mon Jul 21, 5:24 pm)
Re: [bug, netconsole, SLUB] BUG skbuff_head_cache: Poison ov..., Christoph Lameter, (Mon Jul 21, 12:19 pm)
Re: [bug, netconsole, SLUB] BUG skbuff_head_cache: Poison ov..., Christoph Lameter, (Fri Jul 18, 9:54 am)
Re: [bug, netconsole, SLUB] BUG skbuff_head_cache: Poison ov..., Evgeniy Polyakov, (Fri Jul 18, 12:07 pm)
Re: [bug, netconsole, SLUB] BUG skbuff_head_cache: Poison ov..., Christoph Lameter, (Fri Jul 18, 10:48 am)