Re: [GIT]: Networking

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: David Miller <davem@...>
Cc: <netdev@...>
Date: Sunday, July 20, 2008 - 1:59 pm

Hi Dave,

I noticed the patch below isn't in this (yet)
did it slip through or does it still need more work?

From: Arjan van de Ven
Subject: Print the module name as part of the watchdog message

As suggested by Dave:

This patch adds a function to get the driver name from a struct net_device,
and consequently uses this in the watchdog timeout handler to print as
part of the message.

Signed-off-by: Arjan van de Ven
---
include/linux/netdevice.h | 2 ++
net/core/dev.c | 20 ++++++++++++++++++++
net/sched/sch_generic.c | 6 +++---
3 files changed, 25 insertions(+), 3 deletions(-)

Index: linux.trees.git/include/linux/netdevice.h
===================================================================
--- linux.trees.git.orig/include/linux/netdevice.h
+++ linux.trees.git/include/linux/netdevice.h
@@ -1516,6 +1516,8 @@ extern void dev_seq_stop(struct seq_file
extern int netdev_class_create_file(struct class_attribute *class_attr);
extern void netdev_class_remove_file(struct class_attribute *class_attr);

+extern char *netdev_drivername(struct net_device *dev, char *buffer, int len);
+
extern void linkwatch_run_queue(void);

extern int netdev_compute_features(unsigned long all, unsigned long one);
Index: linux.trees.git/net/core/dev.c
===================================================================
--- linux.trees.git.orig/net/core/dev.c
+++ linux.trees.git/net/core/dev.c
@@ -4554,6 +4554,26 @@ err_name:
return -ENOMEM;
}

+char *netdev_drivername(struct net_device *dev, char *buffer, int len)
+{
+ struct device_driver *driver;
+ struct device *parent;
+
+ if (len <= 0 || !buffer)
+ return buffer;
+ buffer[0] = 0;
+
+ parent = dev->dev.parent;
+
+ if (!parent)
+ return buffer;
+
+ driver = parent->driver;
+ if (driver && driver->name)
+ strlcpy(buffer, driver->name, len);
+ return buffer;
+}
+
static void __net_exit netdev_exit(struct net *net)
{
kfree(net->dev_name_head);
Index: linux.trees.git/net/sched/sch_generic.c
===================================================================
--- linux.trees.git.orig/net/sched/sch_generic.c
+++ linux.trees.git/net/sched/sch_generic.c
@@ -215,9 +215,9 @@ static void dev_watchdog(unsigned long a
netif_carrier_ok(dev)) {
if (netif_queue_stopped(dev) &&
time_after(jiffies, dev->trans_start + dev->watchdog_timeo)) {
-
- printk(KERN_INFO "NETDEV WATCHDOG: %s: transmit timed out\n",
- dev->name);
+ char drivername[64];
+ printk(KERN_INFO "NETDEV WATCHDOG: %s (%s): transmit timed out\n",
+ dev->name, netdev_drivername(dev, drivername, 64));
dev->tx_timeout(dev);
WARN_ON_ONCE(1);
}
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[GIT]: Networking, David Miller, (Sun Jul 20, 1:44 pm)
Re: [GIT]: Networking, Ingo Molnar, (Mon Jul 21, 9:50 am)
Re: [GIT]: Networking, Stefan Richter, (Mon Jul 21, 10:15 am)
[crash] kernel BUG at net/core/dev.c:1328!, Ingo Molnar, (Mon Jul 21, 2:23 pm)
Re: [crash] kernel BUG at net/core/dev.c:1328!, Linus Torvalds, (Mon Jul 21, 2:35 pm)
Re: [crash] kernel BUG at net/core/dev.c:1328!, David Miller, (Mon Jul 21, 3:00 pm)
Re: [crash] kernel BUG at net/core/dev.c:1328!, Ingo Molnar, (Mon Jul 21, 3:44 pm)
Re: [crash] kernel BUG at net/core/dev.c:1328!, David Miller, (Mon Jul 21, 4:20 pm)
Re: [crash] kernel BUG at net/core/dev.c:1328!, Stefan Richter, (Mon Jul 21, 3:20 pm)
Re: [crash] kernel BUG at net/core/dev.c:1328!, David Miller, (Mon Jul 21, 4:11 pm)
Re: [crash] kernel BUG at net/core/dev.c:1328!, Stefan Richter, (Mon Jul 21, 5:26 pm)
Re: [crash] kernel BUG at net/core/dev.c:1328!, Ingo Molnar, (Mon Jul 21, 2:46 pm)
[TCP bug] stuck distcc connections in latest -git, Ingo Molnar, (Tue Jul 22, 7:21 am)
Re: [TCP bug] stuck distcc connections in latest -git, David Newall, (Tue Jul 22, 9:45 am)
Re: [TCP bug] stuck distcc connections in latest -git, Ingo Molnar, (Tue Jul 22, 9:57 am)
Re: [TCP bug] stuck distcc connections in latest -git, David Newall, (Tue Jul 22, 10:54 am)
Re: [TCP bug] stuck distcc connections in latest -git, Ingo Molnar, (Tue Jul 22, 11:34 am)
Re: [TCP bug] stuck distcc connections in latest -git, Willy Tarreau, (Tue Jul 22, 5:12 pm)
Re: [TCP bug] stuck distcc connections in latest -git, Ingo Molnar, (Wed Jul 23, 4:26 am)
Re: [regression] nf_iterate(), BUG: unable to handle kernel ..., Krzysztof Oledzki, (Thu Jul 24, 2:00 pm)
Re: [crash] kernel BUG at net/core/dev.c:1328!, Ingo Molnar, (Mon Jul 21, 3:30 pm)
iwlwifi: fix build bug in "iwlwifi: fix LED stall", Ingo Molnar, (Mon Jul 21, 4:36 am)
RE: iwlwifi: fix build bug in "iwlwifi: fix LED stall", Winkler, Tomas, (Mon Jul 21, 6:02 am)
Re: iwlwifi: fix build bug in "iwlwifi: fix LED stall", Ingo Molnar, (Mon Jul 21, 6:53 am)
Re: [GIT]: Networking, Linus Torvalds, (Sun Jul 20, 8:54 pm)
Re: [GIT]: Networking, Linus Torvalds, (Sun Jul 20, 9:07 pm)
Re: [GIT]: Networking, David Miller, (Sun Jul 20, 9:17 pm)
Re: [GIT]: Networking, David Miller, (Sun Jul 20, 9:03 pm)
Re: [GIT]: Networking, Patrick McHardy, (Sun Jul 20, 9:20 pm)
Re: [GIT]: Networking, James Morris, (Mon Jul 21, 7:45 am)
Re: [GIT]: Networking, Patrick McHardy, (Mon Jul 21, 8:05 am)
Re: [GIT]: Networking, David Miller, (Mon Jul 21, 1:28 pm)
Re: [GIT]: Networking, Linus Torvalds, (Mon Jul 21, 1:40 pm)
Re: [GIT]: Networking, Patrick McHardy, (Mon Jul 21, 4:33 pm)
Re: [GIT]: Networking, David Miller, (Wed Jul 23, 7:42 pm)
Re: [GIT]: Networking, Stefan Richter, (Mon Jul 21, 7:28 am)
Re: [GIT]: Networking, Alexey Dobriyan, (Sun Jul 20, 9:09 pm)
Re: [GIT]: Networking, David Miller, (Sun Jul 20, 9:14 pm)
Re: [GIT]: Networking, Alexey Dobriyan, (Sun Jul 20, 10:40 pm)
Re: [GIT]: Networking, David Miller, (Sun Jul 20, 10:48 pm)
Re: [GIT]: Networking, David Miller, (Mon Jul 21, 1:11 am)
Re: [GIT]: Networking, Linus Torvalds, (Mon Jul 21, 12:49 pm)
Re: [GIT]: Networking, David Miller, (Mon Jul 21, 12:53 pm)
Re: [GIT]: Networking, Alexey Dobriyan, (Mon Jul 21, 7:57 am)
Re: [GIT]: Networking, David Miller, (Mon Jul 21, 11:27 am)
Re: [GIT]: Networking, Alexander Beregalov, (Mon Jul 21, 5:48 am)
Re: [GIT]: Networking, Ben Hutchings, (Mon Jul 21, 6:16 am)
Re: [GIT]: Networking, David Miller, (Mon Jul 21, 11:35 am)
Re: [GIT]: Networking, Alexander Beregalov, (Mon Jul 21, 12:04 pm)
Re: [GIT]: Networking, Alexey Dobriyan, (Sun Jul 20, 9:22 pm)
Re: [GIT]: Networking, Arjan van de Ven, (Sun Jul 20, 1:59 pm)
Re: [GIT]: Networking, David Miller, (Mon Jul 21, 4:32 pm)
Re: [GIT]: Networking, David Miller, (Sun Jul 20, 7:52 pm)