Home » Mailing list archives » linux-netdev » 2008 » July » 18

[PATCH] e1000: resolve tx multiqueue bug

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Ben Hutchings <bhutchings@...>
To: Jeff Garzik <jgarzik@...>
Cc: David Miller <davem@...>, Jeff Kirsher <jeffrey.t.kirsher@...>, <netdev@...>
Subject: [PATCH] e1000: resolve tx multiqueue bug
Date: Friday, July 18, 2008 - 1:05 pm

With the recent changes to tx mutiqueue, e1000 was not calling
netif_start_queue() before calling netif_wake_queue().
This causes an oops during loading of the driver.

(Based on commit d55b53fff0c2ddb639dca04c3f5a0854f292d982.)

Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
diff --git a/drivers/net/e1000/e1000_main.c b/drivers/net/e1000/e1000_main.c
index f8df8bd..cf12b05 100644
--- a/drivers/net/e1000/e1000_main.c
+++ b/drivers/net/e1000/e1000_main.c
@@ -1472,6 +1472,8 @@ e1000_open(struct net_device *netdev)
 
 	e1000_irq_enable(adapter);
 
+	netif_start_queue(netdev);
+
 	/* fire a link status change interrupt to start the watchdog */
 	E1000_WRITE_REG(&adapter->hw, ICS, E1000_ICS_LSC);
 
-- 
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
READ ME, net-2.6 fully merged, David Miller, (Fri Jul 18, 6:39 am)
Re: READ ME, net-2.6 fully merged, Jarek Poplawski, (Sat Jul 19, 3:50 am)
Re: READ ME, net-2.6 fully merged, David Miller, (Sat Jul 19, 4:01 am)
Re: READ ME, net-2.6 fully merged, Ben Hutchings, (Fri Jul 18, 12:51 pm)
Re: READ ME, net-2.6 fully merged, David Miller, (Fri Jul 18, 5:16 pm)
Re: READ ME, net-2.6 fully merged, Jeff Kirsher, (Fri Jul 18, 6:43 pm)
[PATCH] e1000: resolve tx multiqueue bug, Ben Hutchings, (Fri Jul 18, 1:05 pm)
Re: [PATCH] e1000: resolve tx multiqueue bug, Jeff Kirsher, (Fri Jul 18, 8:04 pm)
Re: [PATCH] e1000: resolve tx multiqueue bug, David Miller, (Fri Jul 18, 8:51 pm)