From: Patrick McHardy <kaber@trash.net> Date: Thu, 17 Jul 2008 16:02:20 +0200I think from certain perspectives it frankly doesn't matter. It's not like the skb->priority field lets the SKB bypass the packets already in the TX ring of the chip with a lower priority. It is true that, once the TX ring is full, the skb->priority thus begins to have an influence on which packets are moved from the qdisc to the TX ring of the device. However, I wonder if we're so sure that we want to give normal users that kind of powers. Let's say for example that you set the highest priority possible in the TOS socket option, and you do this for a ton of UDP sockets, and you just blast packets out as fast as possible. This backlogs the device TX ring, and if done effectively enough could keep other sockets blocked out of the device completely. Are we really really sure it's OK to let users do this? :) To me, as a default, I think TOS and DSCP really means just on-wire priority. If we absolutely want to, we can keep the old pfifo_fast around and use it (shared on multiq) if a certain sysctl knob is set. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
| Linus Torvalds | Re: Dual-Licensing Linux Kernel with GPL V2 and GPL V3 |
| Rafael J. Wysocki | [Bug #10391] 2.6.25-rc7/8: Another resume regression |
| Arjan van de Ven | [Patch v2] Make PCI extended config space (MMCONFIG) a driver opt-in |
| Jeremy Fitzhardinge | Re: [RFC] Heads up on sys_fallocate() |
git: | |
| Martin Langhoff | Re: pack operation is thrashing my server |
| Arjen Laarhoven | [PATCH 1/2] t/t4202-log.sh: Add testcases |
| Li Frank-B20596 | why not TortoiseGit |
| sean | Re: Implementing branch attributes in git config |
| Diana Eichert | bcw(4) is gone |
| Nick Guenther | Re: Real men don't attack straw men |
| Khalid Schofield | Port ZFS to OpenBSD |
| Christopher Intemann | OpenBSD on Sun Netra X1 |
| Gerrit Renker | [PATCH 15/37] dccp: Set per-connection CCIDs via socket options |
| David Miller | Re: [PATCH] pkt_sched: Destroy gen estimators under rtnl_lock(). |
| Mark Smith | Is it valid to add a macvlan virtual interface to a bridge? If so, there seems to ... |
| Joakim Tjernlund | raw PF_PACKET protocol selection |
