[PATCH 10/16] ipvs: clean the init_ipv4_mibs error paths

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: David Miller <davem@...>
Cc: Linux Netdev List <netdev@...>
Date: Thursday, July 17, 2008 - 9:33 am

After moving all the stuff outside this function it looks
a bit ugly - make it look better.

Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
---
 net/ipv4/af_inet.c |    8 +-------
 1 files changed, 1 insertions(+), 7 deletions(-)

diff --git a/net/ipv4/af_inet.c b/net/ipv4/af_inet.c
index 36ff6dc..dd919d8 100644
--- a/net/ipv4/af_inet.c
+++ b/net/ipv4/af_inet.c
@@ -1399,13 +1399,7 @@ static __net_initdata struct pernet_operations ipv4_mib_ops = {
 
 static int __init init_ipv4_mibs(void)
 {
-	if (register_pernet_subsys(&ipv4_mib_ops))
-		goto err_net;
-
-	return 0;
-
-err_net:
-	return -ENOMEM;
+	return register_pernet_subsys(&ipv4_mib_ops);
 }
 
 static int ipv4_proc_init(void);
-- 
1.5.5.1

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 0/16] mib: finish with ipv4 mibs netnsization, Pavel Emelyanov, (Thu Jul 17, 9:19 am)
Re: [PATCH 0/16] mib: finish with ipv4 mibs netnsization, Pavel Emelyanov, (Mon Jul 21, 1:38 pm)
Re: [PATCH 0/16] mib: finish with ipv4 mibs netnsization, Eric W. Biederman, (Mon Jul 21, 8:24 pm)
[PATCH 15/16] proc: consolidate per-net single_open callers, Pavel Emelyanov, (Thu Jul 17, 9:41 am)
[PATCH 12/16] proc: create /proc/net/snmp file in each net, Pavel Emelyanov, (Thu Jul 17, 9:36 am)
[PATCH 10/16] ipvs: clean the init_ipv4_mibs error paths, Pavel Emelyanov, (Thu Jul 17, 9:33 am)
[PATCH 9/16] mib: put icmpmsg statistics on struct net, Pavel Emelyanov, (Thu Jul 17, 9:32 am)
[PATCH 8/16] mib: put icmp statistics on struct net, Pavel Emelyanov, (Thu Jul 17, 9:31 am)
[PATCH 7/16] mib: put udplite statistics on struct net, Pavel Emelyanov, (Thu Jul 17, 9:30 am)
[PATCH 6/16] mib: put udp statistics on struct net, Pavel Emelyanov, (Thu Jul 17, 9:29 am)
[PATCH 5/16] mib: put net statistics on struct net, Pavel Emelyanov, (Thu Jul 17, 9:28 am)
[PATCH 4/16] mib: put ip statistics on struct net, Pavel Emelyanov, (Thu Jul 17, 9:26 am)
[PATCH 3/16] mib: put tcp statistics on struct net, Pavel Emelyanov, (Thu Jul 17, 9:25 am)
[PATCH 2/16] ipv4: add pernet mib operations, Pavel Emelyanov, (Thu Jul 17, 9:23 am)
[PATCH 1/16] mib: add netns/mib.h file, Pavel Emelyanov, (Thu Jul 17, 9:21 am)