Home » Mailing list archives » linux-netdev » 2008 » July » 17

[PATCH 19/31]: pkt_sched: dev_init_scheduler() does not need to lock qdisc tree.

Previous thread: [PATCH 15/31]: pkt_sched: Move gso_skb into Qdisc. by David Miller on Thursday, July 17, 2008 - 8:16 am. (1 message)

Next thread: [PATCH 18/31]: pkt_sched: Schedule qdiscs instead of netdev_queue. by David Miller on Thursday, July 17, 2008 - 8:17 am. (1 message)
[view original message]
From: David Miller <davem@...>
To: <netdev@...>
Cc: <kaber@...>, <johannes@...>, <linux-wireless@...>
Subject: [PATCH 19/31]: pkt_sched: dev_init_scheduler() does not need to lock qdisc tree.
Date: Thursday, July 17, 2008 - 8:17 am

We are registering the device, there is no way anyone can get

at this object's qdiscs yet in any meaningful way.


Signed-off-by: David S. Miller <davem@davemloft.net>

---

 net/sched/sch_generic.c |    2 --

 1 files changed, 0 insertions(+), 2 deletions(-)


diff --git a/net/sched/sch_generic.c b/net/sched/sch_generic.c

index dd5c4e7..7e078c5 100644

--- a/net/sched/sch_generic.c

+++ b/net/sched/sch_generic.c

@@ -741,10 +741,8 @@ static void dev_init_scheduler_queue(struct net_device *dev,


 void dev_init_scheduler(struct net_device *dev)

 {

-	qdisc_lock_tree(dev);

 	netdev_for_each_tx_queue(dev, dev_init_scheduler_queue, &noop_qdisc);

 	dev_init_scheduler_queue(dev, &dev->rx_queue, NULL);

-	qdisc_unlock_tree(dev);


 	setup_timer(&dev->watchdog_timer, dev_watchdog, (unsigned long)dev);

 }

--

1.5.6.2.255.gbed62


--
Previous thread: [PATCH 15/31]: pkt_sched: Move gso_skb into Qdisc. by David Miller on Thursday, July 17, 2008 - 8:16 am. (1 message)

Next thread: [PATCH 18/31]: pkt_sched: Schedule qdiscs instead of netdev_queue. by David Miller on Thursday, July 17, 2008 - 8:17 am. (1 message)