Re: [PATCH net-next] atl1e: Atheros L1E Gigabit Ethernet driver

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Stephen Hemminger <shemminger@...>
Cc: Jie Yang <Jie.Yang@...>, jeff@garzik.org <jeff@...>, David Miller <davem@...>, jcliburn@gmail.com <jcliburn@...>, parag.warudkar@gmail.com <parag.warudkar@...>, Willy Tarreau <w@...>, oliver.schuster@schweigstill.de <oliver.schuster@...>, netdev@vger.kernel.org <netdev@...>, linux-kernel@vger.kernel.org <linux-kernel@...>
Date: Wednesday, July 16, 2008 - 12:36 pm

> Output of checkpatch (scripts/checkpatch.pl in kernel source).
 > Personally, I am not a whitespace bigot, and don't think
 > all the warnings in checkpatch have to be fixed.
 > 
 > ----------
 > ERROR: patch seems to be corrupt (line wrapped?)
 > #121: FILE: drivers/net/atl1e/atl1e.h:9:
 > ree
 > 
 > WARNING: space prohibited between function name and open parenthesis '('
 > #212: FILE: drivers/net/atl1e/atl1e.h:97:
 > +       _tpd =3D (((_vlan) << (4)) | (((_vlan) >> 13) & 7) |\

It's kind of pointless to run checkpatch on a corrupted patch (the email
was quoted-printable and you didn't decode it back to text).  Of course
it's also better to send non-mangled patches.

 - R.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re: [PATCH net-next] atl1e: Atheros L1E Gigabit Ethernet dri..., Roland Dreier, (Wed Jul 16, 12:36 pm)
Re: [PATCH net-next] atl1e: Atheros L1E Gigabit Ethernet dri..., Stephen Hemminger, (Wed Jul 16, 11:34 pm)