Re: [PATCH RFC 02/10] mlx4_en: Device initialization

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Roland Dreier
Date: Tuesday, July 15, 2008 - 12:21 pm

> +	/* Create a netdev for each port */
 > +	mlx4_foreach_port(i, mdev->ports_map) {
 > +		mlx4_info(mdev, "Activating port:%d\n", i);
 > +		if (mlx4_en_init_netdev(mdev, i, &mdev->profile.prof[i])) {
 > +			mdev->pndev[i] = NULL;
 > +			goto err_free_netdev;
 > +		}
 > +	}
 > +	return mdev;
 > +
 > +
 > +err_free_netdev:
 > +	for (i = 0; i < dev->caps.num_ports; i++) {
 > +		if (mdev->pndev[i])
 > +			mlx4_en_destroy_netdev(mdev->pndev[i]);
 > +	}

There's a strange asymmetry between the mlx4_foreach_port() loop and the
for () loop here.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH RFC 02/10] mlx4_en: Device initialization, Yevgeny Petrilin, (Mon Jul 14, 7:40 am)
[PATCH RFC 03/10] mlx4_en: net_device implementation, Yevgeny Petrilin, (Mon Jul 14, 7:41 am)
Re: [PATCH RFC 02/10] mlx4_en: Device initialization, Ben Hutchings, (Mon Jul 14, 9:48 am)
Re: [PATCH RFC 03/10] mlx4_en: net_device implementation, Ben Hutchings, (Mon Jul 14, 12:42 pm)
Re: [PATCH RFC 03/10] mlx4_en: net_device implementation, Yevgeny Petrilin, (Tue Jul 15, 8:01 am)
Re: [PATCH RFC 02/10] mlx4_en: Device initialization, Roland Dreier, (Tue Jul 15, 12:21 pm)