Re: [PATCH 22/39] mv643xx_eth: move rx_return_buff() into its only caller | KernelTrap

Re: [PATCH 22/39] mv643xx_eth: move rx_return_buff() into its only caller

view
thread

!MAILaRCHIVE_VOTE_RePLACE

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

[view in full thread]

From: Dale Farnsworth <dale@...>

To: Lennert Buytenhek <buytenh@...>

Cc: <netdev@...>

Subject: Re: [PATCH 22/39] mv643xx_eth: move rx_return_buff() into its only caller

Date: Thursday, June 5, 2008 - 8:01 am

On Tue, Jun 03, 2008 at 01:02:37PM +0200, Lennert Buytenhek wrote:
quoted text> rx_return_buff() is also a remnant of the HAL layering that the
> original mv643xx_eth driver used.  Moving it into its caller kills
> the last reference to FUNC_RET_STATUS/pkt_info.
> 
> Signed-off-by: Lennert Buytenhek <buytenh@marvell.com>
> ---
>  drivers/net/mv643xx_eth.c |   80 ++++++++++++++++-----------------------------
>  1 files changed, 28 insertions(+), 52 deletions(-)

Acked-by: Dale Farnsworth <dale@farnsworth.org>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

[PATCH 00/39] mv643xx_eth: complete overhaul, Lennert Buytenhek, (Tue Jun 3, 7:02 am)

[PATCH 29/39] mv643xx_eth: general cleanup, Lennert Buytenhek, (Tue Jun 3, 7:02 am)

Re: [PATCH 29/39] mv643xx_eth: general cleanup, Dale Farnsworth, (Thu Jun 5, 8:33 am)

Re: [PATCH 29/39] mv643xx_eth: general cleanup, Lennert Buytenhek, (Fri Jun 6, 4:24 am)

Re: [PATCH 29/39] mv643xx_eth: general cleanup, Dale Farnsworth, (Fri Jun 6, 6:59 am)

[PATCH 19/39] mv643xx_eth: kill ->rx_resource_err, Lennert Buytenhek, (Tue Jun 3, 7:02 am)

Re: [PATCH 19/39] mv643xx_eth: kill ->rx_resource_err, Dale Farnsworth, (Thu Jun 5, 7:48 am)

[PATCH 10/39] mv643xx_eth: clarify irq masking and unmasking, Lennert Buytenhek, (Tue Jun 3, 7:02 am)

Re: [PATCH 10/39] mv643xx_eth: clarify irq masking and unmas..., Dale Farnsworth, (Thu Jun 5, 7:44 am)

Re: [PATCH 10/39] mv643xx_eth: clarify irq masking and unmas..., Lennert Buytenhek, (Thu Jun 5, 4:36 pm)

Re: [PATCH 10/39] mv643xx_eth: clarify irq masking and unmas..., Dale Farnsworth, (Thu Jun 5, 5:22 pm)

Re: [PATCH 10/39] mv643xx_eth: clarify irq masking and unmas..., Dale Farnsworth, (Thu Jun 5, 7:35 am)

[PATCH 17/39] mv643xx_eth: use 'mv643xx_eth_' prefix consist..., Lennert Buytenhek, (Tue Jun 3, 7:02 am)

Re: [PATCH 17/39] mv643xx_eth: use 'mv643xx_eth_' prefix con..., Dale Farnsworth, (Thu Jun 5, 7:59 am)

Re: [PATCH 17/39] mv643xx_eth: use 'mv643xx_eth_' prefix con..., Lennert Buytenhek, (Fri Jun 6, 3:09 am)

[PATCH 02/39] mv643xx_eth: trim unnecessary includes, Lennert Buytenhek, (Tue Jun 3, 7:02 am)

Re: [PATCH 02/39] mv643xx_eth: trim unnecessary includes, Dale Farnsworth, (Thu Jun 5, 7:02 am)

Re: [PATCH 02/39] mv643xx_eth: trim unnecessary includes, Lennert Buytenhek, (Fri Jun 6, 4:18 am)

Re: [PATCH 02/39] mv643xx_eth: trim unnecessary includes, Dale Farnsworth, (Fri Jun 6, 6:55 am)

[PATCH 01/39] mv643xx_eth: reverse topological sort of funct..., Lennert Buytenhek, (Tue Jun 3, 7:02 am)

Re: [PATCH 01/39] mv643xx_eth: reverse topological sort of f..., Dale Farnsworth, (Thu Jun 5, 7:23 am)

[PATCH 03/39] mv643xx_eth: shorten reg names, Lennert Buytenhek, (Tue Jun 3, 7:02 am)

[PATCH 18/39] mv643xx_eth: kill superfluous comments, Lennert Buytenhek, (Tue Jun 3, 7:02 am)

Re: [PATCH 18/39] mv643xx_eth: kill superfluous comments, Dale Farnsworth, (Thu Jun 5, 8:03 am)

Re: [PATCH 03/39] mv643xx_eth: shorten reg names, Dale Farnsworth, (Thu Jun 5, 7:21 am)

[PATCH 13/39] mv643xx_eth: move MIB offset defines into thei..., Lennert Buytenhek, (Tue Jun 3, 7:02 am)

Re: [PATCH 13/39] mv643xx_eth: move MIB offset defines into ..., Dale Farnsworth, (Thu Jun 5, 7:47 am)

[PATCH 12/39] mv643xx_eth: get rid of RX_BUF_OFFSET, Lennert Buytenhek, (Tue Jun 3, 7:02 am)

Re: [PATCH 12/39] mv643xx_eth: get rid of RX_BUF_OFFSET, Dale Farnsworth, (Thu Jun 5, 7:37 am)

[PATCH 11/39] mv643xx_eth: move PHY wait defines into callers, Lennert Buytenhek, (Tue Jun 3, 7:02 am)

Re: [PATCH 11/39] mv643xx_eth: move PHY wait defines into ca..., Dale Farnsworth, (Thu Jun 5, 7:39 am)

[PATCH 09/39] mv643xx_eth: remove unused DESC_SIZE define, Lennert Buytenhek, (Tue Jun 3, 7:02 am)

Re: [PATCH 09/39] mv643xx_eth: remove unused DESC_SIZE define, Dale Farnsworth, (Thu Jun 5, 7:28 am)

[PATCH 04/39] mv643xx_eth: get rid of individual port config..., Lennert Buytenhek, (Tue Jun 3, 7:02 am)

Re: [PATCH 04/39] mv643xx_eth: get rid of individual port co..., Dale Farnsworth, (Thu Jun 5, 7:07 am)

Re: [PATCH 04/39] mv643xx_eth: get rid of individual port co..., Lennert Buytenhek, (Fri Jun 6, 2:58 am)

Re: [PATCH 04/39] mv643xx_eth: get rid of individual port co..., Dale Farnsworth, (Fri Jun 6, 6:52 am)

[PATCH 39/39] mv643xx_eth: update driver version and author ..., Lennert Buytenhek, (Tue Jun 3, 7:02 am)

Re: [PATCH 39/39] mv643xx_eth: update driver version and aut..., Dale Farnsworth, (Thu Jun 5, 8:48 am)

[PATCH 27/39] mv643xx_eth: split out tx queue state, Lennert Buytenhek, (Tue Jun 3, 7:02 am)

[PATCH 26/39] mv643xx_eth: split out rx queue state, Lennert Buytenhek, (Tue Jun 3, 7:02 am)

Re: [PATCH 26/39] mv643xx_eth: split out rx queue state, Dale Farnsworth, (Thu Jun 5, 8:39 am)

Re: [PATCH 27/39] mv643xx_eth: split out tx queue state, Dale Farnsworth, (Thu Jun 5, 8:09 am)

[PATCH 32/39] mv643xx_eth: allow multiple TX queues, Lennert Buytenhek, (Tue Jun 3, 7:02 am)

[PATCH 20/39] mv643xx_eth: get rid of hungarian variable nam..., Lennert Buytenhek, (Tue Jun 3, 7:02 am)

Re: [PATCH 32/39] mv643xx_eth: allow multiple TX queues, Dale Farnsworth, (Thu Jun 5, 8:41 am)

Re: [PATCH 20/39] mv643xx_eth: get rid of hungarian variable..., Dale Farnsworth, (Thu Jun 5, 8:06 am)

[PATCH 31/39] mv643xx_eth: allow multiple RX queues, Lennert Buytenhek, (Tue Jun 3, 7:02 am)

Re: [PATCH 31/39] mv643xx_eth: allow multiple RX queues, Dale Farnsworth, (Thu Jun 5, 8:35 am)

[PATCH 28/39] mv643xx_eth: remove write-only interrupt coale..., Lennert Buytenhek, (Tue Jun 3, 7:02 am)

Re: [PATCH 28/39] mv643xx_eth: remove write-only interrupt c..., Dale Farnsworth, (Thu Jun 5, 8:53 am)

[PATCH 22/39] mv643xx_eth: move rx_return_buff() into its on..., Lennert Buytenhek, (Tue Jun 3, 7:02 am)

Re: [PATCH 22/39] mv643xx_eth: move rx_return_buff() into it..., Dale Farnsworth, (Thu Jun 5, 8:01 am)

[PATCH 34/39] mv643xx_eth: detect extended rx coal register ..., Lennert Buytenhek, (Tue Jun 3, 7:02 am)

Re: [PATCH 34/39] mv643xx_eth: detect extended rx coal regis..., Dale Farnsworth, (Thu Jun 5, 8:50 am)

[PATCH 33/39] mv643xx_eth: work around TX hang hardware issue, Lennert Buytenhek, (Tue Jun 3, 7:02 am)

Re: [PATCH 33/39] mv643xx_eth: work around TX hang hardware ..., Dale Farnsworth, (Thu Jun 5, 8:37 am)

[PATCH 35/39] mv643xx_eth: detect alternate TX BW control re..., Lennert Buytenhek, (Tue Jun 3, 7:02 am)

Re: [PATCH 35/39] mv643xx_eth: detect alternate TX BW contro..., Dale Farnsworth, (Thu Jun 5, 8:40 am)

[PATCH 21/39] mv643xx_eth: move port_receive() into its only..., Lennert Buytenhek, (Tue Jun 3, 7:02 am)

Re: [PATCH 21/39] mv643xx_eth: move port_receive() into its ..., Dale Farnsworth, (Thu Jun 5, 7:53 am)

[PATCH 24/39] mv643xx_eth: kill private unused instance of s..., Lennert Buytenhek, (Tue Jun 3, 7:02 am)

Re: [PATCH 24/39] mv643xx_eth: kill private unused instance ..., Dale Farnsworth, (Thu Jun 5, 8:08 am)

[PATCH 16/39] mv643xx_eth: get rid of ETH_/ethernet_/eth_ pr..., Lennert Buytenhek, (Tue Jun 3, 7:02 am)

Re: [PATCH 16/39] mv643xx_eth: get rid of ETH_/ethernet_/eth..., Dale Farnsworth, (Thu Jun 5, 7:50 am)

[PATCH 23/39] mv643xx_eth: kill FUNC_RET_STATUS/pkt_info, Lennert Buytenhek, (Tue Jun 3, 7:02 am)

Re: [PATCH 23/39] mv643xx_eth: kill FUNC_RET_STATUS/pkt_info, Dale Farnsworth, (Thu Jun 5, 7:59 am)

[PATCH 30/39] mv643xx_eth: add tx rate control, Lennert Buytenhek, (Tue Jun 3, 7:02 am)

Re: [PATCH 30/39] mv643xx_eth: add tx rate control, Dale Farnsworth, (Thu Jun 5, 8:51 am)

[PATCH 25/39] mv643xx_eth: massively simplify multicast addr..., Lennert Buytenhek, (Tue Jun 3, 7:02 am)

Re: [PATCH 25/39] mv643xx_eth: massively simplify multicast ..., Brent Cook, (Thu Jun 5, 10:08 am)

Re: [PATCH 25/39] mv643xx_eth: massively simplify multicast ..., Lennert Buytenhek, (Thu Jun 5, 4:44 pm)

Re: [PATCH 25/39] mv643xx_eth: massively simplify multicast ..., Dale Farnsworth, (Thu Jun 5, 8:05 am)

[PATCH 36/39] mv643xx_eth: be more agressive about RX refill, Lennert Buytenhek, (Tue Jun 3, 7:02 am)

Re: [PATCH 36/39] mv643xx_eth: be more agressive about RX re..., Dale Farnsworth, (Thu Jun 5, 8:48 am)

[PATCH 37/39] mv643xx_eth: don't read from upper parts of 64..., Lennert Buytenhek, (Tue Jun 3, 7:02 am)

Re: [PATCH 37/39] mv643xx_eth: don't read from upper parts o..., Dale Farnsworth, (Thu Jun 5, 8:46 am)

Re: [PATCH 37/39] mv643xx_eth: don't read from upper parts o..., Lennert Buytenhek, (Fri Jun 6, 3:45 am)

[PATCH 15/39] mv643xx_eth: clean up rx/tx descriptor field d..., Lennert Buytenhek, (Tue Jun 3, 7:02 am)

Re: [PATCH 15/39] mv643xx_eth: clean up rx/tx descriptor fie..., Dale Farnsworth, (Thu Jun 5, 7:37 am)

[PATCH 06/39] mv643xx_eth: delete unused SDMA config registe..., Lennert Buytenhek, (Tue Jun 3, 7:02 am)

Re: [PATCH 06/39] mv643xx_eth: delete unused SDMA config reg..., Dale Farnsworth, (Thu Jun 5, 7:25 am)

[PATCH 14/39] mv643xx_eth: remove port serial status registe..., Lennert Buytenhek, (Tue Jun 3, 7:02 am)

Re: [PATCH 14/39] mv643xx_eth: remove port serial status reg..., Dale Farnsworth, (Thu Jun 5, 7:41 am)

[PATCH 38/39] mv643xx_eth: add PHY-less mode, Lennert Buytenhek, (Tue Jun 3, 7:02 am)

Re: [PATCH 38/39] mv643xx_eth: add PHY-less mode, Dale Farnsworth, (Thu Jun 5, 8:49 am)

[PATCH 07/39] mv643xx_eth: delete unused port serial control..., Lennert Buytenhek, (Tue Jun 3, 7:02 am)

Re: [PATCH 07/39] mv643xx_eth: delete unused port serial con..., Dale Farnsworth, (Thu Jun 5, 7:27 am)

[PATCH 05/39] mv643xx_eth: get rid of individual port config..., Lennert Buytenhek, (Tue Jun 3, 7:02 am)

Re: [PATCH 05/39] mv643xx_eth: get rid of individual port co..., Dale Farnsworth, (Thu Jun 5, 7:24 am)

[PATCH 08/39] mv643xx_eth: nuke port status register bit def..., Lennert Buytenhek, (Tue Jun 3, 7:02 am)

Re: [PATCH 08/39] mv643xx_eth: nuke port status register bit..., Dale Farnsworth, (Thu Jun 5, 7:26 am)

Navigation

Popular discussions


linux-kernel:
Andrew Morton	Re: -mm merge plans for 2.6.23 -- sys_fallocate
david	Re: Dual-Licensing Linux Kernel with GPL V2 and GPL V3
Linus Torvalds	Linux 2.6.27-rc5
David Miller	Re: [PATCH] net: Fix the prototype of call_netdevice_notifiers
git:

linux-netdev:

Gerrit Renker	[PATCH 27/37] dccp: Integration of dynamic feature activation - part 2 (server side)
David Miller	Re: [GIT]: Networking
Jarek Poplawski	[PATCH] pkt_sched: Destroy gen estimators under rtnl_lock().
openbsd-misc:

Colocation donated by:

Who's online

There are currently 3 users and 766 guests online.

Online users

Syndicate