Home » Mailing list archives » linux-netdev » 2008 » June » 3

[PATCH 36/39] mv643xx_eth: be more agressive about RX refill

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Lennert Buytenhek
Subject: [PATCH 36/39] mv643xx_eth: be more agressive about RX refill
Date: Tuesday, June 3, 2008 - 4:02 am

During OOM, instead of stopping RX refill when the rx desc ring is
not empty, keep trying to refill the ring as long as it is not full
instead.

Signed-off-by: Lennert Buytenhek <buytenh@marvell.com>
---
 drivers/net/mv643xx_eth.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/mv643xx_eth.c b/drivers/net/mv643xx_eth.c
index a7c5421..0f8e79f 100644
--- a/drivers/net/mv643xx_eth.c
+++ b/drivers/net/mv643xx_eth.c
@@ -475,7 +475,7 @@ static void rxq_refill(struct rx_queue *rxq)
 		skb_reserve(skb, 2);
 	}
 
-	if (rxq->rx_desc_count == 0) {
+	if (rxq->rx_desc_count != rxq->rx_ring_size) {
 		rxq->rx_oom.expires = jiffies + (HZ / 10);
 		add_timer(&rxq->rx_oom);
 	}
-- 
1.5.3.4

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH 00/39] mv643xx_eth: complete overhaul, Lennert Buytenhek, (Tue Jun 3, 4:02 am)
[PATCH 01/39] mv643xx_eth: reverse topological sort of fun ..., Lennert Buytenhek, (Tue Jun 3, 4:02 am)
[PATCH 02/39] mv643xx_eth: trim unnecessary includes, Lennert Buytenhek, (Tue Jun 3, 4:02 am)
[PATCH 03/39] mv643xx_eth: shorten reg names, Lennert Buytenhek, (Tue Jun 3, 4:02 am)
[PATCH 04/39] mv643xx_eth: get rid of individual port conf ..., Lennert Buytenhek, (Tue Jun 3, 4:02 am)
[PATCH 05/39] mv643xx_eth: get rid of individual port conf ..., Lennert Buytenhek, (Tue Jun 3, 4:02 am)
[PATCH 06/39] mv643xx_eth: delete unused SDMA config regis ..., Lennert Buytenhek, (Tue Jun 3, 4:02 am)
[PATCH 07/39] mv643xx_eth: delete unused port serial contr ..., Lennert Buytenhek, (Tue Jun 3, 4:02 am)
[PATCH 08/39] mv643xx_eth: nuke port status register bit d ..., Lennert Buytenhek, (Tue Jun 3, 4:02 am)
[PATCH 09/39] mv643xx_eth: remove unused DESC_SIZE define, Lennert Buytenhek, (Tue Jun 3, 4:02 am)
[PATCH 10/39] mv643xx_eth: clarify irq masking and unmasking, Lennert Buytenhek, (Tue Jun 3, 4:02 am)
[PATCH 11/39] mv643xx_eth: move PHY wait defines into callers, Lennert Buytenhek, (Tue Jun 3, 4:02 am)
[PATCH 12/39] mv643xx_eth: get rid of RX_BUF_OFFSET, Lennert Buytenhek, (Tue Jun 3, 4:02 am)
[PATCH 13/39] mv643xx_eth: move MIB offset defines into th ..., Lennert Buytenhek, (Tue Jun 3, 4:02 am)
[PATCH 14/39] mv643xx_eth: remove port serial status regis ..., Lennert Buytenhek, (Tue Jun 3, 4:02 am)
[PATCH 15/39] mv643xx_eth: clean up rx/tx descriptor field ..., Lennert Buytenhek, (Tue Jun 3, 4:02 am)
[PATCH 16/39] mv643xx_eth: get rid of ETH_/ethernet_/eth_ ..., Lennert Buytenhek, (Tue Jun 3, 4:02 am)
[PATCH 17/39] mv643xx_eth: use 'mv643xx_eth_' prefix consi ..., Lennert Buytenhek, (Tue Jun 3, 4:02 am)
[PATCH 18/39] mv643xx_eth: kill superfluous comments, Lennert Buytenhek, (Tue Jun 3, 4:02 am)
[PATCH 19/39] mv643xx_eth: kill -&gt;rx_resource_err, Lennert Buytenhek, (Tue Jun 3, 4:02 am)
[PATCH 20/39] mv643xx_eth: get rid of hungarian variable n ..., Lennert Buytenhek, (Tue Jun 3, 4:02 am)
[PATCH 21/39] mv643xx_eth: move port_receive() into its on ..., Lennert Buytenhek, (Tue Jun 3, 4:02 am)
[PATCH 22/39] mv643xx_eth: move rx_return_buff() into its ..., Lennert Buytenhek, (Tue Jun 3, 4:02 am)
[PATCH 23/39] mv643xx_eth: kill FUNC_RET_STATUS/pkt_info, Lennert Buytenhek, (Tue Jun 3, 4:02 am)
[PATCH 24/39] mv643xx_eth: kill private unused instance of ..., Lennert Buytenhek, (Tue Jun 3, 4:02 am)
[PATCH 25/39] mv643xx_eth: massively simplify multicast ad ..., Lennert Buytenhek, (Tue Jun 3, 4:02 am)
[PATCH 26/39] mv643xx_eth: split out rx queue state, Lennert Buytenhek, (Tue Jun 3, 4:02 am)
[PATCH 27/39] mv643xx_eth: split out tx queue state, Lennert Buytenhek, (Tue Jun 3, 4:02 am)
[PATCH 28/39] mv643xx_eth: remove write-only interrupt coa ..., Lennert Buytenhek, (Tue Jun 3, 4:02 am)
[PATCH 29/39] mv643xx_eth: general cleanup, Lennert Buytenhek, (Tue Jun 3, 4:02 am)
[PATCH 30/39] mv643xx_eth: add tx rate control, Lennert Buytenhek, (Tue Jun 3, 4:02 am)
[PATCH 31/39] mv643xx_eth: allow multiple RX queues, Lennert Buytenhek, (Tue Jun 3, 4:02 am)
[PATCH 32/39] mv643xx_eth: allow multiple TX queues, Lennert Buytenhek, (Tue Jun 3, 4:02 am)
[PATCH 33/39] mv643xx_eth: work around TX hang hardware issue, Lennert Buytenhek, (Tue Jun 3, 4:02 am)
[PATCH 34/39] mv643xx_eth: detect extended rx coal registe ..., Lennert Buytenhek, (Tue Jun 3, 4:02 am)
[PATCH 35/39] mv643xx_eth: detect alternate TX BW control ..., Lennert Buytenhek, (Tue Jun 3, 4:02 am)
[PATCH 36/39] mv643xx_eth: be more agressive about RX refill, Lennert Buytenhek, (Tue Jun 3, 4:02 am)
[PATCH 37/39] mv643xx_eth: don't read from upper parts of ..., Lennert Buytenhek, (Tue Jun 3, 4:02 am)
[PATCH 38/39] mv643xx_eth: add PHY-less mode, Lennert Buytenhek, (Tue Jun 3, 4:02 am)
[PATCH 39/39] mv643xx_eth: update driver version and autho ..., Lennert Buytenhek, (Tue Jun 3, 4:02 am)
Re: [PATCH 02/39] mv643xx_eth: trim unnecessary includes, Dale Farnsworth, (Thu Jun 5, 4:02 am)
Re: [PATCH 04/39] mv643xx_eth: get rid of individual port ..., Dale Farnsworth, (Thu Jun 5, 4:07 am)
Re: [PATCH 03/39] mv643xx_eth: shorten reg names, Dale Farnsworth, (Thu Jun 5, 4:21 am)
Re: [PATCH 01/39] mv643xx_eth: reverse topological sort of ..., Dale Farnsworth, (Thu Jun 5, 4:23 am)
Re: [PATCH 05/39] mv643xx_eth: get rid of individual port ..., Dale Farnsworth, (Thu Jun 5, 4:24 am)
Re: [PATCH 06/39] mv643xx_eth: delete unused SDMA config r ..., Dale Farnsworth, (Thu Jun 5, 4:25 am)
Re: [PATCH 08/39] mv643xx_eth: nuke port status register b ..., Dale Farnsworth, (Thu Jun 5, 4:26 am)
Re: [PATCH 07/39] mv643xx_eth: delete unused port serial c ..., Dale Farnsworth, (Thu Jun 5, 4:27 am)
Re: [PATCH 09/39] mv643xx_eth: remove unused DESC_SIZE define, Dale Farnsworth, (Thu Jun 5, 4:28 am)
Re: [PATCH 10/39] mv643xx_eth: clarify irq masking and unm ..., Dale Farnsworth, (Thu Jun 5, 4:35 am)
Re: [PATCH 15/39] mv643xx_eth: clean up rx/tx descriptor f ..., Dale Farnsworth, (Thu Jun 5, 4:37 am)
Re: [PATCH 12/39] mv643xx_eth: get rid of RX_BUF_OFFSET, Dale Farnsworth, (Thu Jun 5, 4:37 am)
Re: [PATCH 11/39] mv643xx_eth: move PHY wait defines into ..., Dale Farnsworth, (Thu Jun 5, 4:39 am)
Re: [PATCH 14/39] mv643xx_eth: remove port serial status r ..., Dale Farnsworth, (Thu Jun 5, 4:41 am)
Re: [PATCH 10/39] mv643xx_eth: clarify irq masking and unm ..., Dale Farnsworth, (Thu Jun 5, 4:44 am)
Re: [PATCH 13/39] mv643xx_eth: move MIB offset defines int ..., Dale Farnsworth, (Thu Jun 5, 4:47 am)
Re: [PATCH 19/39] mv643xx_eth: kill -&gt;rx_resource_err, Dale Farnsworth, (Thu Jun 5, 4:48 am)
Re: [PATCH 16/39] mv643xx_eth: get rid of ETH_/ethernet_/e ..., Dale Farnsworth, (Thu Jun 5, 4:50 am)
Re: [PATCH 21/39] mv643xx_eth: move port_receive() into it ..., Dale Farnsworth, (Thu Jun 5, 4:53 am)
Re: [PATCH 17/39] mv643xx_eth: use 'mv643xx_eth_' prefix c ..., Dale Farnsworth, (Thu Jun 5, 4:59 am)
Re: [PATCH 23/39] mv643xx_eth: kill FUNC_RET_STATUS/pkt_info, Dale Farnsworth, (Thu Jun 5, 4:59 am)
Re: [PATCH 22/39] mv643xx_eth: move rx_return_buff() into ..., Dale Farnsworth, (Thu Jun 5, 5:01 am)
Re: [PATCH 18/39] mv643xx_eth: kill superfluous comments, Dale Farnsworth, (Thu Jun 5, 5:03 am)
Re: [PATCH 25/39] mv643xx_eth: massively simplify multicas ..., Dale Farnsworth, (Thu Jun 5, 5:05 am)
Re: [PATCH 20/39] mv643xx_eth: get rid of hungarian variab ..., Dale Farnsworth, (Thu Jun 5, 5:06 am)
Re: [PATCH 24/39] mv643xx_eth: kill private unused instanc ..., Dale Farnsworth, (Thu Jun 5, 5:08 am)
Re: [PATCH 27/39] mv643xx_eth: split out tx queue state, Dale Farnsworth, (Thu Jun 5, 5:09 am)
Re: [PATCH 29/39] mv643xx_eth: general cleanup, Dale Farnsworth, (Thu Jun 5, 5:33 am)
Re: [PATCH 31/39] mv643xx_eth: allow multiple RX queues, Dale Farnsworth, (Thu Jun 5, 5:35 am)
Re: [PATCH 33/39] mv643xx_eth: work around TX hang hardwar ..., Dale Farnsworth, (Thu Jun 5, 5:37 am)
Re: [PATCH 26/39] mv643xx_eth: split out rx queue state, Dale Farnsworth, (Thu Jun 5, 5:39 am)
Re: [PATCH 35/39] mv643xx_eth: detect alternate TX BW cont ..., Dale Farnsworth, (Thu Jun 5, 5:40 am)
Re: [PATCH 32/39] mv643xx_eth: allow multiple TX queues, Dale Farnsworth, (Thu Jun 5, 5:41 am)
Re: [PATCH 37/39] mv643xx_eth: don't read from upper parts ..., Dale Farnsworth, (Thu Jun 5, 5:46 am)
Re: [PATCH 36/39] mv643xx_eth: be more agressive about RX ..., Dale Farnsworth, (Thu Jun 5, 5:48 am)
Re: [PATCH 39/39] mv643xx_eth: update driver version and a ..., Dale Farnsworth, (Thu Jun 5, 5:48 am)
Re: [PATCH 38/39] mv643xx_eth: add PHY-less mode, Dale Farnsworth, (Thu Jun 5, 5:49 am)
Re: [PATCH 34/39] mv643xx_eth: detect extended rx coal reg ..., Dale Farnsworth, (Thu Jun 5, 5:50 am)
Re: [PATCH 30/39] mv643xx_eth: add tx rate control, Dale Farnsworth, (Thu Jun 5, 5:51 am)
Re: [PATCH 28/39] mv643xx_eth: remove write-only interrupt ..., Dale Farnsworth, (Thu Jun 5, 5:53 am)
Re: [PATCH 25/39] mv643xx_eth: massively simplify multicas ..., Brent Cook, (Thu Jun 5, 7:08 am)
Re: [PATCH 10/39] mv643xx_eth: clarify irq masking and unm ..., Lennert Buytenhek, (Thu Jun 5, 1:36 pm)
Re: [PATCH 25/39] mv643xx_eth: massively simplify multicas ..., Lennert Buytenhek, (Thu Jun 5, 1:44 pm)
Re: [PATCH 10/39] mv643xx_eth: clarify irq masking and unm ..., Dale Farnsworth, (Thu Jun 5, 2:22 pm)
Re: [PATCH 04/39] mv643xx_eth: get rid of individual port ..., Lennert Buytenhek, (Thu Jun 5, 11:58 pm)
Re: [PATCH 17/39] mv643xx_eth: use 'mv643xx_eth_' prefix c ..., Lennert Buytenhek, (Fri Jun 6, 12:09 am)
Re: [PATCH 37/39] mv643xx_eth: don't read from upper parts ..., Lennert Buytenhek, (Fri Jun 6, 12:45 am)
Re: [PATCH 02/39] mv643xx_eth: trim unnecessary includes, Lennert Buytenhek, (Fri Jun 6, 1:18 am)
Re: [PATCH 29/39] mv643xx_eth: general cleanup, Lennert Buytenhek, (Fri Jun 6, 1:24 am)
Re: [PATCH 04/39] mv643xx_eth: get rid of individual port ..., Dale Farnsworth, (Fri Jun 6, 3:52 am)
Re: [PATCH 02/39] mv643xx_eth: trim unnecessary includes, Dale Farnsworth, (Fri Jun 6, 3:55 am)
Re: [PATCH 29/39] mv643xx_eth: general cleanup, Dale Farnsworth, (Fri Jun 6, 3:59 am)