Re: [PATCH] mac80211: rewrite fragmentation code

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Johannes Berg <johannes@...>
Cc: <linux-wireless@...>, <netdev@...>, Ron Rindjunsky <ron.rindjunsky@...>, Tomas Winkler <tomasw@...>, Ivo van Doorn <ivdoorn@...>, Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@...>
Date: Wednesday, May 7, 2008 - 7:41 am

On Wed, May 07, 2008 at 01:22:19PM +0200, Johannes Berg wrote:

Returning busy should be avoided because not everything expects it.
For example, this can cause tcpdump to see the same packet twice.

Besides, I'm not sure if this will even work if you're fiddling
with skb->next.  Perhaps you can stash it in a pointer local to
your device.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[RFC/RFT 3/4] mac80211: use GSO for fragmentation, Johannes Berg, (Wed Apr 30, 8:40 am)
Re: [RFC/RFT 3/4] mac80211: use GSO for fragmentation, Johannes Berg, (Wed May 7, 4:50 am)
[PATCH] mac80211: rewrite fragmentation code, Johannes Berg, (Wed May 7, 7:22 am)
Re: [PATCH] mac80211: rewrite fragmentation code, Herbert Xu, (Wed May 7, 7:41 am)
Re: [PATCH] mac80211: rewrite fragmentation code, Johannes Berg, (Wed May 7, 7:52 am)
Re: [PATCH] mac80211: rewrite fragmentation code, Herbert Xu, (Wed May 7, 9:05 am)
Re: [PATCH] mac80211: rewrite fragmentation code, Johannes Berg, (Wed May 7, 3:19 pm)
Re: [PATCH] mac80211: rewrite fragmentation code, Michael Buesch, (Wed May 7, 9:48 am)
Re: [PATCH] mac80211: rewrite fragmentation code, Herbert Xu, (Wed May 7, 11:22 pm)
Re: [PATCH] mac80211: rewrite fragmentation code, Michael Buesch, (Thu May 8, 9:00 am)
Re: [PATCH] mac80211: rewrite fragmentation code, Herbert Xu, (Thu May 8, 9:08 am)
Re: [PATCH] mac80211: rewrite fragmentation code, Michael Buesch, (Thu May 8, 9:13 am)
Re: [PATCH] mac80211: rewrite fragmentation code, Herbert Xu, (Thu May 8, 9:32 am)
Re: [PATCH] mac80211: rewrite fragmentation code, Michael Buesch, (Thu May 8, 9:15 am)
Re: [PATCH] mac80211: rewrite fragmentation code, David Miller, (Wed May 7, 11:26 pm)
Re: [PATCH] mac80211: rewrite fragmentation code, Rusty Russell, (Thu May 15, 10:01 pm)
Re: [PATCH] mac80211: rewrite fragmentation code, David Miller, (Fri May 16, 12:58 am)
Re: [PATCH] mac80211: rewrite fragmentation code, Rusty Russell, (Fri May 16, 6:32 am)
Re: [PATCH] mac80211: rewrite fragmentation code, David Miller, (Fri May 16, 3:40 pm)
Re: [PATCH] mac80211: rewrite fragmentation code, Rusty Russell, (Sun May 18, 11:08 pm)
Re: [PATCH] mac80211: rewrite fragmentation code, David Miller, (Mon May 19, 3:03 am)
Re: [PATCH] mac80211: rewrite fragmentation code, Herbert Xu, (Fri May 16, 8:15 am)
Re: [PATCH] mac80211: rewrite fragmentation code, Johannes Berg, (Fri May 16, 6:38 am)
Re: [PATCH] mac80211: rewrite fragmentation code, Herbert Xu, (Thu May 15, 11:28 pm)
Re: [PATCH] mac80211: rewrite fragmentation code, Johannes Berg, (Thu May 8, 5:00 am)