login
Login
/
Register
Search
Forums
News
Blogs
Features
Site
Home
»
Mailing list archives
»
linux-netdev
»
2008
»
May
»
5
Re: [RFC/T] [NET] give truesize warning when truesize differs
view
thread
!MAILaRCHIVE_VOTE_RePLACE
Previous message: [
thread
] [
date
] [
author
]
Next message: [thread] [
date
] [
author
]
[view in full thread]
From:
Johannes Berg <johannes@...>
To: Herbert Xu <herbert@...>
Cc: David S. Miller <davem@...>, netdev <netdev@...>
Subject:
Re: [RFC/T] [NET] give truesize warning when truesize differs
Date: Monday, May 5, 2008 - 11:22 am
On Mon, 2008-05-05 at 23:04 +0800, Herbert Xu wrote:
quoted text
> On Mon, May 05, 2008 at 03:11:20PM +0200, Johannes Berg wrote: > > > > > static inline void skb_truesize_check(struct sk_buff *skb) > > > { > > > - int len =3D sizeof(struct sk_buff) + skb->len; > > > +#ifdef NET_SKBUFF_DATA_USES_OFFSET > > > + int len =3D sizeof(struct sk_buff) + skb->end; > > > +#else > > > + int len =3D sizeof(struct sk_buff) + (skb->end - skb->head); > > > +#endif > >=20 > > Umm, is this even correct? Should it check data_len? I seem to get the > > truesize warning a bit now: >=20 > It must check data_len.
I figured. Just add it? johannes
Previous message: [
thread
] [
date
] [
author
]
Next message: [thread] [
date
] [
author
]
Messages in current thread:
[RFC/T] [NET] give truesize warning when truesize differs
, Johannes Berg
, (Sun May 4, 2:12 pm)
Re: [RFC/T] [NET] give truesize warning when truesize differs
, Johannes Berg
, (Mon May 5, 9:11 am)
Re: [RFC/T] [NET] give truesize warning when truesize differs
, Herbert Xu
, (Mon May 5, 11:04 am)
Re: [RFC/T] [NET] give truesize warning when truesize differs
, Johannes Berg
, (Mon May 5, 11:22 am)
Re: [RFC/T] [NET] give truesize warning when truesize differs
, Johannes Berg
, (Sun May 4, 6:09 pm)
Navigation
Create content
Mailing list archives
Recent posts
Popular discussions
linux-kernel
:
Theodore Tso
Re: -mm merge plans for 2.6.23 -- sys_fallocate
Amit K. Arora
[RFC] Heads up on sys_fallocate()
Tarkan Erimer
Re: Dual-Licensing Linux Kernel with GPL V2 and GPL V3
Greg Kroah-Hartman
[PATCH 011/196] sysfs: Fix a copy-n-paste typo in comment
git
:
linux-netdev
:
Jarek Poplawski
Re: [PATCH] pkt_sched: Destroy gen estimators under rtnl_lock().
David Miller
Re: [GIT]: Networking
Gerrit Renker
[PATCH 27/37] dccp: Integration of dynamic feature activation - part 2 (server side)
Frans Pop
svc: failed to register lockdv1 RPC service (errno 97).
openbsd-misc
:
Colocation donated by:
Who's online
There are currently
2 users
and
973 guests
online.
Online users
shante88996
zeekec
Syndicate