On Mon, 2008-05-05 at 00:20 -0700, David Miller wrote:
quoted text
> From: Johannes Berg <johannes@sipsolutions.net>
> Date: Sun, 04 May 2008 20:32:20 +0200
>=20
> > This makes the networking layer warn when something tries to
> > charge an skb to a socket that already is charged to another
> > socket (or has a destructor from somewhere else.)
> >=20
> > Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
>=20
> I completely agree that this a correct assertion, that
> absolutely should never happen in the current tree.
>=20
> But if we are going to do this, I'm pretty sure we'll
> need to uninline these two routines.
>=20
> I'll leave it up to you, if you think it's still worthwhile
> with the uninlining, please resubmit :-)

Given that it's a corner case and no regular net drivers would ever want
to do something that could possibly cause this condition to be true,
it's probably not worth it either way. Even mac80211 doesn't run into
it, although it might have helped a bit to remember to add skb_orphan()
to the re-injection.

If we decide to uninline those functions for another reason (used too
much, code size, ...) then we can still do that.

johannes