Re: mac80211 truesize bugs

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Johannes Berg <johannes@...>
Cc: David Miller <davem@...>, <mb@...>, <netdev@...>, <linux-wireless@...>
Date: Saturday, May 3, 2008 - 10:02 pm

On Sun, May 04, 2008 at 03:42:34AM +0200, Johannes Berg wrote:

The difference between LL_MAX_HEADER and hard_header_len is that
the former is a system-wide hint of how big the header can be
and the latter is a device-specific value.

In other words, we use the former when we don't know where we
create a packet since we don't know where it'll end up.  As such
we allocate a generous amount of header space so that hopefully
nobody will have to expand the header later.  However, it would
be OK for someone to expand it but obviously it this happened
for the majority of your traffic then you've done something wrong
since expanding it wastes CPU resources by copying the data.

The value of hard_header_len on the other hand is used for two
purposes at least.  First of all it is a hint of how much free
header space there should be in a packet before it goes into a
device (but don't rely on it).  More importantly it's the length
of the hardware header in the packet.  The definition of the
hardware header varies with each type of device.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
mac80211 truesize bugs, Johannes Berg, (Wed Apr 30, 10:02 pm)
frame status API? (was: mac80211 truesize bugs), Johannes Berg, (Sat May 3, 9:55 pm)
Re: mac80211 truesize bugs, Michael Buesch, (Thu May 1, 4:58 am)
Re: mac80211 truesize bugs, Johannes Berg, (Thu May 1, 5:08 am)
Re: mac80211 truesize bugs, Michael Buesch, (Thu May 1, 5:32 am)
Re: mac80211 truesize bugs, Johannes Berg, (Thu May 1, 5:34 am)
Re: mac80211 truesize bugs, David Miller, (Thu May 1, 5:20 am)
Re: mac80211 truesize bugs, Johannes Berg, (Thu May 1, 5:32 am)
Re: mac80211 truesize bugs, David Miller, (Thu May 1, 5:43 am)
Re: mac80211 truesize bugs, Herbert Xu, (Thu May 1, 6:36 am)
Re: mac80211 truesize bugs, David Miller, (Thu May 1, 6:49 am)
Re: mac80211 truesize bugs, Herbert Xu, (Thu May 1, 7:02 am)
Re: mac80211 truesize bugs, David Miller, (Thu May 1, 6:53 am)
Re: mac80211 truesize bugs, Johannes Berg, (Thu May 1, 6:58 am)
Re: mac80211 truesize bugs, Herbert Xu, (Thu May 1, 7:03 am)
Re: mac80211 truesize bugs, Johannes Berg, (Sat May 3, 8:38 am)
Re: mac80211 truesize bugs, Herbert Xu, (Sat May 3, 8:59 am)
Re: mac80211 truesize bugs, Johannes Berg, (Sat May 3, 12:03 pm)
Re: mac80211 truesize bugs, Johannes Berg, (Sat May 3, 6:56 pm)
Re: mac80211 truesize bugs, David Miller, (Sat May 3, 7:07 pm)
Re: mac80211 truesize bugs, Johannes Berg, (Sat May 3, 7:15 pm)
Re: mac80211 truesize bugs, Johannes Berg, (Fri May 2, 4:38 pm)
Re: mac80211 truesize bugs, David Miller, (Fri May 2, 7:33 pm)
Re: mac80211 truesize bugs, Johannes Berg, (Sat May 3, 7:52 am)
Re: mac80211 truesize bugs, David Miller, (Sat May 3, 9:03 pm)
Re: mac80211 truesize bugs, Johannes Berg, (Sat May 3, 9:42 pm)
Re: mac80211 truesize bugs, Johannes Berg, (Sat May 3, 10:09 pm)
Re: mac80211 truesize bugs, Herbert Xu, (Sat May 3, 10:02 pm)
Re: mac80211 truesize bugs, Johannes Berg, (Sat May 3, 10:08 pm)
Re: mac80211 truesize bugs, Herbert Xu, (Sat May 3, 10:12 pm)
Re: mac80211 truesize bugs, Johannes Berg, (Sat May 3, 10:22 pm)
Re: mac80211 truesize bugs, Herbert Xu, (Sat May 3, 11:16 pm)
Re: mac80211 truesize bugs, David Miller, (Sun May 4, 6:38 pm)
Re: mac80211 truesize bugs, Johannes Berg, (Sun May 4, 4:47 am)
Re: mac80211 truesize bugs, Johannes Berg, (Sun May 4, 5:14 am)
Re: mac80211 truesize bugs, Herbert Xu, (Sun May 4, 5:44 am)
Re: mac80211 truesize bugs, Johannes Berg, (Sun May 4, 5:52 am)
Re: mac80211 truesize bugs, Johannes Berg, (Sun May 4, 7:25 am)
Re: mac80211 truesize bugs, Johannes Berg, (Sun May 4, 8:28 am)
Re: mac80211 truesize bugs, Herbert Xu, (Sun May 4, 8:45 am)
Re: mac80211 truesize bugs, Johannes Berg, (Sun May 4, 10:06 am)
Re: mac80211 truesize bugs, David Miller, (Sun May 4, 6:45 pm)
Re: mac80211 truesize bugs, Johannes Berg, (Sun May 4, 6:48 pm)
Re: mac80211 truesize bugs, Johannes Berg, (Sun May 4, 12:03 pm)
Re: mac80211 truesize bugs, Johannes Berg, (Sun May 4, 1:47 pm)
Re: mac80211 truesize bugs, Johannes Berg, (Sun May 4, 8:52 am)
Re: mac80211 truesize bugs, Herbert Xu, (Sun May 4, 8:56 am)
Re: mac80211 truesize bugs, Johannes Berg, (Sun May 4, 9:00 am)
Re: mac80211 truesize bugs, Johannes Berg, (Sun May 4, 8:48 am)
Re: mac80211 truesize bugs, Johannes Berg, (Sat May 3, 5:37 am)
Re: mac80211 truesize bugs, Johannes Berg, (Sat May 3, 10:25 am)
Re: mac80211 truesize bugs, David Miller, (Mon May 12, 11:17 pm)
Re: mac80211 truesize bugs, John W. Linville, (Tue May 13, 4:39 pm)
Re: mac80211 truesize bugs, Johannes Berg, (Tue May 13, 4:59 pm)
Re: mac80211 truesize bugs, Tomas Winkler, (Tue May 13, 5:12 pm)
Re: mac80211 truesize bugs, Johannes Berg, (Tue May 13, 5:37 pm)
Re: mac80211 truesize bugs, David Miller, (Tue May 13, 6:09 pm)
Re: mac80211 truesize bugs, Johannes Berg, (Thu May 1, 8:05 am)
Re: mac80211 truesize bugs, Johannes Berg, (Thu May 1, 7:49 am)
Re: mac80211 truesize bugs, Johannes Berg, (Thu May 1, 7:38 am)
Re: mac80211 truesize bugs, Johannes Berg, (Sat May 3, 7:24 pm)
Re: mac80211 truesize bugs, David Miller, (Sat May 3, 7:32 pm)
Re: mac80211 truesize bugs, Johannes Berg, (Sat May 3, 7:43 pm)
Re: mac80211 truesize bugs, Johannes Berg, (Thu May 1, 5:48 am)
Re: mac80211 truesize bugs, David Miller, (Thu May 1, 5:56 am)
Re: mac80211 truesize bugs, Johannes Berg, (Thu May 1, 6:08 am)
Re: mac80211 truesize bugs, David Miller, (Thu May 1, 6:32 am)
Re: mac80211 truesize bugs, Johannes Berg, (Thu May 1, 6:45 am)