Re: race in skb_splice_bits?

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Octavian Purdila
Date: Tuesday, May 27, 2008 - 4:59 pm

On Tuesday 27 May 2008, Evgeniy Polyakov wrote:

This fixes the crash, thanks.

One doubt though: suppose that while we drop the lock the skb gets aggregated 
with the one after it. If the original skb is fully consumed in the receive 
actor, then the we will eat the new, aggregated skb, loosing data. 

Here is a patch, based on your idea, which tries to cope with the above 
scenario. The !skb check was added for the case in which the actor does not 
consume anything in the current interration. 

tavi
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
race in skb_splice_bits?, Octavian Purdila, (Mon May 26, 5:25 pm)
Re: race in skb_splice_bits?, Ben Hutchings, (Mon May 26, 7:08 pm)
Re: race in skb_splice_bits?, Octavian Purdila, (Tue May 27, 3:41 am)
Re: race in skb_splice_bits?, Evgeniy Polyakov, (Tue May 27, 4:01 am)
Re: race in skb_splice_bits?, Ben Hutchings, (Tue May 27, 4:08 am)
Re: race in skb_splice_bits?, Evgeniy Polyakov, (Tue May 27, 4:52 am)
Re: race in skb_splice_bits?, Evgeniy Polyakov, (Tue May 27, 4:56 am)
Re: race in skb_splice_bits?, Octavian Purdila, (Tue May 27, 5:53 am)
Re: race in skb_splice_bits?, Evgeniy Polyakov, (Tue May 27, 6:21 am)
Re: race in skb_splice_bits?, Evgeniy Polyakov, (Tue May 27, 7:03 am)
Re: race in skb_splice_bits?, Octavian Purdila, (Tue May 27, 7:39 am)
Re: race in skb_splice_bits?, Evgeniy Polyakov, (Tue May 27, 8:09 am)
Re: race in skb_splice_bits?, Evgeniy Polyakov, (Tue May 27, 8:12 am)
Re: race in skb_splice_bits?, Evgeniy Polyakov, (Tue May 27, 8:22 am)
Re: race in skb_splice_bits?, Octavian Purdila, (Tue May 27, 8:33 am)
Re: race in skb_splice_bits?, Evgeniy Polyakov, (Tue May 27, 8:47 am)
Re: race in skb_splice_bits?, Evgeniy Polyakov, (Tue May 27, 10:28 am)
Re: race in skb_splice_bits?, Octavian Purdila, (Tue May 27, 4:59 pm)
Re: race in skb_splice_bits?, Evgeniy Polyakov, (Wed May 28, 1:52 am)
Re: race in skb_splice_bits?, Octavian Purdila, (Wed May 28, 6:20 am)
Re: race in skb_splice_bits?, Evgeniy Polyakov, (Wed May 28, 7:11 am)
Re: race in skb_splice_bits?, Octavian Purdila, (Wed May 28, 8:20 am)
Re: race in skb_splice_bits?, Evgeniy Polyakov, (Wed May 28, 8:42 am)
Re: race in skb_splice_bits?, Octavian Purdila, (Wed May 28, 10:08 am)
Re: race in skb_splice_bits?, Evgeniy Polyakov, (Wed May 28, 10:51 am)
Re: race in skb_splice_bits?, Octavian Purdila, (Wed May 28, 11:02 am)
Re: race in skb_splice_bits?, Jarek Poplawski, (Wed May 28, 1:01 pm)
Re: race in skb_splice_bits?, Octavian Purdila, (Wed May 28, 1:09 pm)
Re: race in skb_splice_bits?, Jarek Poplawski, (Wed May 28, 1:16 pm)