Home » Mailing list archives » linux-netdev » 2008 » May » 26

Re: [ofa-general] Re: [PATCH v2 12/13] QLogic VNIC: Driver Kconfig and Makefile.

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Roland Dreier <rdreier@...>
To: Ramachandra K <ramachandra.kuchimanchi@...>
Cc: <netdev@...>, <poornima.kamath@...>, <general@...>, <amar.mudrankit@...>
Subject: Re: [ofa-general] Re: [PATCH v2 12/13] QLogic VNIC: Driver Kconfig and Makefile.
Date: Monday, May 26, 2008 - 5:47 pm

> The debugging code is always compiled in and is controlled
 > at run time through vnic_debug module parameter.
 > INFINIBAND_QLGC_VNIC_DEBUG config option only controls verbose debugging
 > which adds some extra information in the debug statements (file name,
 > line number)
 > which we typically use for debug builds of the driver.  Even if this option is
 > set to 'n', users can still get all debug messages from the driver by using the
 > vnic_debug module parameter.

OK, I looked at the code.  Is there any point to having
CONFIG_INFINIBAND_QLGC_VNIC_DEBUG at all??  Is anyone going to care
about having __FILE__ and __LINE__ included in the output and want to
set this option to 'n'?

 - R.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH v2 00/13] QLogic VNIC Driver , Ramachandra K, (Mon May 19, 6:31 am)
[PATCH v2 13/13] QLogic VNIC: Modifications to IB Kconfig an..., Ramachandra K, (Mon May 19, 6:38 am)
[PATCH v2 09/13] QLogic VNIC: IB Multicast for Ethernet broa..., Ramachandra K, (Mon May 19, 6:35 am)
[PATCH v2 12/13] QLogic VNIC: Driver Kconfig and Makefile., Ramachandra K, (Mon May 19, 6:37 am)
Re: [PATCH v2 12/13] QLogic VNIC: Driver Kconfig and Makefile., Roland Dreier, (Sun May 25, 6:43 pm)
Re: [ofa-general] Re: [PATCH v2 12/13] QLogic VNIC: Driver K..., Ramachandra K, (Mon May 26, 3:37 am)
Re: [ofa-general] Re: [PATCH v2 12/13] QLogic VNIC: Driver K..., Roland Dreier, (Mon May 26, 5:47 pm)
Re: [ofa-general] Re: [PATCH v2 12/13] QLogic VNIC: Driver K..., Ramachandra K, (Tue May 27, 2:23 am)
Re: [ofa-general] Re: [PATCH v2 12/13] QLogic VNIC: Driver K..., Roland Dreier, (Tue May 27, 2:26 pm)
[PATCH v2 11/13] QLogic VNIC: Driver utility file - implemen..., Ramachandra K, (Mon May 19, 6:37 am)
[PATCH v2 08/13] QLogic VNIC: sysfs interface implementation..., Ramachandra K, (Mon May 19, 6:35 am)
[PATCH v2 10/13] QLogic VNIC: Driver Statistics collection, Ramachandra K, (Mon May 19, 6:36 am)
Re: [PATCH v2 08/13] QLogic VNIC: sysfs interface implementa..., Roland Dreier, (Wed May 28, 1:26 am)
[PATCH v2 07/13] QLogic VNIC: Handling configurable paramete..., Ramachandra K, (Mon May 19, 6:34 am)
[PATCH v2 06/13] QLogic VNIC: IB core stack interaction, Ramachandra K, (Mon May 19, 6:34 am)
[PATCH v2 05/13] QLogic VNIC: Implementation of Data path of..., Ramachandra K, (Mon May 19, 6:33 am)
[PATCH v2 04/13] QLogic VNIC: Implementation of Control path..., Ramachandra K, (Mon May 19, 6:33 am)
[PATCH v2 03/13] QLogic VNIC: Implementation of communicatio..., Ramachandra K, (Mon May 19, 6:32 am)
Re: [PATCH v2 03/13] QLogic VNIC: Implementation of communic..., Roland Dreier, (Wed May 28, 1:28 am)
Re: [ofa-general] Re: [PATCH v2 03/13] QLogic VNIC: Implemen..., Ramachandra K, (Wed May 28, 10:18 am)
[PATCH v2 02/13] QLogic VNIC: Netpath - abstraction of conne..., Ramachandra K, (Mon May 19, 6:32 am)
[PATCH v2 01/13] QLogic VNIC: Driver - netdev implementation, Ramachandra K, (Mon May 19, 6:31 am)