Home » Mailing list archives » linux-netdev » 2008 » May » 23

Re: [PATCH 2/3] cnic: Add CNIC driver.

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Roland Dreier <rdreier@...>
To: Michael Chan <mchan@...>
Cc: <davem@...>, <michaelc@...>, <anilgv@...>, <netdev@...>, <linux-scsi@...>, <open-iscsi@...>
Subject: Re: [PATCH 2/3] cnic: Add CNIC driver.
Date: Friday, May 23, 2008 - 4:14 pm

> +		/* Tell compiler that status_blk fields can change. */
 > +		barrier();
 > +		if (status_idx != sblk->status_idx) {

Is a compiler barrier sufficient here?  It seems an out-of-order CPU
could still mess things up, so an rmb() or smp_rmb() would be required.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH 0/3] bnx2: Add iSCSI support., Michael Chan, (Wed May 21, 9:06 pm)
[PATCH 1/3] bnx2: Add support for CNIC driver., Michael Chan, (Wed May 21, 9:06 pm)
Re: [PATCH 1/3] bnx2: Add support for CNIC driver., Konrad Rzeszutek, (Thu May 22, 11:18 am)
Re: [PATCH 1/3] bnx2: Add support for CNIC driver., Paul E. McKenney, (Thu May 22, 2:45 am)
Re: [PATCH 1/3] bnx2: Add support for CNIC driver., Michael Chan, (Thu May 22, 3:23 pm)
Re: [PATCH 1/3] bnx2: Add support for CNIC driver., Paul E. McKenney, (Thu May 22, 11:45 pm)
Re: [PATCH 1/3] bnx2: Add support for CNIC driver., Michael Chan, (Fri May 23, 12:52 am)
Re: [PATCH 1/3] bnx2: Add support for CNIC driver., Paul E. McKenney, (Fri May 23, 1:32 am)
[PATCH 2/3] cnic: Add CNIC driver., Michael Chan, (Wed May 21, 9:06 pm)
Re: [PATCH 2/3] cnic: Add CNIC driver., Roland Dreier, (Fri May 23, 4:14 pm)
Re: [PATCH 2/3] cnic: Add CNIC driver., Michael Chan, (Fri May 23, 8:42 pm)
Re: [PATCH 2/3] cnic: Add CNIC driver., Roland Dreier, (Fri May 23, 4:09 pm)
Re: [PATCH 2/3] cnic: Add CNIC driver., Paul E. McKenney, (Thu May 22, 3:44 am)
Re: [PATCH 2/3] cnic: Add CNIC driver., Michael Chan, (Thu May 22, 3:46 pm)
Re: [PATCH 2/3] cnic: Add CNIC driver., Paul E. McKenney, (Thu May 22, 11:47 pm)
[PATCH 3/3] bnx2i: Add bnx2i iSCSI driver., Michael Chan, (Wed May 21, 9:06 pm)
Re: [PATCH 3/3] bnx2i: Add bnx2i iSCSI driver., Roland Dreier, (Fri May 23, 4:23 pm)
Re: [PATCH 3/3] bnx2i: Add bnx2i iSCSI driver., Anil Veerabhadrappa, (Fri May 23, 5:42 pm)
Re: [PATCH 3/3] bnx2i: Add bnx2i iSCSI driver., Roland Dreier, (Tue May 27, 10:38 am)
Re: [PATCH 3/3] bnx2i: Add bnx2i iSCSI driver., David Miller, (Tue May 27, 3:52 pm)
Re: [PATCH 3/3] bnx2i: Add bnx2i iSCSI driver., Michael Chan, (Tue May 27, 8:48 pm)
Re: [PATCH 3/3] bnx2i: Add bnx2i iSCSI driver., Jeff Garzik, (Tue May 27, 11:39 pm)
Re: [PATCH 3/3] bnx2i: Add bnx2i iSCSI driver., Hannes Reinecke, (Wed May 28, 4:47 am)
Re: [PATCH 3/3] bnx2i: Add bnx2i iSCSI driver., Michael Chan, (Tue May 27, 3:17 pm)
Re: [PATCH 3/3] bnx2i: Add bnx2i iSCSI driver., Roland Dreier, (Tue May 27, 2:21 pm)
Re: [PATCH 3/3] bnx2i: Add bnx2i iSCSI driver., Christoph Hellwig, (Thu May 22, 5:15 pm)
Re: [PATCH 3/3] bnx2i: Add bnx2i iSCSI driver., Michael Chan, (Thu May 22, 6:59 pm)
Re: [PATCH 3/3] bnx2i: Add bnx2i iSCSI driver., Konrad Rzeszutek, (Thu May 22, 11:15 am)
Re: [PATCH 3/3] bnx2i: Add bnx2i iSCSI driver., Anil Veerabhadrappa, (Thu May 22, 3:06 pm)
Re: [PATCH 3/3] bnx2i: Add bnx2i iSCSI driver., Ben Hutchings, (Thu May 22, 11:52 am)