On Fri, May 16, 2008 at 12:54:11PM +0300, Ilpo J?rvinen wrote:
quoted text
> > +		pnob->event_q_pa = virt_to_phys(pnob->event_q);
> > +		pnob->event_q_pa = cpu_to_le64(pnob->event_q_pa);
> 
> ...First of all, points from using standard converters instead of 
> inventing your own :-).
> 
> But alas, it won't be accepted by sparse. You need to use appropriate 
> le/be8/16/32/64 types when dealing with endianesses and then make sparse 
> happy too by using conversion in proper places. 

And virt_to_phys is a big no-way.  The driver needs to use the proper
dma api helpers to deal with iommus and other non-trivial hardware.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html