Re: [PATCH 12/13] QLogic VNIC: Driver Kconfig and Makefile.

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Roland Dreier
Date: Thursday, May 15, 2008 - 3:31 pm

> +config INFINIBAND_QLGC_VNIC_DEBUG
 > +	bool "QLogic VNIC Verbose debugging"
 > +	depends on INFINIBAND_QLGC_VNIC
 > +	default n
 > +	---help---
 > +	  This option causes verbose debugging code to be compiled
 > +	  into the QLogic VNIC driver.  The output can be turned on via the
 > +	  vnic_debug module parameter.

If you have runtime control of this, I suggest making it default to on,
like mthca does with:

	config INFINIBAND_MTHCA_DEBUG
		bool "Verbose debugging output" if EMBEDDED
		depends on INFINIBAND_MTHCA
		default y

otherwise distros will leave the option off and it becomes a pain to
debug problems because you force users to do compiles.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 00/13] QLogic Virtual NIC (VNIC) Driver , Ramachandra K, (Wed Apr 30, 10:15 am)
[PATCH 01/13] QLogic VNIC: Driver - netdev implementation, Ramachandra K, (Wed Apr 30, 10:16 am)
[PATCH 06/13] QLogic VNIC: IB core stack interaction, Ramachandra K, (Wed Apr 30, 10:18 am)
[PATCH 10/13] QLogic VNIC: Driver Statistics collection, Ramachandra K, (Wed Apr 30, 10:20 am)
[PATCH 12/13] QLogic VNIC: Driver Kconfig and Makefile., Ramachandra K, (Wed Apr 30, 10:21 am)
Re: [PATCH 00/13] QLogic Virtual NIC (VNIC) Driver, Roland Dreier, (Wed Apr 30, 3:25 pm)
Re: [PATCH 06/13] QLogic VNIC: IB core stack interaction, Roland Dreier, (Tue May 13, 1:40 pm)
Re: [PATCH 12/13] QLogic VNIC: Driver Kconfig and Makefile., Roland Dreier, (Thu May 15, 3:31 pm)