Home » Mailing list archives » linux-netdev » 2008 » May » 15

Re: dead network on JS21 with tg3 driver after flowcontrol changes

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Matt Carlson <mcarlson@...>
To: Olaf Hering <olaf@...>
Cc: Matt Carlson <mcarlson@...>, Michael Chan <mchan@...>, <linuxppc-dev@...>, <netdev@...>
Subject: Re: dead network on JS21 with tg3 driver after flowcontrol changes
Date: Thursday, May 15, 2008 - 1:15 pm

If you were to start with the original file, does the following patch
fix the problem?


diff --git a/drivers/net/tg3.c b/drivers/net/tg3.c
index 07b3f77..4c248d7 100644
--- a/drivers/net/tg3.c
+++ b/drivers/net/tg3.c
@@ -3168,8 +3168,7 @@ static int tg3_setup_fiber_mii_phy(struct tg3 *tp, int force_reset)
 	err |= tg3_readphy(tp, MII_BMCR, &bmcr);
 
 	if ((tp->link_config.autoneg == AUTONEG_ENABLE) && !force_reset &&
-	    (tp->tg3_flags2 & TG3_FLG2_PARALLEL_DETECT) &&
-	     tp->link_config.flowctrl == tp->link_config.active_flowctrl) {
+	    (tp->tg3_flags2 & TG3_FLG2_PARALLEL_DETECT)) {
 		/* do nothing, just check for link up at the end */
 	} else if (tp->link_config.autoneg == AUTONEG_ENABLE) {
 		u32 adv, new_adv;


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
dead network on JS21 with tg3 driver after flowcontrol changes, Olaf Hering, (Thu May 15, 8:13 am)
Re: dead network on JS21 with tg3 driver after flowcontrol c..., Matt Carlson, (Thu May 15, 1:15 pm)
Re: dead network on JS21 with tg3 driver after flowcontrol c..., Michael Chan, (Thu May 15, 3:51 pm)
Re: dead network on JS21 with tg3 driver after flowcontrol c..., Olaf Hering, (Fri May 16, 4:13 am)
Re: dead network on JS21 with tg3 driver after flowcontrol c..., Michael Chan, (Fri May 16, 11:09 am)
Re: dead network on JS21 with tg3 driver after flowcontrol c..., Michael Chan, (Thu May 15, 11:10 am)
Re: dead network on JS21 with tg3 driver after flowcontrol c..., Olaf Hering, (Thu May 15, 11:49 am)
Re: dead network on JS21 with tg3 driver after flowcontrol c..., Michael Chan, (Thu May 15, 1:37 pm)