Home » Mailing list archives » linux-netdev » 2008 » May » 14

[patch 10/11] rndis_host: increase delay in command response loop

Previous thread: [patch 09/11] drivers/net/tokenring/olympic.c: fix warning by akpm on Wednesday, May 14, 2008 - 4:20 pm. (2 messages)

Next thread: [patch 05/11] ehca: ret is unsigned, ibmebus_request_irq() negative return ignored in hca_create_eq() by akpm on Wednesday, May 14, 2008 - 4:20 pm. (2 messages)
[view original message]
From: akpm
Subject: [patch 10/11] rndis_host: increase delay in command response loop
Date: Wednesday, May 14, 2008 - 4:20 pm

From: Pierre Ynard <linkfanel@yahoo.fr>

Some devices running some WinCE firmware (with SC_* Samsung processors
according to the SynCE project, verified on a HTC P3600 device) fail to
register because they apparently need extra time to respond correctly to
requests.  Increase the existing delay to satisfy them.  Based on code
from the SynCE project, on a suggestion of David Brownell.

This patch Works For Me(tm).

Signed-off-by: Pierre Ynard <linkfanel@yahoo.fr>
Acked-by: David Brownell <david-b@pacbell.net>
Cc: Greg KH <greg@kroah.com>
Cc: Jeff Garzik <jeff@garzik.org>
Cc: "David S. Miller" <davem@davemloft.net>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 drivers/net/usb/rndis_host.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff -puN drivers/net/usb/rndis_host.c~rndis_host-increase-delay-in-command-response-loop drivers/net/usb/rndis_host.c
--- a/drivers/net/usb/rndis_host.c~rndis_host-increase-delay-in-command-response-loop
+++ a/drivers/net/usb/rndis_host.c
@@ -194,7 +194,7 @@ int rndis_command(struct usbnet *dev, st
 			dev_dbg(&info->control->dev,
 				"rndis response error, code %d\n", retval);
 		}
-		msleep(2);
+		msleep(20);
 	}
 	dev_dbg(&info->control->dev, "rndis response timeout\n");
 	return -ETIMEDOUT;
_
--


[ message continues ]
[view original message]
From: Jeff Garzik
Subject: Re: [patch 10/11] rndis_host: increase delay in command response loop
Date: Thursday, May 22, 2008 - 3:04 am

applied


--


[ message continues ]
Previous thread: [patch 09/11] drivers/net/tokenring/olympic.c: fix warning by akpm on Wednesday, May 14, 2008 - 4:20 pm. (2 messages)

Next thread: [patch 05/11] ehca: ret is unsigned, ibmebus_request_irq() negative return ignored in hca_create_eq() by akpm on Wednesday, May 14, 2008 - 4:20 pm. (2 messages)