Home » Mailing list archives » linux-netdev » 2008 » May » 13

Re: [PATCH 06/13] QLogic VNIC: IB core stack interaction

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Roland Dreier
Subject: Re: [PATCH 06/13] QLogic VNIC: IB core stack interaction
Date: Tuesday, May 13, 2008 - 1:40 pm

> +#include <rdma/ib_cache.h>

 > +	ret = ib_find_cached_pkey(viport_config->ibdev,
 > +				  viport_config->port,
 > +				  be16_to_cpu(viport_config->path_info.path.
 > +					      pkey),
 > +				  &attr->pkey_index);

I think this can just be replaced with ib_find_pkey()... there is a call
to kmalloc(... GFP_KERNEL) just a couple of lines about, so you are in a
context where sleeping is allowed.  As I said before we want to get rid
of the caching infrastructure so please don't add new users.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH 00/13] QLogic Virtual NIC (VNIC) Driver , Ramachandra K, (Wed Apr 30, 10:15 am)
[PATCH 01/13] QLogic VNIC: Driver - netdev implementation, Ramachandra K, (Wed Apr 30, 10:16 am)
[PATCH 02/13] QLogic VNIC: Netpath - abstraction of connec ..., Ramachandra K, (Wed Apr 30, 10:16 am)
[PATCH 03/13] QLogic VNIC: Implementation of communication ..., Ramachandra K, (Wed Apr 30, 10:17 am)
[PATCH 04/13] QLogic VNIC: Implementation of Control path ..., Ramachandra K, (Wed Apr 30, 10:17 am)
[PATCH 05/13] QLogic VNIC: Implementation of Data path of ..., Ramachandra K, (Wed Apr 30, 10:18 am)
[PATCH 06/13] QLogic VNIC: IB core stack interaction, Ramachandra K, (Wed Apr 30, 10:18 am)
[PATCH 07/13] QLogic VNIC: Handling configurable parameter ..., Ramachandra K, (Wed Apr 30, 10:19 am)
[PATCH 08/13] QLogic VNIC: sysfs interface implementation ..., Ramachandra K, (Wed Apr 30, 10:19 am)
[PATCH 09/13] QLogic VNIC: IB Multicast for Ethernet broad ..., Ramachandra K, (Wed Apr 30, 10:20 am)
[PATCH 10/13] QLogic VNIC: Driver Statistics collection, Ramachandra K, (Wed Apr 30, 10:20 am)
[PATCH 11/13] QLogic VNIC: Driver utility file - implement ..., Ramachandra K, (Wed Apr 30, 10:21 am)
[PATCH 12/13] QLogic VNIC: Driver Kconfig and Makefile., Ramachandra K, (Wed Apr 30, 10:21 am)
[PATCH 13/13] QLogic VNIC: Modifications to IB Kconfig and ..., Ramachandra K, (Wed Apr 30, 10:22 am)
Re: [PATCH 00/13] QLogic Virtual NIC (VNIC) Driver, Roland Dreier, (Wed Apr 30, 3:25 pm)
Re: [PATCH 08/13] QLogic VNIC: sysfs interface implementat ..., Stephen Hemminger, (Thu May 1, 7:56 am)
Re: [PATCH 11/13] QLogic VNIC: Driver utility file - imple ..., Stephen Hemminger, (Thu May 1, 7:58 am)
Re: [PATCH 01/13] QLogic VNIC: Driver - netdev implementation, Roland Dreier, (Fri May 2, 11:15 am)
Re: [ofa-general] Re: [PATCH 01/13] QLogic VNIC: Driver - ..., Ramachandra K, (Mon May 5, 8:36 am)
Re: [ofa-general] Re: [PATCH 01/13] QLogic VNIC: Driver - ..., Roland Dreier, (Mon May 5, 1:42 pm)
Re: [PATCH 06/13] QLogic VNIC: IB core stack interaction, Roland Dreier, (Tue May 13, 1:40 pm)
Re: [PATCH 07/13] QLogic VNIC: Handling configurable param ..., Roland Dreier, (Tue May 13, 1:41 pm)
Re: [PATCH 12/13] QLogic VNIC: Driver Kconfig and Makefile., Roland Dreier, (Thu May 15, 3:31 pm)
Re: [PATCH 10/13] QLogic VNIC: Driver Statistics collection, Roland Dreier, (Thu May 15, 3:33 pm)
Re: [ofa-general] [PATCH 09/13] QLogic VNIC: IB Multicast ..., Roland Dreier, (Thu May 15, 3:38 pm)
Re: [ofa-general] Re: [PATCH 10/13] QLogic VNIC: Driver St ..., Ramachandra K, (Tue May 20, 9:52 am)