login
Header Space

 
 

[PATCH] Fix kernel-doc for skb_segment

Score:
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: <netdev@...>, David Miller <davem@...>
Date: Monday, April 7, 2008 - 2:28 pm

The kernel-doc comment for skb_segment is clearly wrong.  This states what
it actually does.

Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
diff --git a/net/core/skbuff.c b/net/core/skbuff.c
index 0d0fd28..6087013 100644
--- a/net/core/skbuff.c
+++ b/net/core/skbuff.c
@@ -2131,8 +2131,8 @@ EXPORT_SYMBOL_GPL(skb_pull_rcsum);
  *	@features: features for the output path (see dev->features)
  *
  *	This function performs segmentation on the given skb.  It returns
- *	the segment at the given position.  It returns NULL if there are
- *	no more segments to generate, or when an error is encountered.
+ *	a pointer to the first in a list of new skbs for the segments.
+ *	In case of error it returns ERR_PTR(err).
  */
 struct sk_buff *skb_segment(struct sk_buff *skb, int features)
 {

-- 
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH] Fix kernel-doc for skb_segment, Ben Hutchings, (Mon Apr 7, 2:28 pm)
Re: [PATCH] Fix kernel-doc for skb_segment, David Miller, (Mon Apr 14, 12:53 am)
speck-geostationary