login
Header Space

 
 

linux-netdev mailing list

FromSubjectsort iconDate
Jeff Garzik
[git patches] net driver fixes (v2)
NOTE: dropped dmfe change, would cause regression noted by Meelis Please pull from 'upstream-davem' branch of master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git upstream-davem to receive the following updates: drivers/net/forcedeth.c | 5 ++--- drivers/net/phy/marvell.c | 2 -- drivers/net/tokenring/olympic.c | 6 +++--- 3 files changed, 5 insertions(+), 8 deletions(-) Adrian Bunk (1): net/tokenring/olympic.c section fixes Al Viro (1): ...
Apr 4, 5:29 pm 2008
David Miller
Re: [git patches] net driver fixes (v2)
From: Jeff Garzik <jeff@garzik.org> Pulled and pushed back out to net-2.6, thanks Jeff! --
Apr 4, 6:04 pm 2008
Kok, Auke
[ANNOUNCE] e1000 to e1000e migration of PCI Express devices
All, From kernel 2.6.26 onward all *PCI Express* device IDs previously supported by e1000 will be moving to the e1000e driver. This includes ich8 and ich9 onboard LAN, server 5000 platform onboard LAN (es2) and 82571/2/3 chipset based adapters and variants. If you have not already enabled CONFIG_E1000E make sure that you do so. You can already do this with 2.6.25. From 2.6.26 on this change will be required if you have such a device. It is also worthwhile to note you will have to update yo...
Apr 4, 5:11 pm 2008
Dave Hansen
Re: [ANNOUNCE] e1000 to e1000e migration of PCI Express devi...
I've been bitten by one or two of these in the past. Can we do something like this for a couple of releases? Shouldn't this default the E1000E config option to the same thing that people have the E1000 set as? It should catch the dumb people like me who's enter key gets held down during a 'make oldconfig'. :) diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig index 3a0b20a..aa0fe14 100644 --- a/drivers/net/Kconfig +++ b/drivers/net/Kconfig @@ -2005,6 +2005,7 @@ config E1000_DISABLE_PACK...
Apr 4, 5:31 pm 2008
Jeff Garzik
Re: [ANNOUNCE] e1000 to e1000e migration of PCI Express devi...
That's not pretty for embedded folks who don't want an extra driver to come along for the ride ;-) It's also been suggested, as an alternative, to add 'select E1000E' to E1000's Kconfig entry. Rather than doing that, I am hoping that education -- Auke's announcements -- plus "ripping the band-aid off quickly", will be the best approach. Most kernel distributions will have enabled both Kconfig options anyway, so that leaves individual kernel hackers who missed the announcements as the ...
Apr 4, 5:52 pm 2008
Kok, Auke
Re: [E1000-devel] [ANNOUNCE] e1000 to e1000e migration of PC...
that discussion went into the bar and never came out again last time it was proposed. I really do not want to have any more bandages around. Also your patch will not help much since in 2.6.24 there already is a CONFIG_E1000E option so we've passed the stage for many people where this hack would work. Auke --
Apr 4, 5:49 pm 2008
Allan Stephens
[PATCH net-2.6.26] [TIPC]: Eliminate port pointer in TIPC so...
This patch eliminates the "port" pointer in the TIPC socket object by storing this info in the (previously unused) sk_user_data field of the standard sock structure. Signed-off-by: Allan Stephens <allan.stephens@windriver.com> --- net/tipc/socket.c | 129 ++++++++++++++++++++++++++++++---------------------- 1 files changed, 74 insertions(+), 55 deletions(-) diff --git a/net/tipc/socket.c b/net/tipc/socket.c index 1b5fb61..4ad1807 100644 --- a/net/tipc/socket.c +++ b/net/tipc/socket.c ...
Apr 4, 4:59 pm 2008
Allan Stephens
[PATCH net-2.6.26] [TIPC]: Improve socket time conversions
This patch modifies TIPC's socket code to use standard kernel routines to handle time conversions between jiffies and ms. This ensures proper operation even when HZ isn't 1000. Acknowledgements to Eric Sesterhenn <snakebyte@gmx.de> for identifying this issue and proposing a solution. Signed-off-by: Allan Stephens <allan.stephens@windriver.com> --- net/tipc/socket.c | 9 +++++---- 1 files changed, 5 insertions(+), 4 deletions(-) diff --git a/net/tipc/socket.c b/net/tipc/socket....
Apr 4, 4:59 pm 2008
Allan Stephens
[PATCH net-2.6.26] [TIPC]: Remove redundant socket wait queu...
This patch eliminates re-initialization of the standard socket wait queue used for sleeping in TIPC's socket creation code. Signed-off-by: Allan Stephens <allan.stephens@windriver.com> --- net/tipc/socket.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/net/tipc/socket.c b/net/tipc/socket.c index 4ad1807..64be71a 100644 --- a/net/tipc/socket.c +++ b/net/tipc/socket.c @@ -170,7 +170,6 @@ static int tipc_create(struct net *net, struct socket *sock, int protocol) ...
Apr 4, 4:59 pm 2008
Andrew Brampton
sock_get_timestamp() ktime_to_timeval returns -2?
Hi, I'm using the following piece of code to record the received time of my packets. struct timeval tv = {0,0}; if ( ioctl(s, SIOCGSTAMP, &tv) ) return 0; When I use UDP this is all great, but when I use TCP this stops working. I have since found out that I can't use this for TCP packets[1], but the reason I'm writing this email is because ioctl returns zero when using TCP and tv has a odd value in it. tv.tv_sec = -2, and tv.tv_usec = 999999. Now I assume -2 is some kind of error ...
Apr 4, 2:38 pm 2008
Gabriel C
array subscript is above array bounds warnings with gcc4.3
Hi, I noticed these warning on my randconfig logs of some builds : .. drivers/usb/core/hcd.c: In function 'usb_hcd_poll_rh_status': include/asm/string_32.h:65: warning: array subscript is above array bounds net/netfilter/nf_conntrack_proto_sctp.c: In function 'sctp_packet': net/netfilter/nf_conntrack_proto_sctp...
Apr 4, 1:31 pm 2008
Adrian Bunk
Re: array subscript is above array bounds warnings with gcc4.3
Sounds like a known and already fixed bug in gcc. Can you confirm that they go away when you build your compiler from the cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed --
Apr 4, 2:05 pm 2008
Gabriel C
Re: array subscript is above array bounds warnings with gcc4.3
I cannot do that right now but I'll build SVN 4.3 tomorrow and report back. Gabriel --
Apr 4, 2:12 pm 2008
Johannes Berg
Re: 2.6.25-rc8-mm1 -- INFO: possible circular locking depend...
Below is a better version of the trace Miles sent me privately, but I have no idea what would be causing it. I don't think it's related to wireless. =EF=BB=BF=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D [ INFO: possible circular locking dependency detected ] 2.6.25-rc8-mm1 #15 ------------------------------------------------------- iw/9417 is trying to acquire lock: (g...
Apr 4, 11:45 am 2008
Andrew Morton
Re: 2.6.25-rc8-mm1 -- INFO: possible circular locking depend...
Yes, that looks like a problem in the core netlink code. git-net contains several largeish changes to it.. --
Apr 4, 1:43 pm 2008
Stephen Hemminger
Re: 2.6.25-rc8-mm1 -- INFO: possible circular locking depend...
On Fri, 4 Apr 2008 10:43:02 -0700 The changes in git-net don't look locking related. I suspect either: wireless is calling netlink without holding rtnl_lock; or more likely conditional locking ctrl_dumpfamily is confusing lockdep. ctrl_dumpfamily only acquires genl_lock if one of the incoming parameters (chains_to_skip) is non-zero. Not sure what the design reason is, Thomas could you add a comment? --
Apr 4, 3:11 pm 2008
Thomas Graf
Re: 2.6.25-rc8-mm1 -- INFO: possible circular locking depend...
First call to ctrl_dumpfamily() is coming directly from the message processing context where genl_lock is already held. Subsequence calls come from netlink_recvmsg() so we have to take the lock separately. However, I just noticed the condition should really be chains_to_skip != 0 || fams_to_skip != 0 --
Apr 4, 3:53 pm 2008
Pavel Emelyanov
[RFC][PATCH 0/3] Make loopback device weight twice as little.
I noticed, that on a 32bit box with a non-debug config the sizeof(struct net_device) is slightly more than 1024. This means, that for example loopback device (with sizeof_priv == 0) is allocated from the size-2048 cache and thus we have ~1000 wasted bytes. I know, that this is not that much, all the more so on most of the setups the lo device is single :) but with the net-namespaced kernel each namespace has its own loopback device, so this problem becomes more relevant. I also guess, that t...
Apr 4, 10:09 am 2008
Pavel Emelyanov
[RFC][PATCH 3/3] Move net_device->uninit callback on net_...
The void calls are even simpler. Plus ~18 more patches and all the ops will be moved on the net_device_ops and it will be possible to start converting device drivers... So, what is your opinion about all this? Signed-off-by: Pavel Emelyanov <xemul@openvz.org> --- net/core/dev.c | 15 +++++++++++---- 1 files changed, 11 insertions(+), 4 deletions(-) diff --git a/net/core/dev.c b/net/core/dev.c index a01c078..3428534 100644 --- a/net/core/dev.c +++ b/net/core/dev.c @@ -3644,8 +...
Apr 4, 10:14 am 2008
Pavel Emelyanov
[RFC][PATCH 2/3] Move net_device->init callback on net_de...
This is how all the other temporary operations will be done. The return code is still 0 in case init is not set by driver. Signed-off-by: Pavel Emelyanov <xemul@openvz.org> --- net/core/dev.c | 13 +++++++++++-- 1 files changed, 11 insertions(+), 2 deletions(-) diff --git a/net/core/dev.c b/net/core/dev.c index 5e7bf79..a01c078 100644 --- a/net/core/dev.c +++ b/net/core/dev.c @@ -3701,8 +3701,8 @@ int register_netdevice(struct net_device *dev) dev->iflink = -1; /* Init, ...
Apr 4, 10:12 am 2008
Pavel Emelyanov
[RFC][PATCH 1/3] Introduce the net_device_ops structure.
And fill it with copied from net_device. Also make newly created devices be assigned to the (currently empty) nd_default_ops. Signed-off-by: Pavel Emelyanov <xemul@openvz.org> --- include/linux/netdevice.h | 39 +++++++++++++++++++++++++++++++++++++++ net/core/dev.c | 9 +++++++++ 2 files changed, 48 insertions(+), 0 deletions(-) diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h index 8b17ed4..33f00ff 100644 --- a/include/linux/netdevice.h +++ b/in...
Apr 4, 10:10 am 2008
Stephen Hemminger
Re: [RFC][PATCH 1/3] Introduce the net_device_ops structure.
On Fri, 04 Apr 2008 18:10:52 +0400 Thanks, I started this a while back but never got to the bottom. Please use const where possible (on dev->nd_ops) and in devices. --
Apr 4, 11:14 am 2008
Patrick McHardy
Re: [RFC][PATCH 1/3] Introduce the net_device_ops structure.
It might make sense to keep hard_start_xmit and hard_header in struct net_device since VLAN and Bonding overload them. --
Apr 4, 11:54 am 2008
Thomas Klein
[PATCH] ehea: Fix DLPAR memory add support
This patch fixes two weaknesses in send/receive packet handling which may lead to kernel panics during DLPAR memory add operations. Signed-off-by: Thomas Klein <tklein@de.ibm.com> --- diff -Nurp -X dontdiff linux-2.6.25-rc8/drivers/net/ehea/ehea.h patched_kernel/drivers/net/ehea/ehea.h --- linux-2.6.25-rc8/drivers/net/ehea/ehea.h 2008-04-01 21:44:26.000000000 +0200 +++ patched_kernel/drivers/net/ehea/ehea.h 2008-04-03 15:36:36.000000000 +0200 @@ -40,7 +40,7 @@ #include <asm/io.h> ...
Apr 4, 9:04 am 2008
Tetsuo Handa
[TOMOYO #7 30/30] Hooks for SAKURA and TOMOYO.
This file contains modifications against kernel source code needed to use TOMOYO Linux 1.6. Although LSM hooks are provided for performing access control, TOMOYO Linux 1.6 doesn't use LSM because of the following reasons. Reason 1: CONFIG_SECURITY=y adds security fields to various structures and introduces hooks for allocating/freeing these security fields. But TOMOYO Linux can hardly utilize them. TOMOYO Linux requires modification against only "struct task_struct", and adding two variable...
Apr 4, 8:23 am 2008
Daniel Walker
Re: [TOMOYO #7 30/30] Hooks for SAKURA and TOMOYO.
file system, networking, arch, etc split into separate patches. For example you have a number of patches just adding header files. You could merge the header file with the hook additions. Then you have a natural For instance if the function name was "tomoyo_check_capable" it would be clear that it's part of your code.. The current function naming here is ifdefs? --
Apr 4, 12:29 pm 2008
Tetsuo Handa
[TOMOYO #7 07/30] Some wrapper functions for socket operation.
These functions checks whether TOMOYO can do permission checks or not. TOMOYO won't do permission checks if the process is a kernel thread or the process is not permitted to sleep. Signed-off-by: Kentaro Takeda <takedakn@nttdata.co.jp> Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> Signed-off-by: Toshiharu Harada <haradats@nttdata.co.jp> Cc: linux-netdev <netdev@vger.kernel.org> --- include/linux/tomoyo_socket.h | 419 ++++++++++++++++++++++++++++++++++...
Apr 4, 8:22 am 2008
Patrick McHardy Apr 4, 8:13 am 2008
Arnaldo Carvalho de Melo
Re: [DCCP]: Fix skb->cb conflicts with IP
Thanks Patrick, Acked-by: Arnaldo Carvalho de Melo <acme@redhat.com> --
Apr 4, 9:26 am 2008
Gerrit Renker
Re: [DCCP]: Fix skb->cb conflicts with IP
Arnaldo, just a thought - I recall that there used to be a bug related to this, which required to insert the following before sending an skb: memset(&(IPCB(skb)->opt), 0, sizeof(IPCB(skb)->opt)) This was about 1+1/2 .. 2 years ago and lead to crashes when the memset was removed. Maybe with this solution the memsets are then no longer necessary? The reference is * output.c:dccp_transmit_skb() * ipv4.c:dccp_v4_send_response() Gerrit | commit eced67957ee99f7b5fafdc73a...
Apr 4, 9:25 am 2008
Arnaldo Carvalho de Melo
Re: [DCCP]: Fix skb->cb conflicts with IP
Well spotted, yes, those can now be safely removed, since we don't touch the initial inet6?_skb_parm area it will remain as zeros (alloc_skb did that for us) and we don't have to zero it anymore before passing it to IP. --
Apr 4, 9:47 am 2008
Patrick McHardy
Re: [DCCP]: Fix skb->cb conflicts with IP
Yes, that shouldn't be needed anymore with this patch. --
Apr 4, 9:40 am 2008
Julius Volz
[PATCH] Move IPVS from net/ipv4/ipvs to net/netfilter/ipvs i...
Hi, This patch moves IPVS from net/ipv4/ipvs to net/netfilter/ipvs, as discussed earlier with Horms and Patrick McHardy. This is done as a preparation for later adding IPv6 functionality to IPVS. The patch is 600kb, so I uploaded it here: http://www-user.tu-chemnitz.de/~volz/move_ipvs_to_netfilter.patch -------------------------- Description: Move IPVS from net/ipv4/ipvs to net/netfilter/ipvs as a preparation for adding IPv6 support to IPVS later on. Signed-off-by: Julius R. Volz <juliu...
Apr 4, 6:40 am 2008
Bodo Eggert
Re: GFP_ATOMIC page allocation failures.
What about reverse ratelimiting: If the limit is reached, a backtrace will be generated (and, off cause, positively ratelimited)? --
Apr 4, 5:52 am 2008
Nick Piggin
Re: GFP_ATOMIC page allocation failures.
I was thinking about that. I got as far as writing a simple patch to printk so that it would not start to trigger until it gets a 2nd event within 'n' jiffies of the first. But actually developers do sometimes want see the event even if it is relatively infrequent... --
Apr 4, 6:59 am 2008
Bodo Eggert
Re: GFP_ATOMIC page allocation failures.
I think there was a standalone ratelimit function. I'd use it like this: static atomic_alloc_ratelimit; /* needs to be initialized ... */ { ... if (success) return mem; if(!debug && ratelimit(atomic_alloc_ratelimit)) return err_ptr(-ENOMEM); if (printk_ratelimit(first line) > 0) { printk(rest); } You shouldn't frighten the users either. /proc/sys/vm/debug? --
Apr 4, 7:35 am 2008
Pavel Emelyanov
[PATCH][VLAN]: Fix egress priority mappings leak.
These entries are allocated in vlan_dev_set_egress_priority, but are never released and leaks on vlan device removal. Drop these in vlan's ->uninit callback - after the device is brought down and everyone is notified about it is going to be unregistered. Found during testing vlan netnsization patchset. Signed-off-by: Pavel Emelyanov <xemul@openvz.org> --- diff --git a/net/8021q/vlan_dev.c b/net/8021q/vlan_dev.c index 480ea90..41a76a0 100644 --- a/net/8021q/vlan_dev.c +++ b/ne...
Apr 4, 6:07 am 2008
Patrick McHardy
Re: [PATCH][VLAN]: Fix egress priority mappings leak.
Good catch, thanks. Acked-by: Patrick McHardy <kaber@trash.net> --
Apr 4, 5:45 am 2008
David Miller
Re: [PATCH][VLAN]: Fix egress priority mappings leak.
From: Patrick McHardy <kaber@trash.net> Applied, thanks a lot. --
Apr 4, 3:45 pm 2008
Meelis Roos
Re: [patch] NET: remove support for Davicom 9102 from the Tu...
Hmm, did you see my yesterdays answer to that patch - that dmfe should first be fixed to work on all cards with this PCI ID? Currenty dmfe fails to work on at least Sun Fire V100 and Sun Netra X1 boxes, only tulip works. -- Meelis Roos (mroos@linux.ee) --
Apr 4, 4:56 am 2008
Jeff Garzik
Re: [patch] NET: remove support for Davicom 9102 from the Tu...
Maybe this tulip_core.c code needs to be applied to dmfe.c? if (tulip_uli_dm_quirk(pdev)) { csr0 &= ~0x01f100ff; #if defined(CONFIG_SPARC) csr0 = (csr0 & ~0xff00) | 0xe000; #endif } A zeroed MAC address leads me to believe that dmfe's SROM parsing isn't quite as capable as tulip's, though that's just a guess. Just checked dmfe with sparse and it reports clean, though looking at the code it could use some cleanups. Jeff ...
Apr 4, 5:59 pm 2008
David Miller
Re: [patch] NET: remove support for Davicom 9102 from the Tu...
From: Jeff Garzik <jeff@garzik.org> The sparc64 onboard davicoms don't indicate anything in the SROM area. Properties such as MAC addresses need to be obtained via openfirmware probing methods. --
Apr 4, 6:05 pm 2008
Jeff Garzik
Re: [patch] NET: remove support for Davicom 9102 from the Tu...
I didn't see that, no... thanks for poking me. Jeff --
Apr 4, 5:27 pm 2008
David Miller
Re: [patch] NET: remove support for Davicom 9102 from the Tu...
From: Meelis Roos <mroos@linux.ee> Don't worry I won't pull from Jeff's tree until this issue is resolved. --
Apr 4, 3:43 pm 2008
Jeff Garzik
[git patches] net driver fixes
I will have another batch to send in the next day or so, including a notable forcedeth fix. Please pull from 'upstream-davem' branch of master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git upstream-davem to receive the following updates: drivers/net/forcedeth.c | 5 ++--- drivers/net/phy/marvell.c | 2 -- drivers/net/tokenring/olympic.c | 6 +++--- drivers/net/tulip/tulip_core.c | 1 - 4 files changed, 5 insertions(+), 9 deletions(-) Adrian Bunk (1...
Apr 4, 2:33 am 2008
David Miller
Re: [git patches] net driver fixes
From: Jeff Garzik <jeff@garzik.org> I think we need to defer the Tulip davicom ID removal patch, because the tulip driver is the only one that works on sparc64 for davicom chips, dmfe does not. That's a regression, so I can't pull this in as-is. I'm happy to discuss the davicom+sparc64 issue, but for now if you could simply give me a tree which contains the other bug fixes we can integrate those now. Thanks! --
Apr 4, 3:39 pm 2008
Gilles Espinasse
Re: [git patches] net driver fixes
I was looking at some dfme vs tulip google search. How the id removal accord to this debian bug report http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=400837 Looking at dmfe history on git, it is not clearly stated this problem has been fixed. http://git.kernel.org/?p=linux/kernel/git/stable/linux-2.6.24.y.git;a=history;f=driver... Gilles --
Apr 4, 6:37 am 2008
Wenji Wu
A Linux TCP SACK Question
Hi, Could any body help me out with Linux TCP SACK? Thanks in advance. I run iperf to send traffic from sender to receiver. and add packet reordering in both forward and reverse directions. I found when I turn off the SACK/DSACK option, the throughput is better than with the SACK/DSACK on? How could it happen in this way? did anybody encounter this phenomenon before? thanks, wenji --
Apr 4, 12:54 am 2008
John Heffner
Re: A Linux TCP SACK Question
Unless you're sending very fast, where the computational overhead of processing SACK blocks is slowing you down, this is not expected behavior. Do you have more detail? What is the window size, and how much reordering? Full binary tcpdumps are very useful in diagnosing this type of problem. -John --
Apr 4, 12:27 pm 2008
Wenji Wu
RE: A Linux TCP SACK Question
Hi, John, Thanks, I just sat with Richard Clarson and repeat the phenomenon. The experiment works as: Sender --- Router --- Receiver Iperf is sending from the sender to the receiver. In between there is an emulated router which runs netem. The emulated router has two interfaces, both with netem configured. One interface emulates the forward path and the other for the reverse path. Both netem interfaces are configured with 1.5ms delay and 0.15ms variance. No packet drops. Every syst...
Apr 4, 1:49 pm 2008
previous daytodaynext day
April 3, 2008April 4, 2008April 5, 2008
speck-geostationary