login
Header Space

 
 

Re: [ANNOUNCE] e1000 to e1000e migration of PCI Express devices

Score:
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Kok, Auke <auke-jan.h.kok@...>
Cc: Linux Kernel Mailing List <linux-kernel@...>, NetDev <netdev@...>, e1000-list <e1000-devel@...>, linux-pci maillist <linux-pci@...>, Jeff Garzik <jeff@...>, Andrew Morton <akpm@...>, David S. Miller <davem@...>, Linus Torvalds <torvalds@...>, Jesse Brandeburg <jesse.brandeburg@...>, Ronciak, John <john.ronciak@...>, Allan, Bruce W <bruce.w.allan@...>, Greg KH <greg@...>, Arjan van de Ven <arjan@...>
Date: Friday, April 4, 2008 - 5:31 pm

On Fri, 2008-04-04 at 14:11 -0700, Kok, Auke wrote:

I've been bitten by one or two of these in the past.  Can we do
something like this for a couple of releases?

Shouldn't this default the E1000E config option to the same thing that
people have the E1000 set as?  It should catch the dumb people like me
who's enter key gets held down during a 'make oldconfig'. :)

diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
index 3a0b20a..aa0fe14 100644
--- a/drivers/net/Kconfig
+++ b/drivers/net/Kconfig
@@ -2005,6 +2005,7 @@ config E1000_DISABLE_PACKET_SPLIT
 config E1000E
        tristate "Intel(R) PRO/1000 PCI-Express Gigabit Ethernet support"
        depends on PCI
+       default E1000
        ---help---
          This driver supports the PCI-Express Intel(R) PRO/1000 gigabit
          ethernet family of adapters. For PCI or PCI-X e1000 adapters,


-- Dave

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re: [ANNOUNCE] e1000 to e1000e migration of PCI Express devi..., Dave Hansen, (Fri Apr 4, 5:31 pm)
speck-geostationary