login
Header Space

 
 

linux-netdev mailing list

FromSubjectsort iconDate
Andi Kleen
[PING^3] [PATCH] srandom32 fixes for networking v2
srandom32 fixes for networking v2 - Let it update the state of all CPUs. The network stack goes into pains to feed the current IP addresses in, but it is not very effective if that is only done for some random CPU instead of all. So change it to feed bits into all CPUs. I decided to do that lockless because well somewhat random results are ok. v2: Drop rename so that this patch doesn't depend on x86 maintainers Signed-off-by: Andi Kleen <ak@suse.de> --- include/linux/net.h | 2 ...
Apr 3, 4:36 pm 2008
David Miller
Re: [PING^3] [PATCH] srandom32 fixes for networking v2
From: Andi Kleen <andi@firstfloor.org> Applied, thanks. --
Apr 3, 5:07 pm 2008
Mandeep Singh Baines
Re: [PATCH] [ETHTOOL]: Add support for large eeproms
Thanks Joe, Fixed and updated patch. Please take another look. Regards, Mandeep Fixed --- Currently, it is not possible to read/write to an eeprom larger than 128k in size because the buffer used for temporarily storing the eeprom contents is allocated using kmalloc. kmalloc can only allocate a maximum of 128k depending on architecture. Modified ethtool_get/set_eeprom to only allocate a page of memory and then copy the eeprom a page at a time. Signed-off-by: Mandeep Singh Baines ...
Apr 3, 2:00 pm 2008
Auke Kok
[PATCH 1/2] ixgb: convert uint16_t style integers to u16
From: Joe Perches <joe@perches.com> Conglomerate of 4 separate patches by Joe. Signed-off-by: Joe Perches <joe@perches.com> Signed-off-by: Auke Kok <auke-jan.h.kok@intel.com> --- drivers/net/ixgb/ixgb.h | 32 +++-- drivers/net/ixgb/ixgb_ee.c | 74 ++++++------ drivers/net/ixgb/ixgb_ee.h | 10 +- drivers/net/ixgb/ixgb_ethtool.c | 50 ++++---- drivers/net/ixgb/ixgb_hw.c | 144 ++++++++++++------------ drivers/net/ixgb/ixgb_hw.h | 234 +++...
Apr 3, 1:06 pm 2008
Auke Kok
[PATCH 2/2] e1000: convert uint16_t style integers to u16
From: Joe Perches <joe@perches.com> Conglomerate from 4 separate patches from Joe. Signed-off-by: Joe Perches <joe@perches.com> Signed-off-by: Auke Kok <auke-jan.h.kok@intel.com> --- drivers/net/e1000/e1000.h | 86 +- drivers/net/e1000/e1000_ethtool.c | 160 ++-- drivers/net/e1000/e1000_hw.c | 1324 +++++++++++++++++++------------------ drivers/net/e1000/e1000_hw.h | 512 +++++++------- drivers/net/e1000/e1000_main.c | 174 ++--- 5 files changed, ...
Apr 3, 1:06 pm 2008
YOSHIFUJI Hideaki /
[PATCH net-2.6.26] [SCTP]: Use snmp_mib_{init,free}().
Signed-off-by: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org> --- diff --git a/net/sctp/protocol.c b/net/sctp/protocol.c index ad0a406..225e260 100644 --- a/net/sctp/protocol.c +++ b/net/sctp/protocol.c @@ -972,24 +972,14 @@ int sctp_register_pf(struct sctp_pf *pf, sa_family_t family) return 1; } -static int __init init_sctp_mibs(void) +static inline int init_sctp_mibs(void) { - sctp_statistics[0] = alloc_percpu(struct sctp_mib); - if (!sctp_statistics[0]) - return -ENOMEM; - sc...
Apr 3, 11:16 am 2008
YOSHIFUJI Hideaki /
[PATCH net-2.6.26] [DCCP]: Use snmp_mib_{init,free}().
Signed-off-by: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org> --- diff --git a/net/dccp/proto.c b/net/dccp/proto.c index e3f5d37..d534cdf 100644 --- a/net/dccp/proto.c +++ b/net/dccp/proto.c @@ -1010,33 +1010,14 @@ void dccp_shutdown(struct sock *sk, int how) EXPORT_SYMBOL_GPL(dccp_shutdown); -static int __init dccp_mib_init(void) +static inline int dccp_mib_init(void) { - int rc = -ENOMEM; - - dccp_statistics[0] = alloc_percpu(struct dccp_mib); - if (dccp_statistics[0] == NULL) ...
Apr 3, 11:16 am 2008
Arnaldo Carvalho de Melo
Re: [PATCH net-2.6.26] [DCCP]: Use snmp_mib_{init,free}().
Acked-by: Arnaldo Carvalho de Melo <acme@redhat.com> --
Apr 3, 11:36 am 2008
Stefan Roese
[PATCH] ibm_newemac: Fix problem with jumbo frame support an...
This fixes the jumbo frame support on EMAC V4 systems. Now the correct bit is set depending on the EMAC version configured. Tested on Kilauea (405EX) and Canyonlands (460EX). Signed-off-by: Stefan Roese <sr@denx.de> --- drivers/net/ibm_newemac/core.c | 5 ++++- 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/drivers/net/ibm_newemac/core.c b/drivers/net/ibm_newemac/core.c index 0789802..486901f 100644 --- a/drivers/net/ibm_newemac/core.c +++ b/drivers/net/ibm_newemac/c...
Apr 3, 10:16 am 2008
Marco Berizzi
Re: 2.6.25-rc8 regression with openswan
I have sent you the output of ip -s x s and ip -s x p when openswan is working with 2.6.25-rc8 with the commit df9dcb458 reverted. Let me know you need ssh access to my 2.6.25 box. --
Apr 3, 10:06 am 2008
Patrick McHardy
Re: 2.6.25-rc8 regression with openswan
The problem appears to be that openswan doesn't initialize the selectors family when adding new SAs. xfrm_init_state() uses the family to decide whether to set up inter family SAs or regular SAs. We used to fix up the family in xfrm_user, but this is now only done for transport mode SAs. - /* - * Set inner address family if the KM left it as zero. - * See comment in validate_tmpl. - */ - if (!x->sel.family) + if (x->props.mode == XFRM_MODE_TRANSPORT...
Apr 3, 10:36 am 2008
Ilpo Järvinen
Re: 2.6.25-rc8: WARNING: at net/ipv4/tcp_input.c:2173 tcp_ma...
...I'm just trying to find out who and where invariants of the TCP code are broken. These were relatively recently enabled (pre-2.6.24 just didn't care too much). A number of long standing issues plus bugs from my Can you reproduce it? Please include netdev next time while report networking related problems. -- i. --
Apr 3, 9:26 am 2008
Soeren Sonnenburg
Re: 2.6.25-rc8: WARNING: at net/ipv4/tcp_input.c:2173 tcp_ma...
Yes, by massively downloading things :-) But I have no real recipe to make it easily reproducible... Looks like you are in fact interested in: grep WARNING: /var/log/kern.log | cut -c 40- | sort -u net/ipv4/tcp_input.c:1771 tcp_enter_frto+0x267/0x270() net/ipv4/tcp_input.c:2173 tcp_mark_head_lost+0x11d/0x150() net/ipv4/tcp_input.c:2532 tcp_ack+0x1a6f/0x1d60() OK Soeren --
Apr 3, 9:40 am 2008
Dmitry Butskoy
[PATCH] reopen bug #8747 -- complete the fix
Hi, There was a bug http://bugzilla.kernel.org/show_bug.cgi?id=8747, "MSG_ERRQUEUE messages do not pass to connected raw sockets", which still is not fixed completely. I've made a patch (attached), against the 2.6.24.4 tree. The patch fixes the issue completely for me, I've successfully tested it with my traceroute(8) (http://traceroute.sf.net) implementation. Sorry that I have not checked up the previous attempt in real tests. I assumed that "typo" which I had found at that time (saddr...
Apr 3, 9:11 am 2008
Marco Berizzi
Re: 2.6.25-rc8 regression with openswan
yess, I have reverted that commit: now openswan is happy again. As always, thanks a lot Patrick --
Apr 3, 8:31 am 2008
Patrick McHardy
Re: 2.6.25-rc8 regression with openswan
Thanks, now we just have to figure out whats wrong with that commit :) I'll give it a try myself once the compile finishes. --
Apr 3, 8:35 am 2008
Patrick McHardy
Re: 2.6.25-rc8 regression with openswan
Manually adding SAs works fine for me, can you figure out what kind of SA openswan was trying to add? --
Apr 3, 9:52 am 2008
Marco Berizzi
Re: 2.6.25-rc8 regression with openswan
Here is output from ip -s x s and ip -s x p root@Calimero:/var/log# ip -s x s src 85.36.106.213 dst 85.36.106.210 proto esp spi 0xabbf0fe3(2881425379) reqid 16401(0x00004011) mode tunnel replay-window 0 seq 0x00000000 flag (0x00000000) sel src 85.36.106.213/32 dst 85.36.106.210/32 uid 0 lifetime config: limit: soft (INF)(bytes), hard (INF)(bytes) limit: soft (INF)(packets), hard (INF)(packets) expire add: soft 0(sec), hard 30(sec) ...
Apr 3, 7:50 am 2008
Patrick McHardy
Re: 2.6.25-rc8 regression with openswan
I'm not seeing any policies that actually specify IPsec. I'm guessing that is something openswan-specific. Anyway, there haven't been much patches in this area since -rc4, does reverting commit df9dcb458 help? --
Apr 3, 8:06 am 2008
Stefan Roese
[PATCH] ibm_newemac: Add support for 460EX/GT-type MAL rx-ch...
On some 4xx PPC's (e.g. 460EX/GT), the rx channel number is a multiple of 8 (e.g. 8 for EMAC1, 16 for EMAC2), but enabling in MAL_RXCASR needs the divided by 8 value for the bitmask. Signed-off-by: Stefan Roese <sr@denx.de> --- drivers/net/ibm_newemac/mal.c | 16 ++++++++++++++++ 1 files changed, 16 insertions(+), 0 deletions(-) diff --git a/drivers/net/ibm_newemac/mal.c b/drivers/net/ibm_newemac/mal.c index 6869f08..fb9c9eb 100644 --- a/drivers/net/ibm_newemac/mal.c +++ b/drivers/net...
Apr 3, 7:45 am 2008
Benjamin Herrenschmidt
Re: [PATCH] ibm_newemac: Add support for 460EX/GT-type MAL r...
Sounds ok, but I wonder if we ever have a MAL with more than 8 chans, do --
Apr 3, 8:29 am 2008
Stefan Roese
Re: [PATCH] ibm_newemac: Add support for 460EX/GT-type MAL ...
I suggest we postpone such a conditional setup until we see such a MAL. OK? Best regards, Stefan --
Apr 3, 8:35 am 2008
Benjamin Herrenschmidt
Re: [PATCH] ibm_newemac: Add support for 460EX/GT-type MAL ...
Agreed. I got a bit carried away.. Ben. --
Apr 3, 9:10 am 2008
Marco Berizzi Apr 3, 6:01 am 2008
Marco Berizzi
2.6.25-rc8 regression with openswan
Hi everybody, openswan 2.4.12 doesn't work anymore with 2.6.25-rc8: quick mode is failing with this error: ERROR: netlink response for Add SA esp.8a56fa21@1.1.1.1 included errno 93: Protocol not supported I have tried both with des3 and aes but I get always the same error. This is my .config # # Automatically generated make config: don't edit # Linux kernel version: 2.6.25-rc6 # Mon Mar 17 11:15:13 2008 # # CONFIG_64BIT is not set CONFIG_X86_32=y # CONFIG_X86_64 is not set CONFIG_X8...
Apr 3, 5:42 am 2008
Patrick McHardy
Re: 2.6.25-rc8 regression with openswan
What does your policy look like? --
Apr 3, 7:19 am 2008
Beschorner Daniel
Re: Telnet closing delay
> On Tue, May 01, 2007 at 10:48:11PM +0200, Beschorner Daniel It must have been indeed triggered by a kernel change or bug, with current 2.6.24.4 all works fine again. Daniel --
Apr 3, 5:32 am 2008
Evgeniy Polyakov
Re: Telnet closing delay
Hi. I really do not remember what was one year ago, but having a long loop checking closed socket status is wrong. In recent kernels returned error could be changed to something like -EINVAL, which is correctly handled by application, it is impossible to say without caling mind readers, but they are on vacations right now... It can be some obscure kernel bug which was fixed or hidden, but with above description it is hardly possible to tell what is going on. -- Evgeniy Polyakov --
Apr 3, 6:42 am 2008
Beschorner Daniel
Re: Telnet closing delay
> checking closed socket status is wrong. In recent kernels returned No worries, I just wanted to mention for the annals... It's a rather old, but standard distro's, telnet server. Daniel --
Apr 3, 8:04 am 2008
Meelis Roos
Re: [patch] NET: remove support for Davicom 9102 from the Tu...
CE> We have two reports that agree the tulip driver doesn't work for CE> the Davicom 9102 (PCI id 1282:9102). The dmfe driver does work CE> and also claims the same PCI ID. NAK, dmfe does not work on some Sparc64 machines but tulip does. I happent to have a Sun Fire V100 with 2 Davicom NICs (1282:9102 (rev 31)). tulip driver works for them, dmfe doesn't. Tried with 2.6.25-rc7, first it gets MAC addresses all zeroed and second, it only results in Tx timeouts. This issue was debu...
Apr 3, 5:10 am 2008
Jonas Bonn
struct pci_device_id cleanups
In the "net" branch of my repo, there are a series of changesets that modify the definition of struct pci_device_id to use the macro DEFINE_PCI_DEVICE_TABLE. All the changesets in the public tree are one-liners of the type: -static struct pci_device_id myri10ge_pci_tbl[] = { +static DEFINE_PCI_DEVICE_TABLE(myri10ge_pci_tbl) = { ... The change to using this macro has two effects: i) Makes the structure 'const' ii) Puts the structure in section __devinitconst Both these changes are as...
Apr 3, 2:48 am 2008
Stephen Hemminger
[PATCH 1/2] ipv4: fib_trie remove unused argument
The trie pointer is passed down to flush_list and flush_leaf but never used. Signed-off-by: Stephen Hemminger <shemminger@vyatta.com> --- a/net/ipv4/fib_trie.c 2008-04-02 10:55:44.000000000 -0700 +++ b/net/ipv4/fib_trie.c 2008-04-02 11:01:04.000000000 -0700 @@ -1665,7 +1665,7 @@ static int fn_trie_delete(struct fib_tab return 0; } -static int trie_flush_list(struct trie *t, struct list_head *head) +static int trie_flush_list(struct list_head *head) { struct fib_alias *fa, *fa_n...
Apr 3, 12:57 am 2008
Stephen Hemminger
[PATCH 2/2] ipv4: fib_trie leaf free optimization
Avoid unneeded test in the case where object to be freed has to be a leaf. Don't need to use the generic tnode_free() function, instead just setup leaf to be freed. Signed-off-by: Stephen Hemminger <shemminger@vyatta.com> --- a/net/ipv4/fib_trie.c 2008-04-02 10:50:42.000000000 -0700 +++ b/net/ipv4/fib_trie.c 2008-04-02 10:50:43.000000000 -0700 @@ -160,7 +160,6 @@ static void tnode_put_child_reorg(struct static struct node *resize(struct trie *t, struct tnode *tn); static struct tnode *in...
Apr 3, 12:58 am 2008
YOSHIFUJI Hideaki /
[GIT PULL net-2.6.26] [IPV6] MROUTE: Support multicast routi...
Hello. Please consider pulling following changes on top of net-2.6.26 available at: git://git.linux-ipv6.org/gitroot/yoshfuji/linux-2.6-dev.git net-2.6.26-mroute-20080403 The original work of IPv6 multicast forwarding was done by Mickael Hoerdt, et al. Once they asked me to push their work into main-line and after that, several years has passed. I've been tried to contact them these days but I cannot find no response so far. Anyway, their credits are included in the source code. Userspace d...
Apr 2, 10:43 pm 2008
Andy Johnson
Re: [GIT PULL net-2.6.26] [IPV6] MROUTE: Support multicast r...
Hello, Three comments: Hello 1) I downlaoded the mcast-tools git tree. There is no configure script there and no Makefile. How is it to build ? 2) Typo correction: it should be git://git.linux-ipv6.org/gitroot/yoshfuji/mcast-tools.git and not git:/git.linux-ipv6.org/gitroot/yoshfuji/mcast-tools.git 3) I had looked for some info about Multicast Routing; I found Chapter 2 in "IPv6 Advanced Protocols Implementation" book. But it talks about kame project. It talks about Protocol Independent Multicast (PI...
Apr 3, 2:14 am 2008
YOSHIFUJI Hideaki /
Re: [GIT PULL net-2.6.26] [IPV6] MROUTE: Support multicast r...
Make a Linux box a multicast (PIM-SM (SSM), say PIMv2) router. --yoshfuji --
Apr 3, 2:23 am 2008
Andy Johnson
Re: [GIT PULL net-2.6.26] [IPV6] MROUTE: Support multicast r...
Thanks ! Do we have to replace some user space headers so that mcast tools will compile successfully ? I am having this issue: running (on fc7) for mcast-tools: aclocal; automake; autoconf and than ./configure make gives: In file included from /usr/include/linux/mroute.h:5, from mfc.h:41, from mfc.c:32: /usr/include/linux/in.h:26: error: redeclaration of enumerator 'IPPROTO_IP' /usr/include/netinet/in.h:33: error: previous definition of 'IPPROTO_IP' was here /usr/incl...
Apr 3, 3:16 am 2008
YOSHIFUJI Hideaki /
Re: [GIT PULL net-2.6.26] [IPV6] MROUTE: Support multicast r...
Thanks for the report. Not all can be built and pim6sd is the main target so far. --yoshfuji --
Apr 3, 3:31 am 2008
YOSHIFUJI Hideaki /
[RFC net-2.6.26] [IPV6] SIT: ISATAP Updates.
Hello. This updates ISATAP implementation in Linux kernel based on the update from Templin, Fred L <fred.l.templin@boeing.com>. One big question is the "dump" support (4th commit). Since we cannot use copy_to_user family inside the lock, nasty kcalloc() is used inside the lock so far... Patches are also available at git://git.linux-ipv6.org/gitroot/yoshfuji/linux-2.6-dev.git net-2.6.26-isatap-20080403 Regards, --- HEADLINES --------- [IPV6] SIT: Add PRL management for ISA...
Apr 2, 10:38 pm 2008
Mandeep Singh Baines
[PATCH] [ETHTOOL]: Add support for large eeproms
Currently, it is not possible to read/write to an eeprom larger than 128k in size because the buffer used for temporarily storing the eeprom contents is allocated using kmalloc. kmalloc can only allocate a maximum of 128k depending on architecture. Modified ethtool_get/set_eeprom to only allocate a page of memory and then copy the eeprom a page at a time. Signed-off-by: Mandeep Singh Baines <msb@google.com> --- net/core/ethtool.c | 57 ++++++++++++++++++++++++++++----------------------- ...
Apr 2, 10:12 pm 2008
Joe Perches
[PATCH net 2.6.26] net/atm - Use SEQ_START_TOKEN
Signed-off-by: Joe Perches <joe@perches.com> net/atm/lec.c | 8 ++++---- net/atm/proc.c | 16 ++++++++-------- net/atm/resources.c | 5 +++-- 3 files changed, 15 insertions(+), 14 deletions(-) diff --git a/net/atm/lec.c b/net/atm/lec.c index aa3785e..9bd64bd 100644 --- a/net/atm/lec.c +++ b/net/atm/lec.c @@ -1014,7 +1014,7 @@ static void *lec_tbl_walk(struct lec_state *state, struct hlist_head *tbl, if (!e) e = tbl->first; - if (e == (void *)1) { + if (e...
Apr 2, 9:29 pm 2008
Ben Hutchings
Re: [RFC] Change mii_bus id field to a string
I'm not sure why you reformatted this and other comments. If you really think it's necessary to do that, you should probably post a separate patch rather than combining it with this functional change. Ben. -- Ben Hutchings, Senior Software Engineer, Solarflare Communications Not speaking for my employer; that's the marketing department's job. --
Apr 3, 3:26 pm 2008
Andy Fleming
Re: [RFC] Change mii_bus id field to a string
I reformatted them because the coding standards call for them to be formatted differently. I was aware of that when I wrote them, so I'm not sure why I left them like that. I combined them with this patch due to laziness. I'll separate them out when I resubmit. Andy --
Apr 3, 4:19 pm 2008
Greg Ungerer
Re: [PATCH 1/5] fec: kill warnings
Hi Sebastian, I think using normal positive logic would be clearer, eg: HAVE_mii_link_interupt Very few of the boards I have come across with the FEC silicon actually hook up the MII interrupt, so the list of devices that have it will be smaller. Regards -- ------------------------------------------------------------------------ Greg Ungerer -- Chief Software Dude EMAIL: gerg@snapgear.com Secure Computing Corporation PHONE: +61 7 3435 2888 825 Stan...
Apr 3, 2:30 am 2008
Sebastian Siewior Apr 3, 3:44 am 2008
Greg Ungerer
Re: [PATCH 1/5] fec: kill warnings
No, no. It nice for those that do it. Regards Greg ------------------------------------------------------------------------ Greg Ungerer -- Chief Software Dude EMAIL: gerg@snapgear.com SnapGear -- a Secure Computing Company PHONE: +61 7 3435 2888 825 Stanley St, FAX: +61 7 3891 3630 Woolloongabba, QLD, 4102, Australia WEB: http://www.SnapGear.com --
Apr 3, 5:30 am 2008
Greg Ungerer
Re: [PATCH 5/5] m68knommu: dont allocate unused interrupts
Hi Sebastian, After the last discussions on uclinux-dev about this I have a patch virtualy identical to this prepared for inclusion in the 2.6.26 merge window. Regards -- ------------------------------------------------------------------------ Greg Ungerer -- Chief Software Dude EMAIL: gerg@snapgear.com Secure Computing Corporation PHONE: +61 7 3435 2888 825 Stanley St, FAX: +61 7 3891 3630 Woolloongabba, QLD, 4102, Aust...
Apr 3, 2:47 am 2008
Sebastian Siewior
Re: [PATCH 5/5] m68knommu: dont allocate unused interrupts
So you drop this one. Great. That's why I asked you about a devel tree. The latest uclinux patch is linux-2.6.24-uc0.patch.gz which does not contain such a fix. The latest dist snapshot patch is from 2008-03-05 and is about 147 MiB. I took a look at the diffstat (9.67 KB/s) - `uClinux-dist-20070130-20080305.diffstat' saved and yes, there are some modifications to fec.c but 10KiB/sec take me forever. I stared leeching it. The CVS [1] has no linux-2.6 directory. Therefore I assumed that is the latest...
Apr 3, 3:43 am 2008
Greg Ungerer
Re: [PATCH 5/5] m68knommu: dont allocate unused interrupts
I don't keep a quilt series or a git tree currently. I release periodically in the form of the -uc patch series. Regards -- ------------------------------------------------------------------------ Greg Ungerer -- Chief Software Dude EMAIL: gerg@snapgear.com SnapGear -- a Secure Computing Company PHONE: +61 7 3435 2888 825 Stanley St, FAX: +61 7 3891 3630 Woolloongabba, QLD, 4102, Australia WEB: http://www.SnapGear.com -- ...
Apr 3, 5:34 am 2008
Greg Ungerer
Re: [PATCH 0/5] fixup locking on m68knommu fec
Hi Sebastian, Yes, certainly we can. Currently it doesn't. The main sticking point is what to do with the hardware based priority setting logic. We don't really rely on it, but they need to be set to sane values. Need to expand the interrupt controller setup code some more before we can take that out. Regards Greg ------------------------------------------------------------------------ Greg Ungerer -- Chief Software Dude EMAIL: gerg@snapgear.com Secure Computing Corpor...
Apr 3, 2:54 am 2008
previous daytodaynext day
April 2, 2008April 3, 2008April 4, 2008
speck-geostationary