login
Header Space

 
 

Re: [RESEND][NETFILTER][PATCH] nfqnl_mangle() not requesting enough space for bigger reinjected packet.

Score:
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Patrick McHardy <kaber@...>
Cc: Linux Netdev List <netdev@...>, David Miller <davem@...>
Date: Monday, April 28, 2008 - 7:07 pm

Hi,

Patrick McHardy <kaber@trash.net> writes:


Ack.

BTW, while looking at the code, I noticed the call to skb_copy_expand()
leads to a complete copy of current sk_buff data to the new sk_buff.
Those data are then completely rewritten a few lines later. Too bad
there is no simple way (considering skbuff.h) to prevent the useless
copy.

Cheers,

a+

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re: [RESEND][NETFILTER][PATCH] nfqnl_mangle() not requesting..., Arnaud Ebalard, (Mon Apr 28, 7:07 pm)
speck-geostationary