login
Header Space

 
 

[PATCH] r8169: fix panic when using unlisted MAC

Score:
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: <netdev@...>, <romieu@...>
Date: Monday, April 28, 2008 - 1:22 pm

When using the r8169 driver with an unlisted MAC, the system will
panic in rtl8169_get_mac_version since it will try to access tp->pci_dev
when it's unset.  Moving the call to set pci_dev earlier in
rtnl8169_init_one will resolve this and should not introduce any other
problems.

Signed-off-by: Andy Gospodarek <andy@greyhouse.net>

---
 drivers/net/r8169.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/r8169.c b/drivers/net/r8169.c
index 3acfeea..0faa652 100644
--- a/drivers/net/r8169.c
+++ b/drivers/net/r8169.c
@@ -1617,6 +1617,7 @@ rtl8169_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
 	SET_NETDEV_DEV(dev, &pdev->dev);
 	tp = netdev_priv(dev);
 	tp->dev = dev;
+	tp->pci_dev = pdev;
 	tp->msg_enable = netif_msg_init(debug.msg_enable, R8169_MSG_DEFAULT);
 
 	/* enable device (incl. PCI PM wakeup and hotplug setup) */
@@ -1777,7 +1778,6 @@ rtl8169_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
 #endif
 
 	tp->intr_mask = 0xffff;
-	tp->pci_dev = pdev;
 	tp->mmio_addr = ioaddr;
 	tp->align = cfg->align;
 	tp->hw_start = cfg->hw_start;
-- 
1.5.2.1

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH] r8169: fix panic when using unlisted MAC, Andy Gospodarek, (Mon Apr 28, 1:22 pm)
Re: [PATCH] r8169: fix panic when using unlisted MAC, Francois Romieu, (Thu May 1, 4:32 pm)
Re: [PATCH] r8169: fix panic when using unlisted MAC, Andy Gospodarek, (Thu May 1, 5:12 pm)
speck-geostationary