Home » Mailing list archives » linux-netdev » 2008 » April » 28

[2.6 patch] net/ipv4/ip_output.c:ip_send_check() mustn't be inline

Previous thread: [PATCH 3/4] virtio: net: Add ethtool ops for SG/GSO by Rusty Russell on Monday, April 28, 2008 - 8:19 am. (5 messages)

Next thread: [PATCH 6/7] gianfar: Magic Packet and suspend/resume support. by Guennadi Liakhovetski on Monday, April 28, 2008 - 8:40 am. (1 message)
[view original message]
From: Adrian Bunk
Subject: [2.6 patch] net/ipv4/ip_output.c:ip_send_check() mustn't be inline
Date: Monday, April 28, 2008 - 8:38 am

This patch fixes the following build error with UML and gcc 4.3:

<--  snip  -->

...
  CC      net/ipv4/ip_output.o
/home/bunk/linux/kernel-2.6/git/linux-2.6/net/ipv4/ip_output.c: In function ‘__ip_local_out’:
/home/bunk/linux/kernel-2.6/git/linux-2.6/net/ipv4/ip_output.c:89: sorry, unimplemented: inlining failed in call to ‘ip_send_check’: function body not available
/home/bunk/linux/kernel-2.6/git/linux-2.6/net/ipv4/ip_output.c:99: sorry, unimplemented: called from here
make[3]: *** [net/ipv4/ip_output.o] Error 1

<--  snip  -->

Signed-off-by: Adrian Bunk <bunk@kernel.org>

---
936e490777359bfde622148ff5af1e19d8c248b5 diff --git a/net/ipv4/ip_output.c b/net/ipv4/ip_output.c
index 0834926..985a719 100644
--- a/net/ipv4/ip_output.c
+++ b/net/ipv4/ip_output.c
@@ -85,7 +85,7 @@
 int sysctl_ip_default_ttl __read_mostly = IPDEFTTL;
 
 /* Generate a checksum for an outgoing IP datagram. */
-__inline__ void ip_send_check(struct iphdr *iph)
+void ip_send_check(struct iphdr *iph)
 {
 	iph->check = 0;
 	iph->check = ip_fast_csum((unsigned char *)iph, iph->ihl);

--


[ message continues ]
Previous thread: [PATCH 3/4] virtio: net: Add ethtool ops for SG/GSO by Rusty Russell on Monday, April 28, 2008 - 8:19 am. (5 messages)

Next thread: [PATCH 6/7] gianfar: Magic Packet and suspend/resume support. by Guennadi Liakhovetski on Monday, April 28, 2008 - 8:40 am. (1 message)