login
Header Space

 
 

[PATCH 5/6] sis190: remove needless MII reset

Score:
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: <jeff@...>
Cc: <netdev@...>, <akpm@...>
Date: Sunday, April 27, 2008 - 1:05 pm

It does not help the auto-negotiation process to settle.

Added a debug message to give some hindsight when things
do not work as expected.

Signed-off-by: Francois Romieu <romieu@fr.zoreil.com>
---
 drivers/net/sis190.c |    5 ++---
 1 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/net/sis190.c b/drivers/net/sis190.c
index 0b22e75..20f4829 100644
--- a/drivers/net/sis190.c
+++ b/drivers/net/sis190.c
@@ -899,10 +899,9 @@ static void sis190_phy_task(struct work_struct *work)
 		mod_timer(&tp->timer, jiffies + HZ/10);
 	} else if (!(mdio_read_latched(ioaddr, phy_id, MII_BMSR) &
 		     BMSR_ANEGCOMPLETE)) {
-		net_link(tp, KERN_WARNING "%s: PHY reset until link up.\n",
-			 dev->name);
 		netif_carrier_off(dev);
-		mdio_write(ioaddr, phy_id, MII_BMCR, val | BMCR_RESET);
+		net_link(tp, KERN_WARNING "%s: auto-negotiating...\n",
+			 dev->name);
 		mod_timer(&tp->timer, jiffies + SIS190_PHY_TIMEOUT);
 	} else {
 		/* Rejoice ! */
-- 
1.5.3.3

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[RFT 0/6] sis190 branch info, Francois Romieu, (Sun Apr 27, 1:00 pm)
Re: [RFT 0/6] sis190 branch info, Andrew Morton, (Thu May 1, 7:10 pm)
Re: [RFT 0/6] sis190 branch info, Jeff Garzik, (Tue Apr 29, 1:47 am)
[PATCH 6/6] sis190: account for Tx errors, Francois Romieu, (Sun Apr 27, 1:06 pm)
Re: [PATCH 6/6] sis190: account for Tx errors, Andrew Morton, (Thu May 1, 7:16 pm)
[PATCH 5/6] sis190: remove needless MII reset, Francois Romieu, (Sun Apr 27, 1:05 pm)
[PATCH 4/6] sis190: Rx path update, Francois Romieu, (Sun Apr 27, 1:04 pm)
[PATCH 3/6] sis190: use netdev_alloc_skb, Francois Romieu, (Sun Apr 27, 1:03 pm)
[PATCH 2/6] sis190: hard-code the alignment of tiny packets, Francois Romieu, (Sun Apr 27, 1:02 pm)
speck-geostationary