login
Header Space

 
 

[PATCH] asm/unaligned.h doesn't work well as the very first include

Previous thread: [PATCH net-2.6/stable] [XFRM] AUDIT: Fix flowlabel text format. by YOSHIFUJI Hideaki / on Saturday, April 26, 2008 - 11:24 pm. (7 messages)

Next thread: [PATCH] result of csum_fold() is already 16bit, no need to cast by Al Viro on Sunday, April 27, 2008 - 1:27 am. (2 messages)
To: David Miller <davem@...>
Cc: <netdev@...>, <linux-kernel@...>, Linus Torvalds <torvalds@...>
Date: Sunday, April 27, 2008 - 1:19 am

Signed-off-by: Al Viro &lt;viro@zeniv.linux.org.uk&gt;
---
 net/mac80211/mesh.h      |    1 +
 net/mac80211/mesh_hwmp.c |    1 -
 2 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/net/mac80211/mesh.h b/net/mac80211/mesh.h
index 742003d..9ee3aff 100644
--- a/net/mac80211/mesh.h
+++ b/net/mac80211/mesh.h
@@ -13,6 +13,7 @@
 
 #include &lt;linux/types.h&gt;
 #include &lt;linux/jhash.h&gt;
+#include &lt;asm/unaligned.h&gt;
 #include "ieee80211_i.h"
 
 
diff --git a/net/mac80211/mesh_hwmp.c b/net/mac80211/mesh_hwmp.c
index 02de8f1..3df8092 100644
--- a/net/mac80211/mesh_hwmp.c
+++ b/net/mac80211/mesh_hwmp.c
@@ -7,7 +7,6 @@
  * published by the Free Software Foundation.
  */
 
-#include &lt;asm/unaligned.h&gt;
 #include "mesh.h"
 
 #define TEST_FRAME_LEN	8192
-- 
1.5.3.GIT

--
To: Al Viro <viro@...>
Cc: David Miller <davem@...>, <netdev@...>, <linux-kernel@...>, Linus Torvalds <torvalds@...>
Date: Sunday, April 27, 2008 - 2:09 am

It has been discussed that any .h file should pull
in what it needs so the other of includes does not matter.
Some do them alphabetically.

Why not fix asm-*/unaligned.h so all users now and future
are fixed in one shot?

	Sam
--
To: Sam Ravnborg <sam@...>
Cc: David Miller <davem@...>, <netdev@...>, <linux-kernel@...>, Linus Torvalds <torvalds@...>
Date: Sunday, April 27, 2008 - 2:12 am

It has been discussed or it has been agreed?  IMO it's a bullshit - especially
for low-level stuff like that.

As for the way some do includes...  It's not exactly a family-friendly list,
but still I'd rather not comment in details on the existing practices...
--
To: Al Viro <viro@...>
Cc: Sam Ravnborg <sam@...>, David Miller <davem@...>, <netdev@...>, <linux-kernel@...>, Linus Torvalds <torvalds@...>
Date: Sunday, April 27, 2008 - 2:31 am

I'm redoing the unaligned handling in -mm at the moment, and it avoids
this problem.

Harvey

--
To: <viro@...>
Cc: <netdev@...>, <linux-kernel@...>, <torvalds@...>
Date: Sunday, April 27, 2008 - 1:21 am

From: Al Viro &lt;viro@ZenIV.linux.org.uk&gt;

Patch applied, thanks a lot Al.
--
Previous thread: [PATCH net-2.6/stable] [XFRM] AUDIT: Fix flowlabel text format. by YOSHIFUJI Hideaki / on Saturday, April 26, 2008 - 11:24 pm. (7 messages)

Next thread: [PATCH] result of csum_fold() is already 16bit, no need to cast by Al Viro on Sunday, April 27, 2008 - 1:27 am. (2 messages)
speck-geostationary