In article <OF326F3AF9.7322F5FB-ON88257437.00174874-88257437.00194F7B@us.ibm.com> (at Fri, 25 Apr 2008 21:36:29 -0700), David Stevens <dlstevens@us.ibm.com> says:

quoted text
> > net/compat.c is not the right place.
> > Please put this in net/ipv4/compat.c or so.
> > Or at least, these must be guarded by CONFIG_INET.
> 
>         This code is for both v4 and v6, so I'd rather it not be in
> net/ipv4/compat.c. I didn't try without CONFIG_INET, -- will look
> at that.

We've been putting ipv4/ipv6 common things in net/ipv4/*.c,
so please put it in net/ipv4/compat.c.

quoted text
> > > +struct compat_group_filter {
> > > +       __u32                            gf_interface;
> > > +       struct __kernel_sockaddr_storage gf_group
> > > +               __attribute__ ((aligned(4)));
> > > +       __u32                            gf_fmode;
> > > +       __u32                            gf_numsrc;
> > > +       struct __kernel_sockaddr_storage gf_slist[1]
> > > +               __attribute__ ((aligned(4)));
> > > +} __attribute__ ((packed));
> > > +
> > 
> > include/linux/in.n.
> 
>         I don't understand this comment. If you're suggesting I
> put these in an include file, I didn't because this is the only
> file that uses them and I don't want them to be visible to any
> other code. If you mean something else, please explain.

We put most (if not all) compat structures in headers.
Sparse definitions are not good.

--yoshfuji

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html