login
Header Space

 
 

mac80211/wme.c: check-after-use

Score:
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Ron Rindjunsky <ron.rindjunsky@...>, John W. Linville <linville@...>
Cc: <linux-wireless@...>, <netdev@...>, <linux-kernel@...>
Date: Wednesday, April 23, 2008 - 5:51 am

The Coverity checker spotted the following check-after-use of the 
"qdisc" variable in net/mac80211/wme.c introduced by
commit 9e7234923789897858e1a475c579b5e2e6ad5b74
(mac80211: A-MPDU Tx adding qdisc support):

<--  snip  -->

...
void ieee80211_requeue(struct ieee80211_local *local, int queue)
{
        struct Qdisc *root_qd = local->mdev->qdisc_sleeping;
        struct ieee80211_sched_data *q = qdisc_priv(root_qd);
        struct Qdisc *qdisc = q->queues[queue];
        struct sk_buff *skb = NULL;
        u32 len = qdisc->q.qlen;    <------

        if (!qdisc || !qdisc->dequeue)
                return;
...

<--  snip  -->

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
mac80211/wme.c: check-after-use, Adrian Bunk, (Wed Apr 23, 5:51 am)
RE: mac80211/wme.c: check-after-use, Rindjunsky, Ron, (Wed Apr 23, 6:20 am)
speck-geostationary