Commit 9d9326d3bc0ea9a8bbe40bf3e5e66c7b9858caa0 (phy: Change mii_bus id field to a string) causes the following compile error: <-- snip --> ... CC drivers/net/ucc_geth.o /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/net/ucc_geth.c: In function 'ucc_geth_startup': /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/net/ucc_geth.c:2605: warning: assignment makes integer from pointer without a cast /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/net/ucc_geth.c:2642: warning: assi...

This is a request for comments patch to add support for the tcindex classifier to libnl. It lacks support for the police and action attributes and the dump callbacks aren't implementend since I don't know what to output exactly on each one. Please comment. Thanks, Rui --

[ That email should have had this text ] This is a request for comments patch to add support for the tcindex classifier to libnl. It lacks support for the police and action attributes and the dump callbacks aren't implementend since I don't know what to output exactly on each one. Please comment. Thanks, Rui --

Hello all. Sorry if its not bug. look to section "IP: Netfilter Configuration" in .config i see values like this: CONFIG_NF_NAT_PROTO_GRE=m but in menuconfig i can find it in this section ("network->Network packet filtering framework->IP: Netfilter Configuration"). its blackhole? =) I attach my config. Thanks all

I understand. This values are hidden. And get values from "default NF_NAT && NF_CONNTRACK_PPTP" if "user not set this values". But my config have this values from older config version (make menuconfig) and not set it again that i change NF_CONNTRACK_PPTP to Y/N. Also if i one time save config - it write value of hidden param (i say about CONFIG_NF_NAT_PPTP now). Have i chance to reconfig this value if menuconfig set it 1 time for me? --

From: Herbert Xu <herbert@gondor.apana.org.au> Please update your GIT index :-) --

From: Valentine Barshak <vbarshak@ru.mvista.com> The PowerPC 440GX Taishan board fails to reset EMAC3 (reset timeout error) if there's no link. Because of that it fails to find PHY chip. The older ibm_emac driver had a workaround for that: the EMAC_CLK_INTERNAL/EMAC_CLK_EXTERNAL macros, which toggle the Ethernet Clock Select bit in the SDR0_MFR register. This patch does the same for "ibm,emac-440gx" compatible chips. The workaround forces clock on -all- EMACs, so we select clock under global e...

From: Josh Boyer <jwboyer@linux.vnet.ibm.com> Convert ibm_newemac to use the of_device_is_available function when checking for unused/unwired EMACs. We leave the current check for an "unused" property to maintain backwards compatibility for older device trees. Newer device trees should simply use the standard "status" property in the EMAC node. Signed-off-by: Josh Boyer <jwboyer@linux.vnet.ibm.com> Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org> --- driver...

From: Stefan Roese <sr@denx.de> On some 4xx PPC's (e.g. 460EX/GT), the rx channel number is a multiple of 8 (e.g. 8 for EMAC1, 16 for EMAC2), but enabling in MAL_RXCASR needs the divided by 8 value for the bitmask. Signed-off-by: Stefan Roese <sr@denx.de> Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org> --- drivers/net/ibm_newemac/mal.c | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/drivers/net/ibm_newemac/mal.c b/drivers/net/ibm_ne...

I think it is better to add rtnl_lock() here to prevent racing with other functions such as ethtool and close that can be resetting the Shouldn't we attach first before netif_start? Thanks. --

I think it doesn't make a whole lot of difference either way, especially if you hold the rtnl_lock(). But in the normal course of loading the driver, the LINK_STATE_PRESENT bit gets set during ->probe() when the driver calls register_netdev(). So it is attached before ->open(). --

From: Rusty Russell <rusty@rustcorp.com.au> To be honest I have no idea. When Alexey added the TSO changeset way back then, it had the "+2", from the history-2.6 tree: commit 80223d5186f73bf42a7e260c66c9cb9f7d8ec9cf Author: Alexey Kuznetsov <kuznet@ms2.inr.ac.ru> Date: Wed Aug 28 11:52:03 2002 -0700 [NET]: Add TCP segmentation offload core infrastructure. ... diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h index a812681..9b6e6ad 100644 --- a/include/linux...

It is human nature to blame someone/something when things go wrong. It just happens that the lack of a merge request was the first you tacked onto in this case :) I don't think we can seriously argue that had there been a merge request on lkml that these build issues would have somehow gone away or resolved any sooner than they have been. The fact is with or without the merge request you would have realised that Unfortunately the email medium tends to make what one thinks of as a neutral and ...

From: YOSHIFUJI Hideaki / 吉藤英明 <yoshfuji@linux-ipv6.org> I'll apply and push this change, thank you. --

this is exaclty what the userspace irqbalance does and it's even optimized to not do those migrations once every 10 seconds if things look OK. from that perspective, it's definately more mature and it's maintained as well. Auke --

Ah, so this bug isn't actually caused by a patch but rather by a different config option. I think we can't do much about it, currently. The device has strange memory requirements and changing the split does actually break it. This cannot be fixed until andi kleen's mask-allocator is merged. -- Greetings Michael. --

Incremental patch. - remove not needed variable initializations - remove hso_net_get_stats, because by default identical internal_stats function from net/core/dev.c is used. - remove not needed memset(hso_net, 0, sizeof(*hso_net)), because memory is allocated with kzalloc

Correct. And we don't support DHCP. Filip- --

I think we're thinking of a different pair of drivers... I thought you were talking about duplicating drivers/net/phy/mdio-bitbang.c, not drivers/net/fs_enet/mii-bitbang.c. -Scott --

The only reason I can see for that would be if the gpiolib version doesn't work on arch/ppc -- but that's not going to be a problem for very If mii-bitbang is only used on arch/ppc, then #ifdef CONFIG_PPC_MERGE should do it. It'd be nice to be able to give phylib an OF node rather than a string, though... -Scott --

That was when I thought you were talking about changing drivers/net/phy/mdio-bitbang.c. ep8248e doesn't use I meant as an option, not the only way to specify it. -Scott --

Since you're changing the default setting, shouldn't the above be changed to: Saying yes will allow the kernel to do irq load balancing. -Bill --

On Mon, 21 Apr 2008 00:55:00 +0400 Alexey, can you please try this (very minimally tested) patch? diff --git a/drivers/net/atlx/atl1.c b/drivers/net/atlx/atl1.c index 5586fc6..07fe5c0 100644 --- a/drivers/net/atlx/atl1.c +++ b/drivers/net/atlx/atl1.c @@ -1115,9 +1115,6 @@ static void atl1_free_ring_resources(struct atl1_adapter *adapter) struct atl1_rrd_ring *rrd_ring = &adapter->rrd_ring; struct atl1_ring_header *ring_header = &adapter->ring_header; - atl1_clean_tx_ring(ad...

This was a conversation I had late last year on the list regarding TSO and Tx checksum offload not getting turned on for VLAN devices, since the VLAN device creation code doesn't copy those device feature flags. I had proposed sending a patch, and the statement was made that some devices might not support both of those hardware features at the same I hear you loud and clear. I wanted to do this the "right" way in the drivers if I couldn't do it in the kernel, and your suggestions sound like the ...

I mean that what we are currently discussing (only priorities) is in itself useful ("works half"). Adding more features (expiry times) would be a nice but non essential feature ("work full"). That is an important question. But I'm afraid the answer is no (even though I thought otherwise when writing previous mail). When we want to add packet expiry times we will need a field for timestamp. Which is quite big (64 bits?). But note that it is only needed for in-kernel implemetation. Userspace ca...