On Tuesday 22 April 2008 17:08, Scott Wood wrote:
quoted text
> On Tue, Apr 22, 2008 at 10:55:06AM +0200, Laurent Pinchart wrote:
> > On Monday 21 April 2008 19:56, Scott Wood wrote:
> > > The memory-constrained platform I had in mind was 8xx, which doesn't =
use
quoted text
> > > bitbanged MDIO.  It might nice to keep the gpiolib bit separate to av=
oid
quoted text
> > > situations such as ep8248e where mdiobb would be the only thing
> > > requiring a gpiolib binding, though -- but it shouldn't be two separa=
te
quoted text
> > > bitbang drivers, just the existing bitbang driver plus some glue code
> > > that binds it to gpiolib.
> >=20
> > I would be fine with that if the glue code wasn't 90% of the whole driv=
er.=20
quoted text
> > There is really little (not to say nothing) that can be shared between =
the=20
quoted text
> > two drivers.
>=20
> I think we're thinking of a different pair of drivers...  I thought you
> were talking about duplicating drivers/net/phy/mdio-bitbang.c, not
> drivers/net/fs_enet/mii-bitbang.c.

I don't plan to touch drivers/net/phy/mdio-bitbang.c at all, it does its jo=
b=20
well enough.

As the openfirmware + gpio + mdio driver might benefit non-powerpc platform=
s,=20
I plan to create a new driver (probably drivers/net/phy/mdio-ofgpio.c) that=
=20
mostly ports drivers/net/fs_enet/mii-bitbang.c to the gpiolib (this replace=
s=20
around 90% of the code).

If both drivers/net/fs_enet/mii-bitbang.c and drivers/net/phy/mdio-ofgpio.c=
=20
must live together, I'll have a problem in=20
drivers/net/fs_enet/fs_enet-main.c. The net device probing code searches th=
e=20
device tree for an associated PHY, and creates a PHY id from the PHY node. =
As=20
the id will be generated from different bus ids in the two mdio drivers (th=
e=20
bus number is the register address for drivers/net/fs_enet/mii-bitbang.c, a=
nd=20
is the gpio index for drivers/net/phy/mdio-ofgpio.c), things will break.

Any idea regarding how to get rid of that fs_enet/mii-bitbang hardcoded=20
dependency ?

=2D-=20
Laurent Pinchart
CSE Semaphore Belgium

Chaussee de Bruxelles, 732A
B-1410 Waterloo
Belgium

T +32 (2) 387 42 59
=46 +32 (2) 387 42 75