login
Login / Register
Header Space

 
 

Home » Mailing list archives » linux-netdev » 2008 » April » 2

[PATCH 3/3] sc92031: use netdev_alloc_skb

Score:
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Stephen Hemminger <shemminger@...>
To: Stephen Hemminger <shemminger@...>, Jeff Garzik <jgarzik@...>, Cesar Eduardo Barros <cesarb@...>
Cc: <netdev@...>, <tom@...>
Subject: [PATCH 3/3] sc92031: use netdev_alloc_skb
Date: Wednesday, April 2, 2008 - 1:13 pm

Use netdev_alloc_skb since it handles any NUMA node memory localtion issues
and sets skb->dev. Since device driver was not setting skb->dev, I bet
filter rules based on device would not work.

Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>

--- a/drivers/net/sc92031.c	2008-04-02 10:03:00.000000000 -0700
+++ b/drivers/net/sc92031.c	2008-04-02 10:03:04.000000000 -0700
@@ -796,7 +796,7 @@ static void _sc92031_rx_tasklet(struct n
 
 		rx_len -= rx_size_align + 4;
 
-		skb = dev_alloc_skb(pkt_size + NET_IP_ALIGN);
+		skb = netdev_alloc_skb(dev, pkt_size + NET_IP_ALIGN);
 		if (unlikely(!skb)) {
 			if (printk_ratelimit())
 				printk(KERN_ERR "%s: Couldn't allocate a skb_buff for a packet of size %u\n",
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
Re: [Bugme-new] [Bug 10380] New: sc92031 does not create a d..., Andrew Morton, (Wed Apr 2, 12:14 pm)
Re: [Bugme-new] [Bug 10380] New: sc92031 does not create a d..., Stephen Hemminger, (Wed Apr 2, 12:49 pm)
Re: [Bugme-new] [Bug 10380] New: sc92031 does not create a d..., Thomas Scheiblauer, (Wed Apr 2, 1:08 pm)
[PATCH 3/3] sc92031: use netdev_alloc_skb, Stephen Hemminger, (Wed Apr 2, 1:13 pm)
[PATCH 2/3] sc92031: start transmit return value bugfix, Stephen Hemminger, (Wed Apr 2, 1:11 pm)
[PATCH 1/3] sc92031: use net_device stats, Stephen Hemminger, (Wed Apr 2, 1:11 pm)
Re: [PATCH 1/3] sc92031: use net_device stats, Jeff Garzik, (Sat Apr 12, 5:02 am)
[PATCH 1/3] sc92031: use net_device stats, Stephen Hemminger, (Wed Apr 2, 1:08 pm)
[PATCH] sc92031: sysfs link missing, Stephen Hemminger, (Wed Apr 2, 12:39 pm)
Re: [PATCH] sc92031: sysfs link missing, Jeff Garzik, (Fri Apr 4, 1:46 am)
Re: [PATCH] sc92031: sysfs link missing, Andrew Morton, (Fri Apr 4, 1:52 am)
Re: [PATCH] sc92031: sysfs link missing, Jeff Garzik, (Fri Apr 4, 2:40 am)

Mail archive search
Enter your search terms.
Optionally limit your search to a specific mailing list.
advanced
Recent Tags
more tags
Colocation donated by:
Who's online
There are currently 1 user and 1179 guests online.

Online users

Syndicate
Syndicate content
© 2007 KernelTrap.  |  Powered by Drupal.  |  Legal statement.
speck-geostationary