* prefer passing data to irq handler using 'void *dev_id' argument * remove references to 'irq' function arg that either duplicate a member of our private struct, or are always [true|false]. * add linux/interrupt.h include where needed This change's main purpose is to prepare for the patchset in jgarzik/misc-2.6.git#irq-remove, that explores removal of the never-used 'irq' argument in each interrupt handler. Signed-off-by: Jeff Garzik <jgarzik@redhat.com> --- drivers/atm/ambassador...

OK to send this upstream to Linus? It's been in various -mm's, though I don't know the current state of akpm's pull of jgarzik/misc-2.6.git#ALL. The changes should produce equivalent results, and are strictly internal cleanups in preparation for the PCI hotplug API conversion patchset, which exists in branch #isdn-pci. The 'isdn-cleanups' branch of master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/misc-2.6.git isdn-cleanups contains the following updates: drivers/isdn/hisax/asuscom.c...

Sometimes the specific interaction between the platform and the PHY requires special handling. For instance, to change where the PHY's clock input is, or to add a delay to account for latency issues in the data path. We add a mechanism for registering a callback with the PHY Lib to be called on matching PHYs when they are brought up, or reset. Signed-off-by: Andy Fleming <afleming@freescale.com> --- Documentation/networking/phy.txt | 38 +++++++++++- drivers/net/phy/mdio_bus.c | ...

From: Alan Cox <alan@lxorguk.ukuu.org.uk> Only a few ISA controllers need the pausing version of the 8390 core while PCMCIA, later ISA and PCI do not. More importantly the ISA delays can break non ISA boxes so we must use a different build of 8390.c for the two sets of controllers. No changes since last time as all the points of concerns raised proved to be invalid [randy.dunlap@oracle.com: ne2 (MCA) needs both 8390.o and 8390p.o functions] Signed-off-by: Alan Cox <alan@redhat.com>...

From: Roel Kluin <12o3l@tiscali.nl> When timeout reaches 0 the postfix decrement still subtracts, so the test fails. [akpm@linux-foundation.org: coding-style fixes] Signed-off-by: Roel Kluin <12o3l@tiscali.nl> Acked-by: Peter Korsgaard <jacmet@sunsite.dk> Cc: Jeff Garzik <jeff@garzik.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> --- drivers/net/smc911x.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff -puN drivers/net/smc9...

From: Stephen Hemminger <shemminger@vyatta.com> Statistics structure is available for use in net_device structure. Compile tested only. Signed-off-by: Stephen Hemminger <shemminger@vyatta.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> --- drivers/net/sc92031.c | 70 +++++++++++++++++++--------------------- 1 file changed, 34 insertions(+), 36 deletions(-) diff -puN drivers/net/sc92031.c~sc92031-use-net_device-stats drivers/net/sc92031.c --- a/drivers/net...

From: Dan Nicholson <dbn.lists@gmail.com> Check if the link is available when a changed interrupt has been received and set the carrier status appropriately. The code is copied nearly verbatim from the dl2k module. The link status could be used in more places in the driver, but this is enough to get the carrier status reported to userspace. Fixes kernel bug #7487: http://bugzilla.kernel.org/show_bug.cgi?id=7487 [akpm@linux-foundation.org: coding-style fixes] Signed-off-by: Dan Nic...

From: Bjorn Helgaas <bjorn.helgaas@hp.com> Wrap PNP probe code in #ifdef CONFIG_PNP. Without this change, we'll have unresolved references to pnp_get_resource() function when CONFIG_PNP=n. (This is a new interface that's not in mainline yet.) Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com> Cc: Stephen Rothwell <sfr@canb.auug.org.au> Cc: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com> Cc: Samuel Ortiz <samuel@sortiz.org> Signed-off-by: Andrew Morton <akpm@l...

From: Pavel Machek <pavel@ucw.cz> hci_usb: do not initialize static variables to 0. Signed-off-by: Pavel Machek <pavel@suse.cz> Cc: Marcel Holtmann <marcel@holtmann.org> Cc: Dave Young <hidave.darkstar@gmail.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> --- drivers/bluetooth/hci_usb.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff -puN drivers/bluetooth/hci_usb.c~hci_usb-do-not-initialize-static-variables-to-0 drive...

From: Pavel Machek <pavel@ucw.cz> If someone tries to _urb_unlink while _urb_queue_head is running, he'll see _urb->queue == NULL and fail to do any locking. Prevent that from happening by strategically placed barriers. Signed-off-by: Pavel Machek <pavel@suse.cz> Cc: Marcel Holtmann <marcel@holtmann.org> Cc: Dave Young <hidave.darkstar@gmail.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> --- drivers/bluetooth/hci_usb.h | 21 +++++++++++++----...

On Fri, 18 Apr 2008 23:10:12 +0200 ok... But as long as the old code is buildable and installable, we should fix bugs in it? --

From: Pavel Machek <pavel@ucw.cz> _urb_free is an alias for kfree... making code longer & harder to read. Remove it. Signed-off-by: Pavel Machek <pavel@suse.cz> Cc: Marcel Holtmann <marcel@holtmann.org> Cc: Dave Young <hidave.darkstar@gmail.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> --- drivers/bluetooth/hci_usb.c | 10 +++++----- drivers/bluetooth/hci_usb.h | 5 ----- 2 files changed, 5 insertions(+), 10 deletions(-) diff -puN dr...

It currently corrupts memory (use after free) during suspend, and I'm trying to get that fixed. It is 90% reproducible. And yes, fixing clean code is easier. It could be easily fixed by just not freeing the urbs during disconnect (introducing very very slow memory leak). Would that be acceptable? Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html --

From: akpm@linux-foundation.org This patch went through Jeff's tree and I rejected it because it's not the right way to solve this problem and it gives us a 3rd implementation of PPP protocol handling in the tree which makes even less sense. Please drop, thanks Andrew. --

From: Julia Lawall <julia@diku.dk> The functions time_before, time_before_eq, time_after, and time_after_eq are more robust for comparing jiffies against other values. A simplified version of the semantic patch making this change is as follows: (http://www.emn.fr/x-info/coccinelle/) // <smpl> @ change_compare_np @ expression E; @@ ( - jiffies <= E + time_before_eq(jiffies,E) | - jiffies >= E + time_after_eq(jiffies,E) | - jiffies < E + time_before(jiffies,E) | ...

From: Alexey Dobriyan <adobriyan@parallels.com> Thanks for finding and fixing this regression. Patch applied. --

In message <1208530262-8555-1-git-send-email-mark.asselstine@windriver.com>,Mar this patch should probably go one step farther and just remove these spin_lock wrappers as well. most people consider this bad form. --

We generally prefer the form: spin_lock_irqsave(&card->res_lock, flags); The brackets aren't needed and since they aren't used elsewhere in the kernel, breaking the pattern makes it look like these are somehow different (which they aren't). -- Intel are signing my paycheques ... these opinions are still mine "Bill, look, we understand that you're interested in selling us this operating system, but compare it to ours. We can't possibly take such a retrograde step." --

As RFC3542 mentions: An attempt to set IPV6_CHECKSUM for an ICMPv6 socket will fail. Add a check for that in do_rawv6_setsockopt(). Signed-off-by: Wang Chen <wangchen@cn.fujitsu.com> --- net/ipv6/raw.c | 5 +++++ 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/net/ipv6/raw.c b/net/ipv6/raw.c index 0a6fbc1..c4cc1f9 100644 --- a/net/ipv6/raw.c +++ b/net/ipv6/raw.c @@ -994,6 +994,11 @@ static int do_rawv6_setsockopt(struct sock *sk, int level, int optname, switch (o...

There was a missing newline in a dev_dbg() message. Values read from/written into PHY registers might be for interest too, so I added new dbg messages there. Signed-off-by: Enrico Scholz <enrico.scholz@sigma-chemnitz.de> --- drivers/net/dm9000.c | 5 ++++- 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/drivers/net/dm9000.c b/drivers/net/dm9000.c index 7bc16d2..e4af7a9 100644 --- a/drivers/net/dm9000.c +++ b/drivers/net/dm9000.c @@ -525,7 +525,7 @@ dm9000_probe(struct...

This patch adds a fill_ether_addr() method to the DM9000 platform data which can be used to fill in the MAC address in a platform specific manner (e.g. calculate it out of the serial number). This method will be called only, when MAC was not set previously (e.g. by bootloader) or can be read out of the EEPROM. Having a valid MAC address in early bootstage is necessary e.g. for booting from network. Signed-off-by: Enrico Scholz <enrico.scholz@sigma-chemnitz.de> --- drivers/net/dm9000.c ...

There were missing __dev* annotations for the dm9000_probe() and dm9000_drv_remove() functions. Signed-off-by: Enrico Scholz <enrico.scholz@sigma-chemnitz.de> --- drivers/net/dm9000.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/dm9000.c b/drivers/net/dm9000.c index e668b37..7bc16d2 100644 --- a/drivers/net/dm9000.c +++ b/drivers/net/dm9000.c @@ -503,7 +503,7 @@ dm9000_release_board(struct platform_device *pdev, struct board_info *db) /* ...

kvm (and lguest!) want to get more speed out of the tun device. We already have an ABI for guest<->host comms, called virtio_ring; extending tun to understand this (with its async nature and batching) make for an efficient network. But moreover: the same things that make virtio a good guest<->host transport make it appealing as a userspace<->kernel transport. So rather than do something just for tun, we create a /dev/vring. We could do a system call, but /dev/vring is suf...

virtio introduced a ring structure ABI for guest-host communications (currently used by lguest and kvm). Using this same ABI, we can create a nice fd version. This is useful for efficiently passing packets to and from the tun, for example. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> --- drivers/char/Kconfig | 9 + drivers/char/Makefile | 2 drivers/char/vring.c | 400 ++++++++++++++++++++++++++++++++++++++++++++++++++ include/linux/vring.h | 58 +++++++ 4 files ch...

An excellent question, but I thought the modern kernel etiquette was to only comment on whitespace and formatting, and call it "review"? :) Yes, kinda-sorta in that it's a ring buffer. No, in that it's bidir and consumption can be out-of-order (kind of important for I/O buffers). But the reason I'm not proposing it as a syscall is that I'm not convinced it's the One True Solution which everyone should be using. Time will tell: it's clearly not tied to tun and it's been generically useful...