Hi Andrew,

quoted text
> hci_usb: do not initialize static variables to 0.
>
> Signed-off-by: Pavel Machek <pavel@suse.cz>
> Cc: Marcel Holtmann <marcel@holtmann.org>
> Cc: Dave Young <hidave.darkstar@gmail.com>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> ---
>
> drivers/bluetooth/hci_usb.c |   14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff -puN drivers/bluetooth/hci_usb.c~hci_usb-do-not-initialize- 
> static-variables-to-0 drivers/bluetooth/hci_usb.c
> --- a/drivers/bluetooth/hci_usb.c~hci_usb-do-not-initialize-static- 
> variables-to-0
> +++ a/drivers/bluetooth/hci_usb.c
> @@ -62,13 +62,13 @@
> #define URB_ZERO_PACKET 0
> #endif
>
> -static int ignore = 0;
> -static int ignore_dga = 0;
> -static int ignore_csr = 0;
> -static int ignore_sniffer = 0;
> -static int disable_scofix = 0;
> -static int force_scofix = 0;
> -static int reset = 0;
> +static int ignore;
> +static int ignore_dga;
> +static int ignore_csr;
> +static int ignore_sniffer;
> +static int disable_scofix;
> +static int force_scofix;
> +static int reset;

I know that some people don't like to do it and I agree, but in case  
of module parameters, I prefer to have them clearly indicate what the  
default value is. It is a lot easier to read for other people looking  
at the code. So that one is a NAK from my side.

Regards

Marcel

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html