From: Allan Stephens <allan.stephens@windriver.com>
Date: Tue, 15 Apr 2008 15:43:51 -0400

quoted text
> @@ -104,7 +135,7 @@ int tipc_ref_table_init(u32 requested_size, u32 start)
>  
>  void tipc_ref_table_stop(void)
>  {
> -	if (!tipc_ref_table.entries)
> +	if (unlikely(tipc_ref_table.entries == NULL))
>  		return;

Please don't mix gratuitous coding style changes with functional
changes.  It makes auditing and review harder.

And in this case I prefer the more concise "!ptr".

It also could be argued that this isn't a fast path and thus
the likely/unlikely tags are not only unnecessary, but also
likely to result in code bloat for no real gain.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html