login
Header Space

 
 

[PATCH net-2.6.26] [IPV6] Return NET_RX_DROP when a packet is dropped in ipv6_rcv().

Previous thread: [PATCH 1/1 net-2.6.26] [XFRM]: Compilation warnings in xfrm_user.c. by Denis V. Lunev on Monday, April 14, 2008 - 9:03 am. (5 messages)

Next thread: DM9000: Add timer to check PHY status by Ben Dooks on Monday, April 14, 2008 - 9:57 am. (1 message)
To: YOSHIFUJI Hideaki / 吉藤英明 <yoshfuji@...>
Cc: David Miller <davem@...>, <netdev@...>, <linux-kernel@...>
Date: Monday, April 14, 2008 - 9:15 am

Hi,
- The IPv6 handler for receiving packets is ipv6_rcv() in net/ipv6/ip6_input.c.
It is called by netif_receive_skb() (net/core/dev.c)
According to the documentation, the return value of netif_receive_skb() should
be NET_RX_DROP when the packet is dropped; though this return value
is usually not used (except maybe for congestion), this patch fixes the
ipv6_rcv() to return NET_RX_DROP when the packet is dropped (note that
NET_RX_DROP value **is not** 0 but 1; NET_RX_SUCCESS value is in fact	0).


Regards,
Rami Rosen


Signed-off-by: Rami Rosen &lt;ramirose@gmail.com&gt;
To: <ramirose@...>
Cc: <davem@...>, <netdev@...>, <linux-kernel@...>, <yoshfuji@...>
Date: Monday, April 14, 2008 - 9:52 am

Well yes, and I think we should fix other paths as well, right?
So, I'm going to defer this for now.

--yoshfuji
--
Previous thread: [PATCH 1/1 net-2.6.26] [XFRM]: Compilation warnings in xfrm_user.c. by Denis V. Lunev on Monday, April 14, 2008 - 9:03 am. (5 messages)

Next thread: DM9000: Add timer to check PHY status by Ben Dooks on Monday, April 14, 2008 - 9:57 am. (1 message)
speck-geostationary