On Sun, 13 Apr 2008, Andy Furniss wrote:I'm not completely sure I understand how you end up with a negative overhead. But I guess what you are saying, is that you need to remove the MAC header from the equation is it has already been added to skb->len (as you are doing routed and not bridged AAL5 encap). That makes a good point for a _seperate_ patch (by you ;-)) where we change the overhead to be signed. Or else you can do a userspace TC patch that abuse the cell_align, as you mentioned below, to express a negative overhead. (I'm trying to say, lets not mix these things... please!) Yes, the tables has been aligned to 2^n and avoids underestimation. Thus, with upto 2^4 (16) the table aligns to 48 bytes (ATM cell payload size), standard TC uses 2^3. (If I remember correctly you, did comment on the patch so you must have read it ;-)). Yes, its nice that we have added this kind of flexibility to the kernel... I don't think so, but I'm not sure about that... I think it was way too complex, which will make it difficult to maintain in the future. Cheers, Jesper Brouer ps. I'm currently on a roadtrip down the west-coast of USA, so I only have periodic wifi coverage at different campgrounds... -- ------------------------------------------------------------------- MSc. Master of Computer Science Dept. of Computer Science, University of Copenhagen Author of http://www.adsl-optimizer.dk ------------------------------------------------------------------- -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
| Greg Kroah-Hartman | [PATCH 012/196] nozomi driver |
| Ingo Molnar | Re: [patch 00/13] Syslets, "Threadlets", generic AIO support, v3 |
| Rafael J. Wysocki | [PATCH -mm 5/6] Freezer: Remove PF_NOFREEZE from bluetooth threads |
| Ingo Molnar | Re: [PATCH 00/23] per device dirty throttling -v8 |
git: | |
| David Miller | [GIT]: Networking |
| David Miller | Re: [PATCH] pkt_sched: Destroy gen estimators under rtnl_lock(). |
| Gerrit Renker | [PATCH 15/37] dccp: Set per-connection CCIDs via socket options |
| Natalie Protasevich | [BUG] New Kernel Bugs |
