login
Header Space

 
 

Re: 2.6.25-rc9: Reported regressions from 2.6.24

Previous thread: UFO csum - udp4_hwcsum_outgoing by Kostya B on Sunday, April 13, 2008 - 10:41 am. (1 message)

Next thread: Re: [TCP 0/6 net-2.6.26]: tcp_proc_register simplification (resend) by David Miller on Monday, April 14, 2008 - 1:22 am. (1 message)
To: Rafael J. Wysocki <rjw@...>
Cc: Linux Kernel Mailing List <linux-kernel@...>, Adrian Bunk <bunk@...>, Andrew Morton <akpm@...>, Linus Torvalds <torvalds@...>, Natalie Protasevich <protasnb@...>, Linux Netdev List <netdev@...>, <andy@...>, Pavel Emelyanov <xemul@...>
Date: Sunday, April 13, 2008 - 3:45 pm

This looks like another network-namespace regression.
icmp_send() does:

        net = rt-&gt;u.dst.dev-&gt;nd_net;

The bridge netfilter code attaches a fake dst_entry to the
skb which has dev == NULL when passing it to IPv4 netfilter.

Pavel, do you have a better ideas for fixing this than
instantiating a dst_entry in br_netfilter.c for every
device (or at least for every namespace)?



--
To: Patrick McHardy <kaber@...>
Cc: Linux Netdev List <netdev@...>, <andy@...>
Date: Monday, April 14, 2008 - 4:39 am

Hm... Why not make this dst entry point to looback device? This would
allow us to make the dst entry per-namespace and instantiate it with
the ns's lo.

Thanks,
Pavel
--
To: Pavel Emelyanov <xemul@...>
Cc: Linux Netdev List <netdev@...>, <andy@...>
Date: Monday, April 14, 2008 - 4:50 am

I thought of that myself, but that will result in MTU problems.
The current way is not ideal either (hardcoded MTU of 1500 for
the fake net_device), but that at least works in normal bridge
setups.
--
To: Pavel Emelyanov <xemul@...>
Cc: Rafael J. Wysocki <rjw@...>, Linux Kernel Mailing List <linux-kernel@...>, Natalie Protasevich <protasnb@...>, Linux Netdev List <netdev@...>, <andy@...>
Date: Sunday, April 13, 2008 - 4:06 pm

[CC list trimmed slightly]


The description of the problem was not entirely correct, the
bridge-netfilter dst_entry does have a proper device pointer,
it points to a dummy net_device structure however that doesn't
have a namespace associated with it. This blows up in
__ip_route_output_key.

--
To: Pavel Emelyanov <xemul@...>
Cc: Rafael J. Wysocki <rjw@...>, Linux Kernel Mailing List <linux-kernel@...>, Natalie Protasevich <protasnb@...>, Linux Netdev List <netdev@...>, <andy@...>
Date: Sunday, April 13, 2008 - 4:18 pm

For now I suggest this fix. Andy, could you please test whether it
fixes the problem?
To: Patrick McHardy <kaber@...>
Cc: Pavel Emelyanov <xemul@...>, Rafael J. Wysocki <rjw@...>, Linux Kernel Mailing List <linux-kernel@...>, Natalie Protasevich <protasnb@...>, Linux Netdev List <netdev@...>, <andy@...>
Date: Monday, April 14, 2008 - 4:31 pm

I'm guessing it will.  I've been testing my older kernels today and
somehow I'm unable to reproduce the original problem, so I need to
figure out what is different about my config now and before.

I'll definitely post back when I test this, but I wanted to make sure
you guys knew I was at least trying it. :)

--
To: Andy Gospodarek <andy@...>
Cc: Patrick McHardy <kaber@...>, Pavel Emelyanov <xemul@...>, Rafael J. Wysocki <rjw@...>, Linux Kernel Mailing List <linux-kernel@...>, Natalie Protasevich <protasnb@...>, Linux Netdev List <netdev@...>
Date: Tuesday, April 15, 2008 - 9:14 am

I just got done testing 159d83363b629c91d020734207c1bc788b96af5a and I
can confirm that is resolves my issue.
--
To: Andy Gospodarek <andy@...>
Cc: Pavel Emelyanov <xemul@...>, Rafael J. Wysocki <rjw@...>, Linux Kernel Mailing List <linux-kernel@...>, Natalie Protasevich <protasnb@...>, Linux Netdev List <netdev@...>
Date: Tuesday, April 15, 2008 - 9:16 am

Thanks Andy.


--
To: <kaber@...>
Cc: <xemul@...>, <rjw@...>, <linux-kernel@...>, <protasnb@...>, <netdev@...>, <andy@...>
Date: Monday, April 14, 2008 - 3:46 am

From: Patrick McHardy &lt;kaber@trash.net&gt;

Even though we don't have a test report back yet, I've applied this,
thanks Patrick.
--
Previous thread: UFO csum - udp4_hwcsum_outgoing by Kostya B on Sunday, April 13, 2008 - 10:41 am. (1 message)

Next thread: Re: [TCP 0/6 net-2.6.26]: tcp_proc_register simplification (resend) by David Miller on Monday, April 14, 2008 - 1:22 am. (1 message)
speck-geostationary