Re: [Bugme-new] [Bug 10443] New: VLAN: link level multicasts addresses disappears...

Previous thread: Re: [PATCH 4/4] autofs4 - add miscelaneous device for ioctls by Andrew Morton on Friday, April 11, 2008 - 9:03 pm. (2 messages)

Next thread: [GIT PULL net-2.6.26]: IPv6 Updates by YOSHIFUJI Hideaki / on Friday, April 11, 2008 - 9:49 pm. (2 messages)
From: Andrew Morton
Date: Friday, April 11, 2008 - 9:41 pm

(switched to email.  Please respond via emailed reply-to-all, not via the
bugzilla web interface).


There's a test case in the bugzilla report.


--

From: David Miller
Date: Saturday, April 12, 2008 - 12:10 am

From: Andrew Morton <akpm@linux-foundation.org>

Could be fixed by:

commit 0ed21b321a13421e2dfeaa70a6c324e05e3e91e6
Author: Patrick McHardy <kaber@trash.net>
Date:   Wed Mar 26 00:15:17 2008 -0700

    [VLAN]: Don't copy ALLMULTI/PROMISC flags from underlying device
    
    Changing these flags requires to use dev_set_allmulti/dev_set_promiscuity
    or dev_change_flags. Setting it directly causes two unwanted effects:
    
    - the next dev_change_flags call will notice a difference between
      dev->gflags and the actual flags, enable promisc/allmulti
      mode and incorrectly update dev->gflags
    
    - this keeps the underlying device in promisc/allmulti mode until
      the VLAN device is deleted
    
    Signed-off-by: Patrick McHardy <kaber@trash.net>
    Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/net/8021q/vlan_dev.c b/net/8021q/vlan_dev.c
index 8fbcefe..480ea90 100644
--- a/net/8021q/vlan_dev.c
+++ b/net/8021q/vlan_dev.c
@@ -660,7 +660,7 @@ static int vlan_dev_init(struct net_device *dev)
 	int subclass = 0;
 
 	/* IFF_BROADCAST|IFF_MULTICAST; ??? */
-	dev->flags  = real_dev->flags & ~IFF_UP;
+	dev->flags  = real_dev->flags & ~(IFF_UP | IFF_PROMISC | IFF_ALLMULTI);
 	dev->iflink = real_dev->ifindex;
 	dev->state  = (real_dev->state & ((1<<__LINK_STATE_NOCARRIER) |
 					  (1<<__LINK_STATE_DORMANT))) |
--

From: Patrick McHardy
Date: Saturday, April 12, 2008 - 10:44 pm

Either that patch or this one I guess:

[NET]: Messed multicast lists after dev_mc_sync/unsync

I'll go through our recent multicast fixes and check which
ones make sense for -stable.

From: Patrick McHardy
Date: Saturday, April 12, 2008 - 11:08 pm

The "messed multicast lists" patch is already in the latest -stable
release. I've attached backports of two more multicast fixes.

Dave, could you forward them to -stable please in case you're
fine with them? Thanks.




From: David Miller
Date: Saturday, April 12, 2008 - 11:11 pm

From: Patrick McHardy <kaber@trash.net>

I've already forwarded the second one, but not the first.
I'll forward that one too, thanks!
--

Previous thread: Re: [PATCH 4/4] autofs4 - add miscelaneous device for ioctls by Andrew Morton on Friday, April 11, 2008 - 9:03 pm. (2 messages)

Next thread: [GIT PULL net-2.6.26]: IPv6 Updates by YOSHIFUJI Hideaki / on Friday, April 11, 2008 - 9:49 pm. (2 messages)